Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-27 Thread Yani Ioannou
Hi Pavel, On 8/27/05, Pavel Machek <[EMAIL PROTECTED]> wrote: > Well, with my power-managment hat on: > > we probably want "freeze" functionality to be generic; it makes sense > for other devices, too. > > "My battery is so low I can not use wifi any more" => userspace > freezes wifi. > >

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-27 Thread Pavel Machek
Hi! > > > Please make the interface accept number of seconds (as suggested by Jens) > > > and remove this module parameter. This way interface will be more flexible > > > and cleaner. I really don't see any advantage in doing "echo 1 > ..." > > > instead > > > of "echo x > ..." (Pavel, please

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-27 Thread Pavel Machek
Hi! Please make the interface accept number of seconds (as suggested by Jens) and remove this module parameter. This way interface will be more flexible and cleaner. I really don't see any advantage in doing echo 1 ... instead of echo x ... (Pavel, please explain). Either

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-27 Thread Yani Ioannou
Hi Pavel, On 8/27/05, Pavel Machek [EMAIL PROTECTED] wrote: Well, with my power-managment hat on: we probably want freeze functionality to be generic; it makes sense for other devices, too. My battery is so low I can not use wifi any more = userspace freezes wifi. Now, having this

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-26 Thread Jens Axboe
On Fri, Aug 26 2005, Yani Ioannou wrote: > > Please make the interface accept number of seconds (as suggested by Jens) > > and remove this module parameter. This way interface will be more flexible > > and cleaner. I really don't see any advantage in doing "echo 1 > ..." > > instead > > of "echo

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-26 Thread Jens Axboe
On Fri, Aug 26 2005, Yani Ioannou wrote: Please make the interface accept number of seconds (as suggested by Jens) and remove this module parameter. This way interface will be more flexible and cleaner. I really don't see any advantage in doing echo 1 ... instead of echo x ...

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-25 Thread Yani Ioannou
Hi Bartlomiej, Thank you for your feedback :), as this is my first dabble in ide/block drivers I certainly need it! On 8/25/05, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > +config IDEDISK_FREEZE > > Is there any advantage of having it as a config option? The main reasons I added the

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-25 Thread Bartlomiej Zolnierkiewicz
Hi, On 8/25/05, Yani Ioannou <[EMAIL PROTECTED]> wrote: > Hi all, > > Attached below is a patch heavily based on Jon Escombe's patch, but > implemented as a sysfs attribute as Jens described, with a timeout > (configurable by module/kernel parameter) to ensure the queue isn't > stopped forever.

PATCH: ide: ide-disk freeze support for hdaps

2005-08-25 Thread Yani Ioannou
Hi all, Attached below is a patch heavily based on Jon Escombe's patch, but implemented as a sysfs attribute as Jens described, with a timeout (configurable by module/kernel parameter) to ensure the queue isn't stopped forever. The driver creates a sysfs attribute "/sys/block/hdX/device/freeze",

PATCH: ide: ide-disk freeze support for hdaps

2005-08-25 Thread Yani Ioannou
Hi all, Attached below is a patch heavily based on Jon Escombe's patch, but implemented as a sysfs attribute as Jens described, with a timeout (configurable by module/kernel parameter) to ensure the queue isn't stopped forever. The driver creates a sysfs attribute /sys/block/hdX/device/freeze,

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-25 Thread Bartlomiej Zolnierkiewicz
Hi, On 8/25/05, Yani Ioannou [EMAIL PROTECTED] wrote: Hi all, Attached below is a patch heavily based on Jon Escombe's patch, but implemented as a sysfs attribute as Jens described, with a timeout (configurable by module/kernel parameter) to ensure the queue isn't stopped forever. The

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-25 Thread Yani Ioannou
Hi Bartlomiej, Thank you for your feedback :), as this is my first dabble in ide/block drivers I certainly need it! On 8/25/05, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: +config IDEDISK_FREEZE Is there any advantage of having it as a config option? The main reasons I added the