> > @@ -3406,7 +3429,7 @@
> > if(card == NULL)
> > {
> > printk(KERN_WARNING "maestro: out of memory\n");
> > - return 0;
> > + return -ENOMEM;
>
> request_region is unbalanced in this return path.
Thanks!
Fixed patch below.
Ciao, Marcus
Index:
> Its useful to have version ids. So it would be better people used them more
I wasn't sure, so am happy leaving them in as well :)
I suppose they're an easier way to sync dmesg with code version than
knowing what is in which kernel version.
--
zach
-
To unsubscribe from this list: send the
> - ported to Linux 2.4 PCI API, PCI module based, cleaned up
> return values. (taking into account all the hints Jeff has given
> me ;)
cool :)
> - did NOT change any power management support, since I don't know
> anything about power management.
someone
> > - bumped version.
>
> we might as well just stop using these, they don't mean much of anything
> anymore.
Its useful to have version ids. So it would be better people used them more
> Please read the FAQ at http://www.tux.org/lkml/
>
-
To unsubscribe from this list: send the line
Marcus Meissner <[EMAIL PROTECTED]> ecrit :
[...]
> if( request_region(iobase, 256, card_names[card_type]) == NULL )
> {
> printk(KERN_WARNING "maestro: can't allocate 256 bytes I/O at
>0x%4.4x\n", iobase);
> - return 0;
> - }
> -
> - /* this was
Hi,
I did following changes to maestro.c:
- ported to Linux 2.4 PCI API, PCI module based, cleaned up
return values. (taking into account all the hints Jeff has given
me ;)
- removed compat macros.
- removed global devs list, now using PCI driver data.
Marcus Meissner [EMAIL PROTECTED] ecrit :
[...]
if( request_region(iobase, 256, card_names[card_type]) == NULL )
{
printk(KERN_WARNING maestro: can't allocate 256 bytes I/O at
0x%4.4x\n, iobase);
- return 0;
- }
-
- /* this was tripping up
- ported to Linux 2.4 PCI API, PCI module based, cleaned up
return values. (taking into account all the hints Jeff has given
me ;)
cool :)
- did NOT change any power management support, since I don't know
anything about power management.
someone else
Hi,
I did following changes to maestro.c:
- ported to Linux 2.4 PCI API, PCI module based, cleaned up
return values. (taking into account all the hints Jeff has given
me ;)
- removed compat macros.
- removed global devs list, now using PCI driver data.
@@ -3406,7 +3429,7 @@
if(card == NULL)
{
printk(KERN_WARNING maestro: out of memory\n);
- return 0;
+ return -ENOMEM;
request_region is unbalanced in this return path.
Thanks!
Fixed patch below.
Ciao, Marcus
Index:
- bumped version.
we might as well just stop using these, they don't mean much of anything
anymore.
Its useful to have version ids. So it would be better people used them more
Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line
11 matches
Mail list logo
