Re: RFC: Re: PATCH: udf fs corruption on linux-2.6

2007-06-15 Thread Linus Torvalds
On Fri, 15 Jun 2007, Jan Kara wrote: > > My fix for this problem is already sitting in Andrew's patch queue > (http://lkml.org/lkml/2007/6/11/79). Rich's patch still has a problem - you > cannot call udf_discard_prealloc() from drop_inode() because it is called > under inode_lock and thus you

Re: RFC: Re: PATCH: udf fs corruption on linux-2.6

2007-06-15 Thread Jan Kara
On Thu 14-06-07 15:12:58, Linus Torvalds wrote: > > > On Thu, 14 Jun 2007, Rich Coe wrote: > > > > I've updated the patch below to use drop_inode rather than put_inode. > > > > drop_inode is only called when the last iput() reference to the inode is > > released, where put_inode is called for

Re: RFC: Re: PATCH: udf fs corruption on linux-2.6

2007-06-15 Thread Jan Kara
On Thu 14-06-07 15:12:58, Linus Torvalds wrote: On Thu, 14 Jun 2007, Rich Coe wrote: I've updated the patch below to use drop_inode rather than put_inode. drop_inode is only called when the last iput() reference to the inode is released, where put_inode is called for every iput().

Re: RFC: Re: PATCH: udf fs corruption on linux-2.6

2007-06-15 Thread Linus Torvalds
On Fri, 15 Jun 2007, Jan Kara wrote: My fix for this problem is already sitting in Andrew's patch queue (http://lkml.org/lkml/2007/6/11/79). Rich's patch still has a problem - you cannot call udf_discard_prealloc() from drop_inode() because it is called under inode_lock and thus you

Re: RFC: Re: PATCH: udf fs corruption on linux-2.6

2007-06-14 Thread Linus Torvalds
On Thu, 14 Jun 2007, Rich Coe wrote: > > I've updated the patch below to use drop_inode rather than put_inode. > > drop_inode is only called when the last iput() reference to the inode is > released, where put_inode is called for every iput(). Patch looks fine, but this late in the -rc series,

RFC: Re: PATCH: udf fs corruption on linux-2.6

2007-06-14 Thread Rich Coe
I've updated the patch below to use drop_inode rather than put_inode. drop_inode is only called when the last iput() reference to the inode is released, where put_inode is called for every iput(). Rich On Wed, 13 Jun 2007 15:48:03 -0500 Rich Coe <[EMAIL PROTECTED]> wrote: > Hi Linus, > > This

Re: PATCH: udf fs corruption on linux-2.6

2007-06-14 Thread Jan Kara
Hi Rich, On Wed 13-06-07 15:48:03, Rich Coe wrote: > This patch fixes directory and missing files corruption in fs/udf which > occurs on all known 2.6 releases. > > The corruption occurs because blocks which were pre-alloc'd for a directory > are released back to the fs freelist, but the

Re: PATCH: udf fs corruption on linux-2.6

2007-06-14 Thread Jan Kara
Hi Rich, On Wed 13-06-07 15:48:03, Rich Coe wrote: This patch fixes directory and missing files corruption in fs/udf which occurs on all known 2.6 releases. The corruption occurs because blocks which were pre-alloc'd for a directory are released back to the fs freelist, but the inode's

RFC: Re: PATCH: udf fs corruption on linux-2.6

2007-06-14 Thread Rich Coe
I've updated the patch below to use drop_inode rather than put_inode. drop_inode is only called when the last iput() reference to the inode is released, where put_inode is called for every iput(). Rich On Wed, 13 Jun 2007 15:48:03 -0500 Rich Coe [EMAIL PROTECTED] wrote: Hi Linus, This

Re: RFC: Re: PATCH: udf fs corruption on linux-2.6

2007-06-14 Thread Linus Torvalds
On Thu, 14 Jun 2007, Rich Coe wrote: I've updated the patch below to use drop_inode rather than put_inode. drop_inode is only called when the last iput() reference to the inode is released, where put_inode is called for every iput(). Patch looks fine, but this late in the -rc series, I'd

Re: PATCH: udf fs corruption on linux-2.6

2007-06-13 Thread Chuck Ebbert
On 06/13/2007 04:48 PM, Rich Coe wrote: > Hi Linus, > > This patch fixes directory and missing files corruption in fs/udf which > occurs on all known 2.6 releases. > > The corruption occurs because blocks which were pre-alloc'd for a directory > are released back to the fs freelist, but the

PATCH: udf fs corruption on linux-2.6

2007-06-13 Thread Rich Coe
Hi Linus, This patch fixes directory and missing files corruption in fs/udf which occurs on all known 2.6 releases. The corruption occurs because blocks which were pre-alloc'd for a directory are released back to the fs freelist, but the inode's alloc block information is not updated to

PATCH: udf fs corruption on linux-2.6

2007-06-13 Thread Rich Coe
Hi Linus, This patch fixes directory and missing files corruption in fs/udf which occurs on all known 2.6 releases. The corruption occurs because blocks which were pre-alloc'd for a directory are released back to the fs freelist, but the inode's alloc block information is not updated to

Re: PATCH: udf fs corruption on linux-2.6

2007-06-13 Thread Chuck Ebbert
On 06/13/2007 04:48 PM, Rich Coe wrote: Hi Linus, This patch fixes directory and missing files corruption in fs/udf which occurs on all known 2.6 releases. The corruption occurs because blocks which were pre-alloc'd for a directory are released back to the fs freelist, but the inode's