Re: PROBLEM: 2.4.36.1 hangs.

2008-02-26 Thread Pascal Hambourg
dann frazier a écrit : Correcting the le16_to_cpu placement as Glen described fixes the issue for me. One of my boxes has at least six directories triggering the issue (I must be very unlucky), and Glen's patch fixes it all. Thanks. -- To unsubscribe from this list: send the line

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-26 Thread Willy Tarreau
On Tue, Feb 26, 2008 at 03:13:46AM -0700, dann frazier wrote: > I'm now able to reliably reproduce it by creating/removing a chroot > (pbuilder create on a Debian system, though I'm sure a simpler test > exists). Correcting the le16_to_cpu placement as Glen described > fixes the issue for me. OK

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-26 Thread dann frazier
On Tue, Feb 26, 2008 at 09:16:25AM +0100, Willy Tarreau wrote: > On Mon, Feb 25, 2008 at 09:36:12PM -1000, Glen Nakamura wrote: > > Aloha, > > > > The "ext2_readdir() filp->f_pos fix" patch looks weird... > > Perhaps the "filp->f_pos += le16_to_cpu(de->rec_len);" line should be > > outside of the

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-26 Thread Willy Tarreau
On Mon, Feb 25, 2008 at 09:36:12PM -1000, Glen Nakamura wrote: > Aloha, > > The "ext2_readdir() filp->f_pos fix" patch looks weird... > Perhaps the "filp->f_pos += le16_to_cpu(de->rec_len);" line should be > outside of the if statement like the indentation implies? good catch! At least it's what

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-26 Thread Willy Tarreau
On Mon, Feb 25, 2008 at 09:36:12PM -1000, Glen Nakamura wrote: Aloha, The ext2_readdir() filp-f_pos fix patch looks weird... Perhaps the filp-f_pos += le16_to_cpu(de-rec_len); line should be outside of the if statement like the indentation implies? good catch! At least it's what is done in

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-26 Thread dann frazier
On Tue, Feb 26, 2008 at 09:16:25AM +0100, Willy Tarreau wrote: On Mon, Feb 25, 2008 at 09:36:12PM -1000, Glen Nakamura wrote: Aloha, The ext2_readdir() filp-f_pos fix patch looks weird... Perhaps the filp-f_pos += le16_to_cpu(de-rec_len); line should be outside of the if statement like

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-26 Thread Willy Tarreau
On Tue, Feb 26, 2008 at 03:13:46AM -0700, dann frazier wrote: I'm now able to reliably reproduce it by creating/removing a chroot (pbuilder create on a Debian system, though I'm sure a simpler test exists). Correcting the le16_to_cpu placement as Glen described fixes the issue for me. OK

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-26 Thread Pascal Hambourg
dann frazier a écrit : Correcting the le16_to_cpu placement as Glen described fixes the issue for me. One of my boxes has at least six directories triggering the issue (I must be very unlucky), and Glen's patch fixes it all. Thanks. -- To unsubscribe from this list: send the line

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-25 Thread Glen Nakamura
Aloha, The "ext2_readdir() filp->f_pos fix" patch looks weird... Perhaps the "filp->f_pos += le16_to_cpu(de->rec_len);" line should be outside of the if statement like the indentation implies? As it is, filp->f_pos gets corrupted if de->inode is ever zero... This could possibly explain why I had

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-25 Thread Glen Nakamura
Aloha, The ext2_readdir() filp-f_pos fix patch looks weird... Perhaps the filp-f_pos += le16_to_cpu(de-rec_len); line should be outside of the if statement like the indentation implies? As it is, filp-f_pos gets corrupted if de-inode is ever zero... This could possibly explain why I had a few

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-24 Thread Pascal Hambourg
Hello, Willy Tarreau wrote : On Fri, Feb 22, 2008 at 03:08:30PM +0100, Unknown wrote: 2) 2.4.36.1 hangs during compilation of lighttpd-1.4.18. It is probably during ext2_readdir() but I cannot confirm that.. Currently it only happens during compilation of lighttpd-1.4.18, always in the

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-24 Thread Willy Tarreau
On Sun, Feb 24, 2008 at 07:12:04PM +0100, Pascal Hambourg wrote: > Hello, > > Willy Tarreau wrote : > > > >On Fri, Feb 22, 2008 at 03:08:30PM +0100, Unknown wrote: > > > >>2) 2.4.36.1 hangs during compilation of lighttpd-1.4.18. > >> It is probably during ext2_readdir() but I cannot confirm

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-24 Thread Pascal Hambourg
Hello, Willy Tarreau wrote : On Fri, Feb 22, 2008 at 03:08:30PM +0100, Unknown wrote: 2) 2.4.36.1 hangs during compilation of lighttpd-1.4.18. It is probably during ext2_readdir() but I cannot confirm that.. Currently it only happens during compilation of lighttpd-1.4.18, always in the

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-24 Thread Willy Tarreau
On Sun, Feb 24, 2008 at 07:12:04PM +0100, Pascal Hambourg wrote: Hello, Willy Tarreau wrote : On Fri, Feb 22, 2008 at 03:08:30PM +0100, Unknown wrote: 2) 2.4.36.1 hangs during compilation of lighttpd-1.4.18. It is probably during ext2_readdir() but I cannot confirm that.. Currently

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-23 Thread Willy Tarreau
Hello, first, thanks for your detailed report. On Fri, Feb 22, 2008 at 03:08:30PM +0100, Unknown wrote: > 1) 2.4.36.1 hangs (probably during ext2_readdir()) > > 2) 2.4.36.1 hangs during compilation of lighttpd-1.4.18. >It is probably during ext2_readdir() but I cannot confirm that.. >

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-23 Thread Willy Tarreau
Hello, first, thanks for your detailed report. On Fri, Feb 22, 2008 at 03:08:30PM +0100, Unknown wrote: 1) 2.4.36.1 hangs (probably during ext2_readdir()) 2) 2.4.36.1 hangs during compilation of lighttpd-1.4.18. It is probably during ext2_readdir() but I cannot confirm that..

PROBLEM: 2.4.36.1 hangs.

2008-02-22 Thread Unknown
1) 2.4.36.1 hangs (probably during ext2_readdir()) 2) 2.4.36.1 hangs during compilation of lighttpd-1.4.18. It is probably during ext2_readdir() but I cannot confirm that.. Currently it only happens during compilation of lighttpd-1.4.18, always in the same place. Kernel 2.4.36 w/

PROBLEM: 2.4.36.1 hangs.

2008-02-22 Thread Unknown
1) 2.4.36.1 hangs (probably during ext2_readdir()) 2) 2.4.36.1 hangs during compilation of lighttpd-1.4.18. It is probably during ext2_readdir() but I cannot confirm that.. Currently it only happens during compilation of lighttpd-1.4.18, always in the same place. Kernel 2.4.36 w/