Re: Possible regression with cgroups in 3.11

2013-11-25 Thread Bjorn Helgaas
On Wed, Nov 20, 2013 at 9:47 PM, Bjorn Helgaas wrote: > [+cc Jiri] > > On Wed, Nov 20, 2013 at 9:26 PM, Sasha Levin wrote: >> On 11/18/2013 03:39 PM, Bjorn Helgaas wrote: >>> >>> On Mon, Nov 18, 2013 at 11:29:32AM -0800, Yinghai Lu wrote: On Mon, Nov 18, 2013 at 10:14 AM, Bjorn Helgaas

Re: Possible regression with cgroups in 3.11

2013-11-25 Thread Bjorn Helgaas
On Wed, Nov 20, 2013 at 9:47 PM, Bjorn Helgaas bhelg...@google.com wrote: [+cc Jiri] On Wed, Nov 20, 2013 at 9:26 PM, Sasha Levin sasha.le...@oracle.com wrote: On 11/18/2013 03:39 PM, Bjorn Helgaas wrote: On Mon, Nov 18, 2013 at 11:29:32AM -0800, Yinghai Lu wrote: On Mon, Nov 18, 2013 at

Re: Possible regression with cgroups in 3.11

2013-11-20 Thread Bjorn Helgaas
[+cc Jiri] On Wed, Nov 20, 2013 at 9:26 PM, Sasha Levin wrote: > On 11/18/2013 03:39 PM, Bjorn Helgaas wrote: >> >> On Mon, Nov 18, 2013 at 11:29:32AM -0800, Yinghai Lu wrote: >>> >>> On Mon, Nov 18, 2013 at 10:14 AM, Bjorn Helgaas >>> wrote: > > A bit of comment here would be nice but

Re: Possible regression with cgroups in 3.11

2013-11-20 Thread Sasha Levin
On 11/18/2013 03:39 PM, Bjorn Helgaas wrote: On Mon, Nov 18, 2013 at 11:29:32AM -0800, Yinghai Lu wrote: On Mon, Nov 18, 2013 at 10:14 AM, Bjorn Helgaas wrote: A bit of comment here would be nice but yeah I think this should work. Can you please also queue the revert of c2fda509667b

Re: Possible regression with cgroups in 3.11

2013-11-20 Thread Sasha Levin
On 11/18/2013 03:39 PM, Bjorn Helgaas wrote: On Mon, Nov 18, 2013 at 11:29:32AM -0800, Yinghai Lu wrote: On Mon, Nov 18, 2013 at 10:14 AM, Bjorn Helgaas bhelg...@google.com wrote: A bit of comment here would be nice but yeah I think this should work. Can you please also queue the revert of

Re: Possible regression with cgroups in 3.11

2013-11-20 Thread Bjorn Helgaas
[+cc Jiri] On Wed, Nov 20, 2013 at 9:26 PM, Sasha Levin sasha.le...@oracle.com wrote: On 11/18/2013 03:39 PM, Bjorn Helgaas wrote: On Mon, Nov 18, 2013 at 11:29:32AM -0800, Yinghai Lu wrote: On Mon, Nov 18, 2013 at 10:14 AM, Bjorn Helgaas bhelg...@google.com wrote: A bit of comment here

Re: Possible regression with cgroups in 3.11

2013-11-18 Thread Bjorn Helgaas
On Mon, Nov 18, 2013 at 11:29:32AM -0800, Yinghai Lu wrote: > On Mon, Nov 18, 2013 at 10:14 AM, Bjorn Helgaas wrote: > >> A bit of comment here would be nice but yeah I think this should work. > >> Can you please also queue the revert of c2fda509667b ("workqueue: > >> allow work_on_cpu() to be

Re: Possible regression with cgroups in 3.11

2013-11-18 Thread Yinghai Lu
On Mon, Nov 18, 2013 at 10:14 AM, Bjorn Helgaas wrote: >> A bit of comment here would be nice but yeah I think this should work. >> Can you please also queue the revert of c2fda509667b ("workqueue: >> allow work_on_cpu() to be called recursively") after this patch? >> Please feel free to add my

Re: Possible regression with cgroups in 3.11

2013-11-18 Thread Bjorn Helgaas
On Sat, Nov 16, 2013 at 01:53:56PM +0900, Tejun Heo wrote: > Hello, Bjorn. > > On Fri, Nov 15, 2013 at 05:28:20PM -0700, Bjorn Helgaas wrote: > > It would be better to fix PCI so we don't call VF driver .probe() methods > > from inside a PF driver .probe() method, but that's a bigger project. >

Re: Possible regression with cgroups in 3.11

2013-11-18 Thread Bjorn Helgaas
On Sat, Nov 16, 2013 at 01:53:56PM +0900, Tejun Heo wrote: Hello, Bjorn. On Fri, Nov 15, 2013 at 05:28:20PM -0700, Bjorn Helgaas wrote: It would be better to fix PCI so we don't call VF driver .probe() methods from inside a PF driver .probe() method, but that's a bigger project. Yeah,

Re: Possible regression with cgroups in 3.11

2013-11-18 Thread Yinghai Lu
On Mon, Nov 18, 2013 at 10:14 AM, Bjorn Helgaas bhelg...@google.com wrote: A bit of comment here would be nice but yeah I think this should work. Can you please also queue the revert of c2fda509667b (workqueue: allow work_on_cpu() to be called recursively) after this patch? Please feel free to

Re: Possible regression with cgroups in 3.11

2013-11-18 Thread Bjorn Helgaas
On Mon, Nov 18, 2013 at 11:29:32AM -0800, Yinghai Lu wrote: On Mon, Nov 18, 2013 at 10:14 AM, Bjorn Helgaas bhelg...@google.com wrote: A bit of comment here would be nice but yeah I think this should work. Can you please also queue the revert of c2fda509667b (workqueue: allow work_on_cpu()

Re: Possible regression with cgroups in 3.11

2013-11-15 Thread Tejun Heo
Hello, Bjorn. On Fri, Nov 15, 2013 at 05:28:20PM -0700, Bjorn Helgaas wrote: > It would be better to fix PCI so we don't call VF driver .probe() methods > from inside a PF driver .probe() method, but that's a bigger project. Yeah, if pci doesn't need the recursion, we can simply revert restore

Re: Possible regression with cgroups in 3.11

2013-11-15 Thread Bjorn Helgaas
On Wed, Nov 13, 2013 at 04:38:06PM +0900, Tejun Heo wrote: > Hey, guys. > > cc'ing people from "workqueue, pci: INFO: possible recursive locking > detected" thread. > > http://thread.gmane.org/gmane.linux.kernel/1525779 > > So, to resolve that issue, we ripped out lockdep annotation from >

Re: Possible regression with cgroups in 3.11

2013-11-15 Thread Bjorn Helgaas
On Wed, Nov 13, 2013 at 04:38:06PM +0900, Tejun Heo wrote: Hey, guys. cc'ing people from workqueue, pci: INFO: possible recursive locking detected thread. http://thread.gmane.org/gmane.linux.kernel/1525779 So, to resolve that issue, we ripped out lockdep annotation from work_on_cpu()

Re: Possible regression with cgroups in 3.11

2013-11-15 Thread Tejun Heo
Hello, Bjorn. On Fri, Nov 15, 2013 at 05:28:20PM -0700, Bjorn Helgaas wrote: It would be better to fix PCI so we don't call VF driver .probe() methods from inside a PF driver .probe() method, but that's a bigger project. Yeah, if pci doesn't need the recursion, we can simply revert restore the

Re: Possible regression with cgroups in 3.11

2013-11-12 Thread Tejun Heo
Hey, guys. cc'ing people from "workqueue, pci: INFO: possible recursive locking detected" thread. http://thread.gmane.org/gmane.linux.kernel/1525779 So, to resolve that issue, we ripped out lockdep annotation from work_on_cpu() and cgroup is now experiencing deadlock involving work_on_cpu().

Re: Possible regression with cgroups in 3.11

2013-11-12 Thread Tejun Heo
Hey, guys. cc'ing people from workqueue, pci: INFO: possible recursive locking detected thread. http://thread.gmane.org/gmane.linux.kernel/1525779 So, to resolve that issue, we ripped out lockdep annotation from work_on_cpu() and cgroup is now experiencing deadlock involving work_on_cpu().