Potential NULL pointer deference in iwlwifi: mvm

2019-10-09 Thread Yizhuo Zhai
Hi All: drivers/net/wireless/intel/iwlwifi/mvm/power.c: The function iwl_mvm_vif_from_mac80211() could return NULL, but some callers in this file does not check the return value while directly dereference it, which seems potentially unsafe. Such callers include iwl_mvm_update_d0i3_power_mode(), i

Re: Potential NULL pointer deference in iwlwifi: mvm

2019-10-07 Thread Johannes Berg
On Mon, 2019-10-07 at 12:19 -0700, Yizhuo Zhai wrote: > Hi All: > > drivers/net/wireless/intel/iwlwifi/mvm/scan.c: > > Inside function iwl_mvm_power_ps_disabled_iterator(), > iwl_mvm_vif_from_mac80211() > could return NULL No, it can not. Whatever tool you've used to find this - you should fix

Potential NULL pointer deference in iwlwifi: mvm

2019-10-07 Thread Yizhuo Zhai
Hi All: drivers/net/wireless/intel/iwlwifi/mvm/scan.c: Inside function iwl_mvm_power_ps_disabled_iterator(), iwl_mvm_vif_from_mac80211() could return NULL,however, the return value of iwl_mvm_vif_from_mac80211() is not checked and get used. This could potentially be unsafe. -- Kind Regards, Yi