Re: Potential data race in psmouse_interrupt

I've mailed a separate patch that does serio_pause_rx before reading out data ("input: fix data race __ps2_command"). On Sat, Sep 5, 2015 at 3:21 PM, Dmitry Vyukov wrote: > On Fri, Sep 4, 2015 at 10:27 PM, Dmitry Torokhov > wrote: >> On Fri, Sep 4, 2015 at 12:32 PM, Dmitry Vyukov wrote: >>>

Re: Potential data race in psmouse_interrupt

I've mailed a separate patch that does serio_pause_rx before reading out data ("input: fix data race __ps2_command"). On Sat, Sep 5, 2015 at 3:21 PM, Dmitry Vyukov wrote: > On Fri, Sep 4, 2015 at 10:27 PM, Dmitry Torokhov > wrote: >> On Fri, Sep

Re: Potential data race in psmouse_interrupt

On Fri, Sep 4, 2015 at 10:27 PM, Dmitry Torokhov wrote: > On Fri, Sep 4, 2015 at 12:32 PM, Dmitry Vyukov wrote: >> On Fri, Sep 4, 2015 at 6:56 PM, Dmitry Torokhov >> wrote: >>> On Tue, Sep 1, 2015 at 11:46 AM, Dmitry Vyukov wrote: On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov

Re: Potential data race in psmouse_interrupt

On Fri, Sep 4, 2015 at 10:27 PM, Dmitry Torokhov wrote: > On Fri, Sep 4, 2015 at 12:32 PM, Dmitry Vyukov wrote: >> On Fri, Sep 4, 2015 at 6:56 PM, Dmitry Torokhov >> wrote: >>> On Tue, Sep 1, 2015 at 11:46 AM, Dmitry

Re: Potential data race in psmouse_interrupt

On Fri, Sep 4, 2015 at 12:32 PM, Dmitry Vyukov wrote: > On Fri, Sep 4, 2015 at 6:56 PM, Dmitry Torokhov > wrote: >> On Tue, Sep 1, 2015 at 11:46 AM, Dmitry Vyukov wrote: >>> On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov >>> wrote: On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote:

Re: Potential data race in psmouse_interrupt

On Fri, Sep 4, 2015 at 6:56 PM, Dmitry Torokhov wrote: > On Tue, Sep 1, 2015 at 11:46 AM, Dmitry Vyukov wrote: >> On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov >> wrote: >>> On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote: On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov

Re: Potential data race in psmouse_interrupt

On Tue, Sep 1, 2015 at 11:46 AM, Dmitry Vyukov wrote: > On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov > wrote: >> On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote: >>> On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov >>> wrote: On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov

Re: Potential data race in psmouse_interrupt

On Tue, Sep 1, 2015 at 11:46 AM, Dmitry Vyukov wrote: > On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov > wrote: >> On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote: >>> On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov >>>

Re: Potential data race in psmouse_interrupt

On Fri, Sep 4, 2015 at 6:56 PM, Dmitry Torokhov wrote: > On Tue, Sep 1, 2015 at 11:46 AM, Dmitry Vyukov wrote: >> On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov >> wrote: >>> On Fri, Aug 28, 2015 at 11:08 AM, Dmitry

Re: Potential data race in psmouse_interrupt

On Fri, Sep 4, 2015 at 12:32 PM, Dmitry Vyukov wrote: > On Fri, Sep 4, 2015 at 6:56 PM, Dmitry Torokhov > wrote: >> On Tue, Sep 1, 2015 at 11:46 AM, Dmitry Vyukov wrote: >>> On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov >>>

Re: Potential data race in psmouse_interrupt

On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov wrote: > On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote: >> On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov >> wrote: >>> On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov wrote: Hello, I am looking at this code in

Re: Potential data race in psmouse_interrupt

On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov wrote: > On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote: >> On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov >> wrote: >>> On Fri, Aug 28, 2015 at 10:34 AM, Dmitry

Re: Potential data race in psmouse_interrupt

On Fri, Aug 28, 2015 at 11:32 AM, Dmitry Torokhov wrote: > On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote: >> On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov >> wrote: >>> On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov wrote: Hello, I am looking at this code in

Re: Potential data race in psmouse_interrupt

On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote: > On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov > wrote: >> On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov wrote: >>> Hello, >>> >>> I am looking at this code in __ps2_command again: >>> >>> /* >>> * The reset command takes a long time

Re: Potential data race in psmouse_interrupt

On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov wrote: > On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov wrote: >> Hello, >> >> I am looking at this code in __ps2_command again: >> >> /* >> * The reset command takes a long time to execute. >> */ >> timeout = msecs_to_jiffies(command ==

Re: Potential data race in psmouse_interrupt

On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov wrote: > Hello, > > I am looking at this code in __ps2_command again: > > /* > * The reset command takes a long time to execute. > */ > timeout = msecs_to_jiffies(command == PS2_CMD_RESET_BAT ? 4000 : 500); > > timeout =

Re: Potential data race in psmouse_interrupt

Hello, I am looking at this code in __ps2_command again: /* * The reset command takes a long time to execute. */ timeout = msecs_to_jiffies(command == PS2_CMD_RESET_BAT ? 4000 : 500); timeout = wait_event_timeout(ps2dev->wait, !(READ_ONCE(ps2dev->flags) & PS2_FLAG_CMD1), timeout); if

Re: Potential data race in psmouse_interrupt

Hello, I am looking at this code in __ps2_command again: /* * The reset command takes a long time to execute. */ timeout = msecs_to_jiffies(command == PS2_CMD_RESET_BAT ? 4000 : 500); timeout = wait_event_timeout(ps2dev-wait, !(READ_ONCE(ps2dev-flags) PS2_FLAG_CMD1), timeout); if

Re: Potential data race in psmouse_interrupt

On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov dvyu...@google.com wrote: Hello, I am looking at this code in __ps2_command again: /* * The reset command takes a long time to execute. */ timeout = msecs_to_jiffies(command == PS2_CMD_RESET_BAT ? 4000 : 500); timeout =

Re: Potential data race in psmouse_interrupt

On Fri, Aug 28, 2015 at 11:32 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov dvyu...@google.com wrote: On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov

Re: Potential data race in psmouse_interrupt

On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov dvyu...@google.com wrote: Hello, I am looking at this code in __ps2_command again: /* * The reset command takes a long time to execute. */ timeout =

Re: Potential data race in psmouse_interrupt

On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov dvyu...@google.com wrote: On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov dvyu...@google.com wrote: Hello, I am looking at this code in __ps2_command again: /*

Re: Potential data race in psmouse_interrupt

Hi! This log looks like there can be race condition in initialization code, but not in receiving ALPS packets after initialization... On Thursday 23 July 2015 15:31:46 Andrey Konovalov wrote: > Hi Pali, > > There are a few reports in psmouse-base.c/alps.c code as well. > Here is a couple of them

Re: Potential data race in psmouse_interrupt

Hi! This log looks like there can be race condition in initialization code, but not in receiving ALPS packets after initialization... On Thursday 23 July 2015 15:31:46 Andrey Konovalov wrote: Hi Pali, There are a few reports in psmouse-base.c/alps.c code as well. Here is a couple of them

Re: Potential data race in psmouse_interrupt

Hi Pali, There are a few reports in psmouse-base.c/alps.c code as well. Here is a couple of them that are printed one right after another. The second one tells about a race on ps2dev->cmdcnt. == ThreadSanitizer: data-race in

Re: Potential data race in psmouse_interrupt

On Wednesday 22 July 2015 15:14:42 Andrey Konovalov wrote: > Hi! > > We are working on a dynamic data race detector for Linux kernel called > KernelThreadSanitizer (ktsan) (https://github.com/google/ktsan/wiki). > > Here is a report we got while running ktsan (upstream revision >

Re: Potential data race in psmouse_interrupt

Hi Pali, There are a few reports in psmouse-base.c/alps.c code as well. Here is a couple of them that are printed one right after another. The second one tells about a race on ps2dev-cmdcnt. == ThreadSanitizer: data-race in

Re: Potential data race in psmouse_interrupt

On Wednesday 22 July 2015 15:14:42 Andrey Konovalov wrote: Hi! We are working on a dynamic data race detector for Linux kernel called KernelThreadSanitizer (ktsan) (https://github.com/google/ktsan/wiki). Here is a report we got while running ktsan (upstream revision

Re: Fwd: Potential data race in psmouse_interrupt

On Wed, Jul 22, 2015 at 03:14:42PM +0200, Andrey Konovalov wrote: > Hi! > > We are working on a dynamic data race detector for Linux kernel called > KernelThreadSanitizer (ktsan) (https://github.com/google/ktsan/wiki). > > Here is a report we got while running ktsan (upstream revision >

Fwd: Potential data race in psmouse_interrupt

Hi! We are working on a dynamic data race detector for Linux kernel called KernelThreadSanitizer (ktsan) (https://github.com/google/ktsan/wiki). Here is a report we got while running ktsan (upstream revision 21bdb584af8cca7c6df3c44cba268be050a234eb).

Re: Fwd: Potential data race in psmouse_interrupt

On Wed, Jul 22, 2015 at 03:14:42PM +0200, Andrey Konovalov wrote: Hi! We are working on a dynamic data race detector for Linux kernel called KernelThreadSanitizer (ktsan) (https://github.com/google/ktsan/wiki). Here is a report we got while running ktsan (upstream revision

Fwd: Potential data race in psmouse_interrupt

Hi! We are working on a dynamic data race detector for Linux kernel called KernelThreadSanitizer (ktsan) (https://github.com/google/ktsan/wiki). Here is a report we got while running ktsan (upstream revision 21bdb584af8cca7c6df3c44cba268be050a234eb).