Re: RDMA/rpma + fsdax(ext4) was broken since 36f30e486d

2021-08-27 Thread Jason Gunthorpe
On Fri, Aug 27, 2021 at 09:42:21AM -0700, Dan Williams wrote: > On Fri, Aug 27, 2021 at 6:05 AM Li, Zhijian wrote: > > > > > > on 2021/8/27 20:10, Jason Gunthorpe wrote: > > > On Fri, Aug 27, 2021 at 08:15:40AM +, lizhij...@fujitsu.com wrote: > > >> i looked over the change-log of

Re: RDMA/rpma + fsdax(ext4) was broken since 36f30e486d

2021-08-27 Thread Dan Williams
On Fri, Aug 27, 2021 at 6:05 AM Li, Zhijian wrote: > > > on 2021/8/27 20:10, Jason Gunthorpe wrote: > > On Fri, Aug 27, 2021 at 08:15:40AM +, lizhij...@fujitsu.com wrote: > >> i looked over the change-log of hmm_vma_handle_pte(), and found that before > >> 4055062 ("mm/hmm: add missing call

Re: RDMA/rpma + fsdax(ext4) was broken since 36f30e486d

2021-08-27 Thread Li, Zhijian
on 2021/8/27 21:16, Jason Gunthorpe wrote: On Fri, Aug 27, 2021 at 09:05:21PM +0800, Li, Zhijian wrote: Yes, can you send a proper patch and include the mm mailing list? Of course, my pleasure Thanks

Re: RDMA/rpma + fsdax(ext4) was broken since 36f30e486d

2021-08-27 Thread Jason Gunthorpe
On Fri, Aug 27, 2021 at 09:05:21PM +0800, Li, Zhijian wrote: > > on 2021/8/27 20:10, Jason Gunthorpe wrote: > > On Fri, Aug 27, 2021 at 08:15:40AM +, lizhij...@fujitsu.com wrote: > > > i looked over the change-log of hmm_vma_handle_pte(), and found that > > > before > > > 4055062 ("mm/hmm:

Re: RDMA/rpma + fsdax(ext4) was broken since 36f30e486d

2021-08-27 Thread Li, Zhijian
on 2021/8/27 20:10, Jason Gunthorpe wrote: On Fri, Aug 27, 2021 at 08:15:40AM +, lizhij...@fujitsu.com wrote: i looked over the change-log of hmm_vma_handle_pte(), and found that before 4055062 ("mm/hmm: add missing call to hmm_pte_need_fault in HMM_PFN_SPECIAL handling")

Re: RDMA/rpma + fsdax(ext4) was broken since 36f30e486d

2021-08-27 Thread Jason Gunthorpe
On Fri, Aug 27, 2021 at 08:15:40AM +, lizhij...@fujitsu.com wrote: > i looked over the change-log of hmm_vma_handle_pte(), and found that before > 4055062 ("mm/hmm: add missing call to hmm_pte_need_fault in HMM_PFN_SPECIAL > handling") > > hmm_vma_handle_pte() will not check pte_special(pte)

Re: RDMA/rpma + fsdax(ext4) was broken since 36f30e486d

2021-08-27 Thread lizhij...@fujitsu.com
Hi all I have verified that below changes can solve this problem diff --git a/mm/hmm.c b/mm/hmm.c index 24f9ff95f3ae..2c9a3e3eefce 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -294,7 +294,7 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, * Since each architecture