Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-12 Thread David Miller
Please do not top-post. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-12 Thread Stam, Michel [FINT]
Hello Ben, Regarding the code snippet; Good question, The original code didn't do this either, which is why I left it as it is. It could cause undesirable behaviour, agreed. After a quick driver examination: I do see that asix_set_sw_mii and asix_set_hw_mii are called prior to the actual

RE: asix: Don't reset PHY on if_up for ASIX 88772 breaks net on arndale platform

2014-11-12 Thread Stam, Michel [FINT]
Hello Ben, Regarding the code snippet; Good question, The original code didn't do this either, which is why I left it as it is. It could cause undesirable behaviour, agreed. After a quick driver examination: I do see that asix_set_sw_mii and asix_set_hw_mii are called prior to the actual

Re: asix: Don't reset PHY on if_up for ASIX 88772 breaks net on arndale platform

2014-11-12 Thread David Miller
Please do not top-post. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-11 Thread Ben Hutchings
On Tue, 2014-11-04 at 20:09 +, Charles Keepax wrote: > On Tue, Nov 04, 2014 at 11:23:06AM +0100, Stam, Michel [FINT] wrote: > > Hello Riku, > > > > >Fixing a bug (ethtool support) must not cause breakage elsewhere (in > > this case on arndale). This is now a regression of functionality from >

Re: asix: Don't reset PHY on if_up for ASIX 88772 breaks net on arndale platform

2014-11-11 Thread Ben Hutchings
On Tue, 2014-11-04 at 20:09 +, Charles Keepax wrote: On Tue, Nov 04, 2014 at 11:23:06AM +0100, Stam, Michel [FINT] wrote: Hello Riku, Fixing a bug (ethtool support) must not cause breakage elsewhere (in this case on arndale). This is now a regression of functionality from 3.17.

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-06 Thread Charles Keepax
On Thu, Nov 06, 2014 at 01:39:07PM +0100, Stam, Michel [FINT] wrote: > Hello Riku and Charles, > > I tried this with my original patch and the suggested patch applied, > this seems to work for me too. > > One thing that bothers me, is the suspend / resume situation; usbnet.c > seems to call the

RE: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-06 Thread Stam, Michel [FINT]
Hello Riku and Charles, I tried this with my original patch and the suggested patch applied, this seems to work for me too. One thing that bothers me, is the suspend / resume situation; usbnet.c seems to call the bind( ) on probe( ). Suspend / resume do not seem to call bind( ) directly. As

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-06 Thread Riku Voipio
On Thu, Nov 06, 2014 at 10:01:04AM +, Charles Keepax wrote: > On Thu, Nov 06, 2014 at 11:06:51AM +0200, Riku Voipio wrote: > > The asix on arndale comes semi-configured from u-boot, which I guess is > > not the state kernel expects it to come in. At least in my case where > > I use tftp from

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-06 Thread Charles Keepax
On Thu, Nov 06, 2014 at 11:06:51AM +0200, Riku Voipio wrote: > On Wed, Nov 05, 2014 at 03:02:58PM +, Charles Keepax wrote: > > On Wed, Nov 05, 2014 at 01:04:37PM +0100, Stam, Michel [FINT] wrote: > > > Hello Charles, > > > > > > After looking around I found the reset value for the 8772 chip,

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-06 Thread Riku Voipio
On Wed, Nov 05, 2014 at 03:02:58PM +, Charles Keepax wrote: > On Wed, Nov 05, 2014 at 01:04:37PM +0100, Stam, Michel [FINT] wrote: > > Hello Charles, > > > > After looking around I found the reset value for the 8772 chip, which > > seems to be 0x1E1 (ANAR register). > > > > This equates to

Re: asix: Don't reset PHY on if_up for ASIX 88772 breaks net on arndale platform

2014-11-06 Thread Riku Voipio
On Wed, Nov 05, 2014 at 03:02:58PM +, Charles Keepax wrote: On Wed, Nov 05, 2014 at 01:04:37PM +0100, Stam, Michel [FINT] wrote: Hello Charles, After looking around I found the reset value for the 8772 chip, which seems to be 0x1E1 (ANAR register). This equates to (according to

Re: asix: Don't reset PHY on if_up for ASIX 88772 breaks net on arndale platform

2014-11-06 Thread Charles Keepax
On Thu, Nov 06, 2014 at 11:06:51AM +0200, Riku Voipio wrote: On Wed, Nov 05, 2014 at 03:02:58PM +, Charles Keepax wrote: On Wed, Nov 05, 2014 at 01:04:37PM +0100, Stam, Michel [FINT] wrote: Hello Charles, After looking around I found the reset value for the 8772 chip, which

Re: asix: Don't reset PHY on if_up for ASIX 88772 breaks net on arndale platform

2014-11-06 Thread Riku Voipio
On Thu, Nov 06, 2014 at 10:01:04AM +, Charles Keepax wrote: On Thu, Nov 06, 2014 at 11:06:51AM +0200, Riku Voipio wrote: The asix on arndale comes semi-configured from u-boot, which I guess is not the state kernel expects it to come in. At least in my case where I use tftp from u-boot

RE: asix: Don't reset PHY on if_up for ASIX 88772 breaks net on arndale platform

2014-11-06 Thread Stam, Michel [FINT]
Hello Riku and Charles, I tried this with my original patch and the suggested patch applied, this seems to work for me too. One thing that bothers me, is the suspend / resume situation; usbnet.c seems to call the bind( ) on probe( ). Suspend / resume do not seem to call bind( ) directly. As

Re: asix: Don't reset PHY on if_up for ASIX 88772 breaks net on arndale platform

2014-11-06 Thread Charles Keepax
On Thu, Nov 06, 2014 at 01:39:07PM +0100, Stam, Michel [FINT] wrote: Hello Riku and Charles, I tried this with my original patch and the suggested patch applied, this seems to work for me too. One thing that bothers me, is the suspend / resume situation; usbnet.c seems to call the bind( )

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-04 Thread Charles Keepax
On Tue, Nov 04, 2014 at 11:23:06AM +0100, Stam, Michel [FINT] wrote: > Hello Riku, > > >Fixing a bug (ethtool support) must not cause breakage elsewhere (in > this case on arndale). This is now a regression of functionality from > 3.17. > > > >I think it would better to revert the change now and

RE: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-04 Thread Stam, Michel [FINT]
Hello Riku, >Fixing a bug (ethtool support) must not cause breakage elsewhere (in this case on arndale). This is now a regression of functionality from 3.17. > >I think it would better to revert the change now and with less hurry introduce a ethtool fix that doesn't break arndale. I don't fully

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-04 Thread Riku Voipio
On Tue, Nov 04, 2014 at 09:19:26AM +0100, Stam, Michel [FINT] wrote: > Interesting, as the commit itself is a revert from a kernel back to 2.6 > somewhere. The problem I had is related to the PHY being reset on > interface-up, can you confirm that you require this? I can't confirm what exactly is

RE: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-04 Thread Stam, Michel [FINT]
Hello Riku, Interesting, as the commit itself is a revert from a kernel back to 2.6 somewhere. The problem I had is related to the PHY being reset on interface-up, can you confirm that you require this? Reverting this breaks ethtool support in turn. Kind regards, Michel Stam -Original

RE: asix: Don't reset PHY on if_up for ASIX 88772 breaks net on arndale platform

2014-11-04 Thread Stam, Michel [FINT]
Hello Riku, Interesting, as the commit itself is a revert from a kernel back to 2.6 somewhere. The problem I had is related to the PHY being reset on interface-up, can you confirm that you require this? Reverting this breaks ethtool support in turn. Kind regards, Michel Stam -Original

Re: asix: Don't reset PHY on if_up for ASIX 88772 breaks net on arndale platform

2014-11-04 Thread Riku Voipio
On Tue, Nov 04, 2014 at 09:19:26AM +0100, Stam, Michel [FINT] wrote: Interesting, as the commit itself is a revert from a kernel back to 2.6 somewhere. The problem I had is related to the PHY being reset on interface-up, can you confirm that you require this? I can't confirm what exactly is

RE: asix: Don't reset PHY on if_up for ASIX 88772 breaks net on arndale platform

2014-11-04 Thread Stam, Michel [FINT]
Hello Riku, Fixing a bug (ethtool support) must not cause breakage elsewhere (in this case on arndale). This is now a regression of functionality from 3.17. I think it would better to revert the change now and with less hurry introduce a ethtool fix that doesn't break arndale. I don't fully

Re: asix: Don't reset PHY on if_up for ASIX 88772 breaks net on arndale platform

2014-11-04 Thread Charles Keepax
On Tue, Nov 04, 2014 at 11:23:06AM +0100, Stam, Michel [FINT] wrote: Hello Riku, Fixing a bug (ethtool support) must not cause breakage elsewhere (in this case on arndale). This is now a regression of functionality from 3.17. I think it would better to revert the change now and with less