Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-13 Thread Neil Horman
On Wed, Nov 13, 2013 at 01:32:50PM -, David Laight wrote: > > > I'm not sure, whats the typical capacity for the branch predictors > > > ability to remember code paths? > ... > > > > For such simple single-target branches it goes near or over a thousand for > > recent Intel and AMD microarchit

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-13 Thread Ingo Molnar
* David Laight wrote: > > > I'm not sure, whats the typical capacity for the branch predictors > > > ability to remember code paths? > ... > > > > For such simple single-target branches it goes near or over a thousand > > for recent Intel and AMD microarchitectures. Thousands for really > >

RE: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-13 Thread David Laight
> > I'm not sure, whats the typical capacity for the branch predictors > > ability to remember code paths? ... > > For such simple single-target branches it goes near or over a thousand for > recent Intel and AMD microarchitectures. Thousands for really recent CPUs. IIRC the x86 can also correctl

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-13 Thread Ingo Molnar
* Neil Horman wrote: > On Wed, Nov 13, 2013 at 10:09:51AM -, David Laight wrote: > > > Sure, I modified the code so that we only prefetched 2 cache lines ahead, > > > but > > > only if the overall length of the input buffer is more than 2 cache lines. > > > Below are the results (all counts

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-13 Thread Neil Horman
On Wed, Nov 13, 2013 at 10:09:51AM -, David Laight wrote: > > Sure, I modified the code so that we only prefetched 2 cache lines ahead, > > but > > only if the overall length of the input buffer is more than 2 cache lines. > > Below are the results (all counts are the average of 100 iterat

RE: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-13 Thread David Laight
> Sure, I modified the code so that we only prefetched 2 cache lines ahead, but > only if the overall length of the input buffer is more than 2 cache lines. > Below are the results (all counts are the average of 100 iterations of the > csum operation, as previous tests were, I just omitted that

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-12 Thread Neil Horman
On Tue, Nov 12, 2013 at 12:38:01PM -0800, Joe Perches wrote: > On Tue, 2013-11-12 at 14:50 -0500, Neil Horman wrote: > > On Tue, Nov 12, 2013 at 09:33:35AM -0800, Joe Perches wrote: > > > On Tue, 2013-11-12 at 12:12 -0500, Neil Horman wrote: > [] > > > > So, the numbers are correct now that I retur

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-12 Thread Joe Perches
On Tue, 2013-11-12 at 14:50 -0500, Neil Horman wrote: > On Tue, Nov 12, 2013 at 09:33:35AM -0800, Joe Perches wrote: > > On Tue, 2013-11-12 at 12:12 -0500, Neil Horman wrote: [] > > > So, the numbers are correct now that I returned my hardware to its > > > previous > > > interrupt affinity state,

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-12 Thread Neil Horman
On Tue, Nov 12, 2013 at 09:33:35AM -0800, Joe Perches wrote: > On Tue, 2013-11-12 at 12:12 -0500, Neil Horman wrote: > > On Mon, Nov 11, 2013 at 05:42:22PM -0800, Joe Perches wrote: > > > Hi again Neil. > > > > > > Forwarding on to netdev with a concern as to how often > > > do_csum is used via cs

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-12 Thread Joe Perches
On Tue, 2013-11-12 at 12:12 -0500, Neil Horman wrote: > On Mon, Nov 11, 2013 at 05:42:22PM -0800, Joe Perches wrote: > > Hi again Neil. > > > > Forwarding on to netdev with a concern as to how often > > do_csum is used via csum_partial for very short headers > > and what impact any prefetch would

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-12 Thread Neil Horman
On Mon, Nov 11, 2013 at 05:42:22PM -0800, Joe Perches wrote: > Hi again Neil. > > Forwarding on to netdev with a concern as to how often > do_csum is used via csum_partial for very short headers > and what impact any prefetch would have there. > > Also, what changed in your test environment? > >

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-12 Thread Neil Horman
On Mon, Nov 11, 2013 at 05:42:22PM -0800, Joe Perches wrote: > Hi again Neil. > > Forwarding on to netdev with a concern as to how often > do_csum is used via csum_partial for very short headers > and what impact any prefetch would have there. > > Also, what changed in your test environment? > >