RE: [LINUX PATCH v9 4/4] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

2018-06-08 Thread Naga Sureshkumar Relli
gmail.com; f.faine...@gmail.com; > mma...@broadcom.com; rog...@ti.com; la...@linux-mips.org; a...@thorsis.com; > honghui.zh...@mediatek.com; linux-...@lists.infradead.org; > linux-kernel@vger.kernel.org; > nagasureshkumarre...@gmail.com > Subject: Re: [LINUX PATCH v9 4/4] mtd: raw

Re: [LINUX PATCH v9 4/4] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

2018-06-08 Thread Miquel Raynal
Hi Naga, > > > + ecc->read_page = pl353_nand_read_page_hwecc; > > > + ecc->size = PL353_NAND_ECC_SIZE; > > > + ecc->write_page = pl353_nand_write_page_hwecc; > > > + pl353_smc_set_ecc_pg_size(mtd->writesize); > > > + switch (mtd->writesize) { > > > +

RE: [LINUX PATCH v9 4/4] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

2018-06-08 Thread Naga Sureshkumar Relli
gmail.com; f.faine...@gmail.com; > mma...@broadcom.com; rog...@ti.com; la...@linux-mips.org; a...@thorsis.com; > honghui.zh...@mediatek.com; linux-...@lists.infradead.org; > linux-kernel@vger.kernel.org; > nagasureshkumarre...@gmail.com > Subject: Re: [LINUX PATCH v9 4/4] mtd: raw

Re: [LINUX PATCH v9 4/4] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

2018-06-07 Thread Miquel Raynal
Hi Naga, This is a partial review, enough for this version, see below. On Wed, 6 Jun 2018 13:19:42 +0530, Naga Sureshkumar Relli wrote: > Add driver for arm pl353 static memory controller nand interface with s/nand/NAND/ > HW ECC support. This controller is used in xilinx zynq soc for interfa