Re: [PATCH][next] ACPICA: Use fallthrough pseudo-keyword

2020-10-14 Thread Joe Perches
On Wed, 2020-10-14 at 20:48 +, Moore, Robert wrote: > I'm afraid that the macro does not compile under MSVC: > > warning C4067: unexpected tokens following preprocessor directive - expected > a newline (compiling source file ..\..\source\tools\acpiexec\aetests.c) > > It looks like "__has_at

RE: [PATCH][next] ACPICA: Use fallthrough pseudo-keyword

2020-10-14 Thread Moore, Robert
t Subject: Re: [PATCH][next] ACPICA: Use fallthrough pseudo-keyword On Mon, 2020-07-27 at 17:23 -0500, Gustavo A. R. Silva wrote: > Hi, > > > This is a macro pseudo-keyword, which expands to /* fallthrough */ for > compilers that don't support the attribute __fallthrough_

RE: [PATCH][next] ACPICA: Use fallthrough pseudo-keyword

2020-07-28 Thread Moore, Robert
; Wysocki, Rafael J ; Len Brown ; ACPI Devel Maling List ; open list:ACPI COMPONENT ARCHITECTURE (ACPICA) ; Linux Kernel Mailing List Subject: Re: [PATCH][next] ACPICA: Use fallthrough pseudo-keyword On Mon, 2020-07-27 at 17:23 -0500, Gustavo A. R. Silva wrote: > Hi, > > > Thi

Re: [PATCH][next] ACPICA: Use fallthrough pseudo-keyword

2020-07-27 Thread Joe Perches
On Mon, 2020-07-27 at 17:23 -0500, Gustavo A. R. Silva wrote: > Hi, > > > This is a macro pseudo-keyword, which expands to /* fallthrough */ > for compilers that don't support the attribute __fallthrough__. See: Not really. It expands to do {} while (0) for compilers that do not support

Re: [PATCH][next] ACPICA: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
va > Cc: Moore, Robert ; Kaneda, Erik > ; Wysocki, Rafael J ; Len > Brown ; ACPI Devel Maling List ; > open list:ACPI COMPONENT ARCHITECTURE (ACPICA) ; Linux > Kernel Mailing List > Subject: Re: [PATCH][next] ACPICA: Use fallthrough pseudo-keyword > > On Tue, Jul 7, 202

RE: [PATCH][next] ACPICA: Use fallthrough pseudo-keyword

2020-07-08 Thread Moore, Robert
AM To: Gustavo A. R. Silva Cc: Moore, Robert ; Kaneda, Erik ; Wysocki, Rafael J ; Len Brown ; ACPI Devel Maling List ; open list:ACPI COMPONENT ARCHITECTURE (ACPICA) ; Linux Kernel Mailing List Subject: Re: [PATCH][next] ACPICA: Use fallthrough pseudo-keyword On Tue, Jul 7, 2020 at 10:01 PM

Re: [PATCH][next] ACPICA: Use fallthrough pseudo-keyword

2020-07-08 Thread Rafael J. Wysocki
On Tue, Jul 7, 2020 at 10:01 PM Gustavo A. R. Silva wrote: > > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/html/late