Re: [PATCH][next] KVM: x86: Fix bit shifting in update_intel_pt_cfg

2019-01-11 Thread Radim Krčmář
2018-12-26 14:40-0600, Gustavo A. R. Silva: > ctl_bitmask in pt_desc is of type u64. When an integer like 0xf is > being left shifted more than 32 bits, the behavior is undefined. > > Fix this by adding suffix ULL to integer 0xf. > > Addresses-Coverity-ID: 1476095 ("Bad bit shift operation") >

RE: [PATCH][next] KVM: x86: Fix bit shifting in update_intel_pt_cfg

2018-12-27 Thread Kang, Luwei
> -Original Message- > From: Gustavo A. R. Silva [mailto:gust...@embeddedor.com] > Sent: Thursday, December 27, 2018 4:41 AM > To: Kang, Luwei ; Paolo Bonzini ; > Radim Krčmář ; Thomas Gleixner > ; Ingo Molnar ; Borislav Petkov > ; H. Peter Anvin ; > x...@kernel.org > Cc:

Re: [PATCH][next] KVM: x86: Fix bit shifting in update_intel_pt_cfg

2018-12-26 Thread Wei Yang
On Wed, Dec 26, 2018 at 02:40:59PM -0600, Gustavo A. R. Silva wrote: >ctl_bitmask in pt_desc is of type u64. When an integer like 0xf is >being left shifted more than 32 bits, the behavior is undefined. > >Fix this by adding suffix ULL to integer 0xf. > >Addresses-Coverity-ID: 1476095 ("Bad bit