RE: [PATCH] [PATCH V2] tty: memleak in alloc_pid

2014-04-14 Thread Chen, Tingjie
> > Change-Id: Ic960dda039c8f99aad3e0f4d176489a966c62f6a > > > > Why is this line here? > Tingjie, Greg is asking you the sentence of "Change-Id", which is not needed, > please remove it with one new patch. Sorry for mistaken, I will make a new patch for it. -- To unsubscribe from this list:

RE: [PATCH] [PATCH V2] tty: memleak in alloc_pid

2014-04-14 Thread Liu, Chuansheng
> > Change-Id: Ic960dda039c8f99aad3e0f4d176489a966c62f6a > > Why is this line here? Tingjie, Greg is asking you the sentence of "Change-Id", which is not needed, please remove it with one new patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

RE: [PATCH] [PATCH V2] tty: memleak in alloc_pid

2014-04-14 Thread Chen, Tingjie
erations should be atomic, which protected by spinlock: current->sighand->siglock. So the sentence: spin_unlock_irq(>sighand->siglock); need to move down after tty has process completed. Thanks, -Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] S

Re: [PATCH] [PATCH V2] tty: memleak in alloc_pid

2014-04-14 Thread Greg Kroah-Hartman
On Mon, Apr 14, 2014 at 03:31:15PM +0800, Chen Tingjie wrote: > There is memleak in alloc_pid: > -- > unreferenced object 0xd3453a80 (size 64): > comm "adbd", pid 1730, jiffies 66363 (age 6586.950s) > hex dump (first 32 bytes): > 01 00 00 00 00 00 00 00 00 00 00

RE: [PATCH] [PATCH V2] tty: memleak in alloc_pid

2014-04-14 Thread Chen, Tingjie
down after tty has process completed. Thanks, -Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] Sent: Monday, April 14, 2014 7:47 PM To: Chen, Tingjie Cc: Jiri Slaby; linux-kernel@vger.kernel.org; Zhang, Jun Subject: Re: [PATCH] [PATCH V2] tty: memleak

RE: [PATCH] [PATCH V2] tty: memleak in alloc_pid

2014-04-14 Thread Liu, Chuansheng
Change-Id: Ic960dda039c8f99aad3e0f4d176489a966c62f6a Why is this line here? Tingjie, Greg is asking you the sentence of Change-Id, which is not needed, please remove it with one new patch. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

RE: [PATCH] [PATCH V2] tty: memleak in alloc_pid

2014-04-14 Thread Chen, Tingjie
Change-Id: Ic960dda039c8f99aad3e0f4d176489a966c62f6a Why is this line here? Tingjie, Greg is asking you the sentence of Change-Id, which is not needed, please remove it with one new patch. Sorry for mistaken, I will make a new patch for it. -- To unsubscribe from this list: send the

Re: [PATCH] [PATCH V2] tty: memleak in alloc_pid

2014-04-14 Thread Greg Kroah-Hartman
On Mon, Apr 14, 2014 at 03:31:15PM +0800, Chen Tingjie wrote: There is memleak in alloc_pid: -- unreferenced object 0xd3453a80 (size 64): comm adbd, pid 1730, jiffies 66363 (age 6586.950s) hex dump (first 32 bytes): 01 00 00 00 00 00 00 00 00 00 00 00 00