> Having the firmware files under plfxlc/ directory looks good to me. But I'm
> not really a fan of upper case filenames, is there a reason for that? I would
> prefer have all lowercase filenames.
Thanks for your suggestions. We have renamed the firmware names to lower-case
and will submit
> That wasn't my point. My point was that the kernel code trusts the validity
> of the firmware image, in the sense of e.g. this piece:
>> + no_of_files = *(u32 *)_packed->data[0];
> If the firmware file was corrupted (intentionally/maliciously or not), this
> could now be say 0x.
On Fri, 2021-02-19 at 05:15 +, Srinivasan Raju wrote:
> Hi,
>
> Please find a few responses to the comments , We will fix rest of the
> comments and submit v14 of the patch.
>
> > Also, you *really* need some validation here, rather than blindly
> > trusting that the file is well-formed,
u really doing CCK/OFDM in some (strange?) way?
Yes, your understanding is correct, and we use OFDM.
For now we will use the existing band definition.
Thanks
Srini
____________________
From: Johannes Berg
Sent: Friday, February 12, 2021 7:14 PM
To: Srinivasan Raju
Cc: Mostafa
Srinivasan Raju writes:
> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
> and LiFi-XL USB devices.
>
> This driver implementation has been based on the zd1211rw driver.
>
> Driver is based on 802.11 softMAC Architecture and uses
> native 802.11 for configuration and management.
>
> Ah, kbuild bot had already reported few issues:
> https://patchwork.kernel.org/project/linux-wireless/patch/20210212115030.124490-1-srini.r...@purelifi.com/
> Please fix those and I recommend waiting few days in case the bot finds
> more issues. After that you can submitt v14 fixing the
Kalle Valo writes:
> Srinivasan Raju writes:
>
>> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
>> and LiFi-XL USB devices.
>>
>> This driver implementation has been based on the zd1211rw driver.
>>
>> Driver is based on 802.11 softMAC Architecture and uses
>> native 802.11 for
Srinivasan Raju writes:
> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
> and LiFi-XL USB devices.
>
> This driver implementation has been based on the zd1211rw driver.
>
> Driver is based on 802.11 softMAC Architecture and uses
> native 802.11 for configuration and management.
>
Johannes Berg writes:
>> +++ b/drivers/net/wireless/purelifi/Makefile
>> @@ -0,0 +1,2 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +obj-$(CONFIG_WLAN_VENDOR_PURELIFI) := plfxlc/
>
> Although this one doesn't do anything, so all you did was save a level
> of Kconfig inclusion I
Srinivasan Raju writes:
> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
> and LiFi-XL USB devices.
>
> This driver implementation has been based on the zd1211rw driver.
>
> Driver is based on 802.11 softMAC Architecture and uses
> native 802.11 for configuration and management.
>
Hi Srinivasan,
I love your patch! Yet something to improve:
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on wireless-drivers/master net-next/master net/master
linus/master sparc-next/master v5.11-rc7 next-20210211]
[If your patch is applied to the wrong git
Hi Srinivasan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master net-next/master net/master
linus/master sparc-next/master v5.11-rc7 next-20210211]
[If your patch is applied to the wrong
Hi,
Thanks for your patience, and thanks for sticking around!
I'm sorry I haven't reviewed this again in a long time, but I was able
to today.
> +PUREILIFI USB DRIVER
Did you mistype "PURELIFI" here, or was that intentional?
> +PUREILIFI USB DRIVER
> +M: Srinivasan Raju
Probably would be
13 matches
Mail list logo
