RE: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-10-09 Thread Chen, Yu C
er...@gmail.com; ying...@kernel.org; Ingo Molnar > Subject: Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by > inconsistent e820 map > > Hi! > > > > > 3) I'm not sure I understand the changelog correctly. What > > > > > happens when BIOS r

RE: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-10-09 Thread Chen, Yu C
er...@gmail.com; ying...@kernel.org; Ingo Molnar > Subject: Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by > inconsistent e820 map > > Hi! > > > > > 3) I'm not sure I understand the changelog correctly. What > > > > > happens when BIOS r

Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-10-04 Thread Pavel Machek
Hi! > > > > 3) I'm not sure I understand the changelog correctly. What happens > > > > when BIOS reports less memory on hibernation? Will you magically > > > > remove memory from kernel at runtime? Will /proc/meminfo be invalid > > after resume? > > > > Will all the memory management tuning need

Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-10-04 Thread Pavel Machek
Hi! > > > > 3) I'm not sure I understand the changelog correctly. What happens > > > > when BIOS reports less memory on hibernation? Will you magically > > > > remove memory from kernel at runtime? Will /proc/meminfo be invalid > > after resume? > > > > Will all the memory management tuning need

RE: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-18 Thread Chen, Yu C
eyli.ker...@gmail.com; ying...@kernel.org; Ingo Molnar > Subject: Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by > inconsistent e820 map > > > > 3) I'm not sure I understand the changelog correctly. What happens > > > when BIOS reports less memory on hib

RE: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-18 Thread Chen, Yu C
eyli.ker...@gmail.com; ying...@kernel.org; Ingo Molnar > Subject: Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by > inconsistent e820 map > > > > 3) I'm not sure I understand the changelog correctly. What happens > > > when BIOS reports less memory on hib

Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-17 Thread Pavel Machek
Hi! > > But I still don't like the patch. > > > > 0) BIOS is broken, and this does not completely work around it. Users will > > still > > see the failed hibernation when the memory that is now unavailable was > > actually used. > > > Unfortunately , yes :( the patch is trying to replace the

RE: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-17 Thread Chen, Yu C
.org; linux- > ker...@vger.kernel.org; Zhang, Rui; j...@suse.com; > joeyli.ker...@gmail.com; ying...@kernel.org; Ingo Molnar > Subject: Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by > inconsistent e820 map > > Yes, that's better. > > But I still don't like the pa

Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-17 Thread Pavel Machek
Hi! > > > This is also because BIOS provides different e820 memory map > > > before/after hibernation, and linux regards it as invalid process > > > and refuses to resume, in order to protect against data corruption. > > > However, this check might be too strict, consider the following

RE: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-17 Thread Chen, Yu C
eyli.ker...@gmail.com; ying...@kernel.org > Subject: Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by > inconsistent e820 map > > >With v3 patch applied, I did 30 cycles on my problematic platform, > >no panic triggered anymore(50% reproducible before pat

RE: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-17 Thread Chen, Yu C
own, Len; linux...@vger.kernel.org; linux- > ker...@vger.kernel.org; Zhang, Rui; j...@suse.com; > joeyli.ker...@gmail.com; ying...@kernel.org > Subject: Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by > inconsistent e820 map > > > This is also because BIO

Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-17 Thread Pavel Machek
> v3: > - Adjust the logic to exclude the end_pfn boundary in pfn_mapped >when invoking mark_valid_pages, because the end_pfn is not >a mapped page frame, we should not regard it as a valid page. > >Move the sanity check of valid pages to a early stage in resuming >process(moved

Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-17 Thread Pavel Machek
> v3: > - Adjust the logic to exclude the end_pfn boundary in pfn_mapped >when invoking mark_valid_pages, because the end_pfn is not >a mapped page frame, we should not regard it as a valid page. > >Move the sanity check of valid pages to a early stage in resuming >process(moved

RE: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-17 Thread Chen, Yu C
own, Len; linux...@vger.kernel.org; linux- > ker...@vger.kernel.org; Zhang, Rui; j...@suse.com; > joeyli.ker...@gmail.com; ying...@kernel.org > Subject: Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by > inconsistent e820 map > > > This is also because BIO

RE: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-17 Thread Chen, Yu C
eyli.ker...@gmail.com; ying...@kernel.org > Subject: Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by > inconsistent e820 map > > >With v3 patch applied, I did 30 cycles on my problematic platform, > >no panic triggered anymore(50% reproducible before pat

Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-17 Thread Pavel Machek
Hi! > > > This is also because BIOS provides different e820 memory map > > > before/after hibernation, and linux regards it as invalid process > > > and refuses to resume, in order to protect against data corruption. > > > However, this check might be too strict, consider the following

RE: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-17 Thread Chen, Yu C
.org; linux- > ker...@vger.kernel.org; Zhang, Rui; j...@suse.com; > joeyli.ker...@gmail.com; ying...@kernel.org; Ingo Molnar > Subject: Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by > inconsistent e820 map > > Yes, that's better. > > But I still don't like the pa

Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map

2015-09-17 Thread Pavel Machek
Hi! > > But I still don't like the patch. > > > > 0) BIOS is broken, and this does not completely work around it. Users will > > still > > see the failed hibernation when the memory that is now unavailable was > > actually used. > > > Unfortunately , yes :( the patch is trying to replace the