RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-27 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of > 'big-endian-data'. > > On Tue, Aug 26, 2014 at 11:53:56PM -0700, Nicolin Chen wrote: > > > That's why I suggested previously: mention it in the commit comment. > > > People will have

Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-27 Thread Mark Brown
On Tue, Aug 26, 2014 at 11:53:56PM -0700, Nicolin Chen wrote: > That's why I suggested previously: mention it in the commit comment. > People will have no idea about what's the exact reason for this change. > Any functional enhancement? Or a bug fix(more likely for this one). > I'm not sure what

RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-27 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of > 'big-endian-data'. > > On Tue, Aug 26, 2014 at 7:12 PM, li.xi...@freescale.com > wrote: > > > > This property used for configuring whether the LSB or the MSB is > transmitted &

Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-27 Thread Nicolin Chen
On Tue, Aug 26, 2014 at 7:12 PM, li.xi...@freescale.com wrote: > > > This property used for configuring whether the LSB or the MSB is > > > transmitted > > > first for the fifo data. > > > > I don't follow the rationale for this change. > > > > This looks like a pointless renaming. > > > > Why

Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-27 Thread Nicolin Chen
On Tue, Aug 26, 2014 at 7:12 PM, li.xi...@freescale.com li.xi...@freescale.com wrote: This property used for configuring whether the LSB or the MSB is transmitted first for the fifo data. I don't follow the rationale for this change. This looks like a pointless renaming. Why

RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-27 Thread li.xi...@freescale.com
Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'. On Tue, Aug 26, 2014 at 7:12 PM, li.xi...@freescale.com li.xi...@freescale.com wrote: This property used for configuring whether the LSB or the MSB is transmitted first for the fifo data

Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-27 Thread Mark Brown
On Tue, Aug 26, 2014 at 11:53:56PM -0700, Nicolin Chen wrote: That's why I suggested previously: mention it in the commit comment. People will have no idea about what's the exact reason for this change. Any functional enhancement? Or a bug fix(more likely for this one). I'm not sure what I

RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-27 Thread li.xi...@freescale.com
Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'. On Tue, Aug 26, 2014 at 11:53:56PM -0700, Nicolin Chen wrote: That's why I suggested previously: mention it in the commit comment. People will have no idea about what's the exact reason

RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-26 Thread li.xi...@freescale.com
lsa- > project.org; ga...@codeaurora.org; robh...@kernel.org; Pawel Moll; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of > 'big-endian-data'. > > On Mon, Aug 25, 2014 at 08:16:01AM +0100, Xiubo Li wrote: > >

Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-26 Thread Mark Rutland
On Mon, Aug 25, 2014 at 08:16:01AM +0100, Xiubo Li wrote: > This property used for configuring whether the LSB or the MSB is transmitted > first for the fifo data. I don't follow the rationale for this change. This looks like a pointless renaming. Why is this any better? Thanks, Mark. >

Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-26 Thread Mark Rutland
On Mon, Aug 25, 2014 at 08:16:01AM +0100, Xiubo Li wrote: This property used for configuring whether the LSB or the MSB is transmitted first for the fifo data. I don't follow the rationale for this change. This looks like a pointless renaming. Why is this any better? Thanks, Mark.

RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-26 Thread li.xi...@freescale.com
...@codeaurora.org; robh...@kernel.org; Pawel Moll; linux- ker...@vger.kernel.org Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'. On Mon, Aug 25, 2014 at 08:16:01AM +0100, Xiubo Li wrote: This property used for configuring whether the LSB or the MSB