Re: [PATCH] EXTCON: Get and set cable properties

2013-01-05 Thread Anton Vorontsov
On Mon, Dec 03, 2012 at 02:09:02AM +, Tc, Jenny wrote: > > > Could you please review this. This is a follow up patch for "PATCH] > > > extcon : callback function to read cable property" > > > > While I see nothing wrong with the patch itself, I beg you to send some > > users > > for the new c

Re: [PATCH] EXTCON: Get and set cable properties

2012-12-16 Thread Chanwoo Choi
On 12/15/2012 09:16 AM, Tc, Jenny wrote: > >>> I replied on the thread and pointed out issues that I see with this >>> solution. IMHO It's not fair to register a cable with >>> power_supply/regulator/charger manager just to expose the cable >> properties. >> Don't we do that with already in allmos

RE: [PATCH] EXTCON: Get and set cable properties

2012-12-14 Thread Tc, Jenny
Anton, Could you please have a look at my comments below? -jtc > > While I see nothing wrong with the patch itself, I beg you to send > > some users for the new calls. Don't be obsessed with the extcon > > internals too much, think more about how things will interact (i.e. I > > really really wa

RE: [PATCH] EXTCON: Get and set cable properties

2012-12-14 Thread Tc, Jenny
> > I replied on the thread and pointed out issues that I see with this > > solution. IMHO It's not fair to register a cable with > > power_supply/regulator/charger manager just to expose the cable > properties. > Don't we do that with already in allmost all drivers?Like if I have a keyboard > dri

RE: [PATCH] EXTCON: Get and set cable properties

2012-12-02 Thread anish kumar
On Mon, 2012-12-03 at 01:53 +, Tc, Jenny wrote: > > We discussed about this patch and then suggest some method to resolve this > > issue by Myungjoo Ham. Why don't you write additional feature or your > > opinion based on following patch by Myungjoo Ham? > > - > > http://git.kernel.org/?p=linux

RE: [PATCH] EXTCON: Get and set cable properties

2012-12-02 Thread Tc, Jenny
> > Could you please review this. This is a follow up patch for "PATCH] > > extcon : callback function to read cable property" > > While I see nothing wrong with the patch itself, I beg you to send some users > for the new calls. Don't be obsessed with the extcon internals too much, > think more a

RE: [PATCH] EXTCON: Get and set cable properties

2012-12-02 Thread Tc, Jenny
> We discussed about this patch and then suggest some method to resolve this > issue by Myungjoo Ham. Why don't you write additional feature or your > opinion based on following patch by Myungjoo Ham? > - > http://git.kernel.org/?p=linux/kernel/git/mzx/extcon.git;a=commitdiff;h=73 > 12b79d69a2b9f06

Re: [PATCH] EXTCON: Get and set cable properties

2012-12-02 Thread Anton Vorontsov
On Sun, Dec 02, 2012 at 06:53:17AM +, Tc, Jenny wrote: > Could you please review this. This is a follow up patch for "PATCH] > extcon : callback function to read cable property" While I see nothing wrong with the patch itself, I beg you to send some users for the new calls. Don't be obsessed w

Re: [PATCH] EXTCON: Get and set cable properties

2012-12-02 Thread Chanwoo Choi
We discussed about this patch and then suggest some method to resolve this issue by Myungjoo Ham. Why don't you write additional feature or your opinion based on following patch by Myungjoo Ham? - http://git.kernel.org/?p=linux/kernel/git/mzx/extcon.git;a=commitdiff;h=7312b79d69a2b9f06af4f1254bc464

RE: [PATCH] EXTCON: Get and set cable properties

2012-12-01 Thread Tc, Jenny
Hi Myungjoo/Chanwoo/Aneesh/Anton, Could you please review this. This is a follow up patch for "PATCH] extcon : callback function to read cable property" -jtc > Subject: [PATCH] EXTCON: Get and set cable properties > > Existing EXTCON implementation doesn't give a mechanim to read the cable >