RE: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-10-05 Thread Alexandra Chin
Hi Dmitry/Henrik, From: Dmitry Torokhov Sent: Thursday, October 04, 2012 2:52 PM > Given that the other group at Synaptics works on general version of RMI4 > driver what is the benefit of having separate driver for DS4 line? I can > understand keeping one copy of older driver in staging so that

RE: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-10-05 Thread Alexandra Chin
Hi Dmitry/Henrik, From: Dmitry Torokhov Sent: Thursday, October 04, 2012 2:52 PM Given that the other group at Synaptics works on general version of RMI4 driver what is the benefit of having separate driver for DS4 line? I can understand keeping one copy of older driver in staging so that

Re: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-10-04 Thread Dmitry Torokhov
Hi Alexandra, On Thu, Oct 04, 2012 at 05:52:45AM +, Alexandra Chin wrote: > From: Henrik Rydberg > Sent: Thursday, October 04, 2012 2:01 AM > > It seems this driver is already present in staging. Comments and > > formatting have been improved in the staging version, but that aside, > > the

Re: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-10-04 Thread Dmitry Torokhov
Hi Alexandra, On Thu, Oct 04, 2012 at 05:52:45AM +, Alexandra Chin wrote: From: Henrik Rydberg Sent: Thursday, October 04, 2012 2:01 AM It seems this driver is already present in staging. Comments and formatting have been improved in the staging version, but that aside, the two

RE: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-10-03 Thread Alexandra Chin
From: Henrik Rydberg Sent: Thursday, October 04, 2012 2:01 AM > It seems this driver is already present in staging. Comments and > formatting have been improved in the staging version, but that aside, > the two versions look very similar. Why don't you submit fixes to > that driver instead? > On

Re: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-10-03 Thread Henrik Rydberg
Hi Alexandra, > Hi Henrik/Dmitry, > > We are working on a product specific driver for Synaptics DS4 I2C touchscreen > devices. It was submitted on Sept. 16, 2012, but has not been reviewed. > (http://lkml.org/lkml/2012/9/16/24). > We found several warnings after running script/checkpatch.pl,

Re: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-10-03 Thread Henrik Rydberg
Hi Alexandra, Hi Henrik/Dmitry, We are working on a product specific driver for Synaptics DS4 I2C touchscreen devices. It was submitted on Sept. 16, 2012, but has not been reviewed. (http://lkml.org/lkml/2012/9/16/24). We found several warnings after running script/checkpatch.pl,

RE: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-10-03 Thread Alexandra Chin
From: Henrik Rydberg Sent: Thursday, October 04, 2012 2:01 AM It seems this driver is already present in staging. Comments and formatting have been improved in the staging version, but that aside, the two versions look very similar. Why don't you submit fixes to that driver instead? On a

RE: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-10-02 Thread Alexandra Chin
Add Chris in mail loop. Best Regards, Alexandra Chin  Synaptics Hong Kong Limited, Taiwan Branch  5F., No. 501, Sec. 2 Tiding Blvd., Neihu District,  Taipei City 114, Taiwan Office: 886.2.8752.5700  ext:652 Email:alexandra.c...@synaptics.com.tw -Original Message- From: Alexandra Chin

RE: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-10-02 Thread Alexandra Chin
Add Chris in mail loop. Best Regards, Alexandra Chin  Synaptics Hong Kong Limited, Taiwan Branch  5F., No. 501, Sec. 2 Tiding Blvd., Neihu District,  Taipei City 114, Taiwan Office: 886.2.8752.5700  ext:652 Email:alexandra.c...@synaptics.com.tw -Original Message- From: Alexandra Chin

Re: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-09-19 Thread Christopher Heiny
On 09/16/2012 03:33 PM, Linus Walleij wrote: On Sun, Sep 16, 2012 at 11:56 AM, Alexandra Chin wrote: Synaptics DS4 touchscreen driver implements a generic driver supporting I2C protocol for Synaptics Design Studio 4 (DS4) family of Touchscreen Controllers which include the following: - S32xX

Re: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-09-19 Thread Christopher Heiny
On 09/16/2012 03:33 PM, Linus Walleij wrote: On Sun, Sep 16, 2012 at 11:56 AM, Alexandra Chin alexandra.c...@tw.synaptics.com wrote: Synaptics DS4 touchscreen driver implements a generic driver supporting I2C protocol for Synaptics Design Studio 4 (DS4) family of Touchscreen Controllers which

Re: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-09-16 Thread Linus Walleij
On Sun, Sep 16, 2012 at 11:56 AM, Alexandra Chin wrote: > Synaptics DS4 touchscreen driver implements a generic driver supporting I2C > protocol for Synaptics Design Studio 4 (DS4) family of Touchscreen Controllers > which include the following: > > - S32xX series > - S730X series > - S22xx

Re: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

2012-09-16 Thread Linus Walleij
On Sun, Sep 16, 2012 at 11:56 AM, Alexandra Chin alexandra.c...@tw.synaptics.com wrote: Synaptics DS4 touchscreen driver implements a generic driver supporting I2C protocol for Synaptics Design Studio 4 (DS4) family of Touchscreen Controllers which include the following: - S32xX series -