Hi,
> > > +static int
> > > +write_packet(volatile u32 * uddr, struct pxa27x_request *req, unsigned
> > > max)
> >
> > Please review Documentation/volatile-considered-harmful.txt
>
> The attibute volatile here is necessary in order to avoid getting the
> following warnings from the compiler:
>
On Thu, Jun 28, 2007 at 02:29:49PM -0700, Andrew Morton wrote:
> >
> > +
> > +static int
> > +write_packet(volatile u32 * uddr, struct pxa27x_request *req, unsigned max)
>
> Please review Documentation/volatile-considered-harmful.txt
The attibute volatile here is necessary in order to avoid
On Thu, Jun 28, 2007 at 02:29:49PM -0700, Andrew Morton wrote:
+
+static int
+write_packet(volatile u32 * uddr, struct pxa27x_request *req, unsigned max)
Please review Documentation/volatile-considered-harmful.txt
The attibute volatile here is necessary in order to avoid getting the
Hi,
+static int
+write_packet(volatile u32 * uddr, struct pxa27x_request *req, unsigned
max)
Please review Documentation/volatile-considered-harmful.txt
The attibute volatile here is necessary in order to avoid getting the
following warnings from the compiler:
[...]
Do you
On Sunday 01 July 2007, Russell King - ARM Linux wrote:
> >
> > +#ifdef CONFIG_USB_GADGET_PXA27X
> > +#define DEV_CONFIG_SUBSET
> > +#endif
> > +
>
> Bad - can we not make this runtime dependent?
The #define controls which descriptors are statically linked
into every object. I suppose someone
On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote:
> attached you can find new version of my patch for PXA27x UDC driver
> support against kernel 2.6.22-rc3 (but it applies also ro rc6).
>
> I'd like to know what I have to do in order to prepare this patch for
> kernel inclusion.
On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote:
> attached you can find new version of my patch for PXA27x UDC driver
> support against kernel 2.6.22-rc3 (but it applies also ro rc6).
>
> I'd like to know what I have to do in order to prepare this patch for
> kernel inclusion.
On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote:
attached you can find new version of my patch for PXA27x UDC driver
support against kernel 2.6.22-rc3 (but it applies also ro rc6).
I'd like to know what I have to do in order to prepare this patch for
kernel inclusion. It's
On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote:
attached you can find new version of my patch for PXA27x UDC driver
support against kernel 2.6.22-rc3 (but it applies also ro rc6).
I'd like to know what I have to do in order to prepare this patch for
kernel inclusion. It's
On Sunday 01 July 2007, Russell King - ARM Linux wrote:
+#ifdef CONFIG_USB_GADGET_PXA27X
+#define DEV_CONFIG_SUBSET
+#endif
+
Bad - can we not make this runtime dependent?
The #define controls which descriptors are statically linked
into every object. I suppose someone could
On Friday 29 June 2007, Rodolfo Giometti wrote:
> On Thu, Jun 28, 2007 at 02:53:22PM -0700, David Brownell wrote:
> >
> > Let's start with *JUST* a driver, not trying to update everything
> > else in the USB Gadget stack so that it looks like it's designed
> > specifically to handle all of
On Friday 29 June 2007, Rodolfo Giometti wrote:
On Thu, Jun 28, 2007 at 02:53:22PM -0700, David Brownell wrote:
Let's start with *JUST* a driver, not trying to update everything
else in the USB Gadget stack so that it looks like it's designed
specifically to handle all of Intel's design
Thanks for taking the lead on this! I can't wait to have a sane PXA27x
gadget driver in mainline.
On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote:
> +config USB_GADGET_PXA27X
> + boolean "PXA 27x"
> + depends on ARCH_PXA && PXA27x
> + help
> +Intel's PXA 27x
On Thu, Jun 28, 2007 at 02:53:22PM -0700, David Brownell wrote:
>
> Let's start with *JUST* a driver, not trying to update everything
> else in the USB Gadget stack so that it looks like it's designed
> specifically to handle all of Intel's design botches related to
> endpoint config ... and work
On Thu, Jun 28, 2007 at 02:53:22PM -0700, David Brownell wrote:
Let's start with *JUST* a driver, not trying to update everything
else in the USB Gadget stack so that it looks like it's designed
specifically to handle all of Intel's design botches related to
endpoint config ... and work
Thanks for taking the lead on this! I can't wait to have a sane PXA27x
gadget driver in mainline.
On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote:
+config USB_GADGET_PXA27X
+ boolean PXA 27x
+ depends on ARCH_PXA PXA27x
+ help
+Intel's PXA 27x series
By the way, there are three or four versions of a pxa27x UDC
driver floating around; which one is this? One you updated?
It looks like it forked from the pxa2xx driver several years ago
but never got cleaned up ... e.g. it's a different controller,
so none of the comments relevant to earlier
On Thursday 28 June 2007, Rodolfo Giometti wrote:
> As suggest by Leo let me propose to you my new patch for PXA27x UDC
> support.
>
> Please, let me know what I have to do for kernel inclusion. :)
Let's start with *JUST* a driver, not trying to update everything
else in the USB Gadget stack so
On Thu, 28 Jun 2007 16:12:07 +0200
Rodolfo Giometti <[EMAIL PROTECTED]> wrote:
> On Thu, Jun 28, 2007 at 07:15:06PM +0800, Li Yang-r58472 wrote:
>
> > You should probably also cc: [EMAIL PROTECTED] and
> > David Brownell for UDC matters.
>
> As suggest by Leo let me propose to you my new patch
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of Rodolfo
Giometti
> Sent: Thursday, June 28, 2007 6:36 PM
> To: [EMAIL PROTECTED]
> Cc: linux-kernel@vger.kernel.org; Andrew Morton
> Subject: [PATCH] PXA27x UDC driver.
>
> Hello,
>
> attached you can
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Rodolfo
Giometti
Sent: Thursday, June 28, 2007 6:36 PM
To: [EMAIL PROTECTED]
Cc: linux-kernel@vger.kernel.org; Andrew Morton
Subject: [PATCH] PXA27x UDC driver.
Hello,
attached you can find new
On Thu, 28 Jun 2007 16:12:07 +0200
Rodolfo Giometti [EMAIL PROTECTED] wrote:
On Thu, Jun 28, 2007 at 07:15:06PM +0800, Li Yang-r58472 wrote:
You should probably also cc: [EMAIL PROTECTED] and
David Brownell for UDC matters.
As suggest by Leo let me propose to you my new patch for PXA27x
On Thursday 28 June 2007, Rodolfo Giometti wrote:
As suggest by Leo let me propose to you my new patch for PXA27x UDC
support.
Please, let me know what I have to do for kernel inclusion. :)
Let's start with *JUST* a driver, not trying to update everything
else in the USB Gadget stack so
By the way, there are three or four versions of a pxa27x UDC
driver floating around; which one is this? One you updated?
It looks like it forked from the pxa2xx driver several years ago
but never got cleaned up ... e.g. it's a different controller,
so none of the comments relevant to earlier
24 matches
Mail list logo
