RE: [PATCH] SPI: spi-pxa2xx: SPI support for Intel Quark X1000

2014-09-27 Thread Chen, Alvin
> > > > > > +/* see Quark SPI data sheet for implementation rationale */ static > > > +u32 quark_x1000_set_clk_regvals(u32 rate, u32 *dds, u32 *clk_div) { > > > > Please document this in the driver - I don't know if this datasheet is > > public but even if it is it may not stay that way. > >

RE: [PATCH] SPI: spi-pxa2xx: SPI support for Intel Quark X1000

2014-09-27 Thread Chen, Alvin
> > > +static u32 pxa2xx_spi_get_ssrc1_change_mask(const struct driver_data > > +*drv_data) { > > + if (!is_quark_x1000_ssp(drv_data)) > > + return SSCR1_CHANGE_MASK; > > + > > + return QUARK_X1000_SSCR1_CHANGE_MASK; } > > These functions would be much better written as switch

RE: [PATCH] SPI: spi-pxa2xx: SPI support for Intel Quark X1000

2014-09-27 Thread Chen, Alvin
+static u32 pxa2xx_spi_get_ssrc1_change_mask(const struct driver_data +*drv_data) { + if (!is_quark_x1000_ssp(drv_data)) + return SSCR1_CHANGE_MASK; + + return QUARK_X1000_SSCR1_CHANGE_MASK; } These functions would be much better written as switch statements - think

RE: [PATCH] SPI: spi-pxa2xx: SPI support for Intel Quark X1000

2014-09-27 Thread Chen, Alvin
+/* see Quark SPI data sheet for implementation rationale */ static +u32 quark_x1000_set_clk_regvals(u32 rate, u32 *dds, u32 *clk_div) { Please document this in the driver - I don't know if this datasheet is public but even if it is it may not stay that way. Datasheet is

Re: [PATCH] SPI: spi-pxa2xx: SPI support for Intel Quark X1000

2014-09-26 Thread Andy Shevchenko
On Fri, 2014-09-26 at 11:08 +0100, Mark Brown wrote: > On Fri, Sep 26, 2014 at 10:25:49AM -0700, Weike Chen wrote: [] > It might also be helpful for review to have two > patches, one splitting things out into the functions and another adding > the Quark support. I also suggest to go this way.

Re: [PATCH] SPI: spi-pxa2xx: SPI support for Intel Quark X1000

2014-09-26 Thread Mark Brown
On Fri, Sep 26, 2014 at 10:25:49AM -0700, Weike Chen wrote: > +static u32 pxa2xx_spi_get_ssrc1_change_mask(const struct driver_data > *drv_data) > +{ > + if (!is_quark_x1000_ssp(drv_data)) > + return SSCR1_CHANGE_MASK; > + > + return QUARK_X1000_SSCR1_CHANGE_MASK; > +} These

Re: [PATCH] SPI: spi-pxa2xx: SPI support for Intel Quark X1000

2014-09-26 Thread Mark Brown
On Fri, Sep 26, 2014 at 10:25:49AM -0700, Weike Chen wrote: +static u32 pxa2xx_spi_get_ssrc1_change_mask(const struct driver_data *drv_data) +{ + if (!is_quark_x1000_ssp(drv_data)) + return SSCR1_CHANGE_MASK; + + return QUARK_X1000_SSCR1_CHANGE_MASK; +} These

Re: [PATCH] SPI: spi-pxa2xx: SPI support for Intel Quark X1000

2014-09-26 Thread Andy Shevchenko
On Fri, 2014-09-26 at 11:08 +0100, Mark Brown wrote: On Fri, Sep 26, 2014 at 10:25:49AM -0700, Weike Chen wrote: [] It might also be helpful for review to have two patches, one splitting things out into the functions and another adding the Quark support. I also suggest to go this way.