>-Original Message-
>From: Ingo Molnar [mailto:[EMAIL PROTECTED]
>Sent: Sunday, September 02, 2007 3:02 AM
>To: Andi Kleen
>Cc: Pallipadi, Venkatesh; Thomas Gleixner; Andrew Morton; linux-kernel
>Subject: Re: [PATCH] Track accurate idle time with
>tick_sched.idle_
-Original Message-
From: Ingo Molnar [mailto:[EMAIL PROTECTED]
Sent: Sunday, September 02, 2007 3:02 AM
To: Andi Kleen
Cc: Pallipadi, Venkatesh; Thomas Gleixner; Andrew Morton; linux-kernel
Subject: Re: [PATCH] Track accurate idle time with
tick_sched.idle_sleeptime
* Andi Kleen [EMAIL
* Andi Kleen <[EMAIL PROTECTED]> wrote:
> > at least the current out-of-idle code already does what amounts to a
> > PM-timer read when exiting from C2 or C3 mode. The
>
> C2/C3 are already slow. I more worry about C1.
C2/C3 are only slow in older CPUs - and they are getting faster and
> at least the current out-of-idle code already does what amounts to a
> PM-timer read when exiting from C2 or C3 mode. The
C2/C3 are already slow. I more worry about C1.
Also doing two instead of one can have an impact even on C2+, especially
when the operation can be thousands of cycles.
* Andi Kleen <[EMAIL PROTECTED]> wrote:
> Venki Pallipadi <[EMAIL PROTECTED]> writes:
> >
> > +void tick_nohz_stop_idle(int cpu)
> > +{
> > + struct tick_sched *ts = _cpu(tick_cpu_sched, cpu);
> > +
> > + if (ts->idle_active) {
> > + ktime_t now, delta;
> > + now =
* Andi Kleen [EMAIL PROTECTED] wrote:
Venki Pallipadi [EMAIL PROTECTED] writes:
+void tick_nohz_stop_idle(int cpu)
+{
+ struct tick_sched *ts = per_cpu(tick_cpu_sched, cpu);
+
+ if (ts-idle_active) {
+ ktime_t now, delta;
+ now = ktime_get();
That
at least the current out-of-idle code already does what amounts to a
PM-timer read when exiting from C2 or C3 mode. The
C2/C3 are already slow. I more worry about C1.
Also doing two instead of one can have an impact even on C2+, especially
when the operation can be thousands of cycles.
* Andi Kleen [EMAIL PROTECTED] wrote:
at least the current out-of-idle code already does what amounts to a
PM-timer read when exiting from C2 or C3 mode. The
C2/C3 are already slow. I more worry about C1.
C2/C3 are only slow in older CPUs - and they are getting faster and
faster.
Venki Pallipadi <[EMAIL PROTECTED]> writes:
>
> +void tick_nohz_stop_idle(int cpu)
> +{
> + struct tick_sched *ts = _cpu(tick_cpu_sched, cpu);
> +
> + if (ts->idle_active) {
> + ktime_t now, delta;
> + now = ktime_get();
That could be PM timer read costing
Venki Pallipadi [EMAIL PROTECTED] writes:
+void tick_nohz_stop_idle(int cpu)
+{
+ struct tick_sched *ts = per_cpu(tick_cpu_sched, cpu);
+
+ if (ts-idle_active) {
+ ktime_t now, delta;
+ now = ktime_get();
That could be PM timer read costing thousands of
>-Original Message-
>From: Ingo Molnar [mailto:[EMAIL PROTECTED]
>Sent: Friday, August 31, 2007 11:24 AM
>To: Pallipadi, Venkatesh
>Cc: Thomas Gleixner; Andrew Morton; linux-kernel
>Subject: Re: [PATCH] Track accurate idle time with
>tick_sched.idle_sleepti
* Ingo Molnar <[EMAIL PROTECTED]> wrote:
> nice stuff! I've added your patch to the scheduler queue - but this
> will probably be 2.6.24 material.
btw., this patch depends on the latest acpi tree, right?
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
* Venki Pallipadi <[EMAIL PROTECTED]> wrote:
> Current idle time in kstat is based on jiffies and is coarse grained.
> tick_sched.idle_sleeptime is making some attempt to keep track of idle
> time in a fine grained manner. But, it is not handling the time spent
> in interrupts fully.
>
>
* Venki Pallipadi [EMAIL PROTECTED] wrote:
Current idle time in kstat is based on jiffies and is coarse grained.
tick_sched.idle_sleeptime is making some attempt to keep track of idle
time in a fine grained manner. But, it is not handling the time spent
in interrupts fully.
Make
* Ingo Molnar [EMAIL PROTECTED] wrote:
nice stuff! I've added your patch to the scheduler queue - but this
will probably be 2.6.24 material.
btw., this patch depends on the latest acpi tree, right?
Ingo
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the
-Original Message-
From: Ingo Molnar [mailto:[EMAIL PROTECTED]
Sent: Friday, August 31, 2007 11:24 AM
To: Pallipadi, Venkatesh
Cc: Thomas Gleixner; Andrew Morton; linux-kernel
Subject: Re: [PATCH] Track accurate idle time with
tick_sched.idle_sleeptime
* Ingo Molnar [EMAIL PROTECTED
16 matches
Mail list logo
