RE: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-22 Thread Pallipadi, Venkatesh
>-Original Message- >From: Dave Jones [mailto:[EMAIL PROTECTED] >Sent: Friday, January 18, 2008 7:29 PM >To: Ingo Molnar >Cc: Yinghai Lu; Pallipadi, Venkatesh; LKML >Subject: Re: [PATCH] X86: fix typo PAT to X86_PAT > >On Fri, Jan 18, 2008 at 10:02:10PM

RE: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-22 Thread Pallipadi, Venkatesh
-Original Message- From: Dave Jones [mailto:[EMAIL PROTECTED] Sent: Friday, January 18, 2008 7:29 PM To: Ingo Molnar Cc: Yinghai Lu; Pallipadi, Venkatesh; LKML Subject: Re: [PATCH] X86: fix typo PAT to X86_PAT On Fri, Jan 18, 2008 at 10:02:10PM +0100, Ingo Molnar wrote: * Dave

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Yinghai Lu
On Friday 18 January 2008 07:28:49 pm Dave Jones wrote: > On Fri, Jan 18, 2008 at 10:02:10PM +0100, Ingo Molnar wrote: > > > > * Dave Jones <[EMAIL PROTECTED]> wrote: > > > > > > you mean modifies MTRRs? Which code is that? (besides the > > > > /proc/mtrr userspace API) > > > > > >

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Dave Jones
On Fri, Jan 18, 2008 at 10:02:10PM +0100, Ingo Molnar wrote: > > * Dave Jones <[EMAIL PROTECTED]> wrote: > > > > you mean modifies MTRRs? Which code is that? (besides the > > > /proc/mtrr userspace API) > > > > This exclusion is going to be a real pain in the ass for distro > >

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Ingo Molnar
* Pallipadi, Venkatesh <[EMAIL PROTECTED]> wrote: > Ingo, can you remove this PAT MTRR exclusion. yeah, already did that. > Actually, this exclusion will not work at all with the current code. > Infact it should be PAT selects MTRR, for the current code. As > pat_init() is called during mtrr

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Ingo Molnar
* Dave Jones <[EMAIL PROTECTED]> wrote: > > you mean modifies MTRRs? Which code is that? (besides the > > /proc/mtrr userspace API) > > This exclusion is going to be a real pain in the ass for distro > kernels. It's impossible for example to build a kernel that will now > support the

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Dave Jones
On Fri, Jan 18, 2008 at 10:47:05AM -0800, Venki Pallipadi wrote: > >This exclusion is going to be a real pain in the ass for > >distro kernels. > >It's impossible for example to build a kernel that will now support > >the MTRR-alike registers on the AMD K6/early Cyrix etc and also >

RE: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Pallipadi, Venkatesh
>-Original Message- >From: Dave Jones [mailto:[EMAIL PROTECTED] >Sent: Friday, January 18, 2008 10:25 AM >To: Ingo Molnar >Cc: Yinghai Lu; Pallipadi, Venkatesh; LKML >Subject: Re: [PATCH] X86: fix typo PAT to X86_PAT > >On Fri, Jan 18, 2008 at 01:31:40PM

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Dave Jones
On Fri, Jan 18, 2008 at 01:31:40PM +0100, Ingo Molnar wrote: > * Yinghai Lu <[EMAIL PROTECTED]> wrote: > > > > thanks. But, i think we should rather do the following: if X86_PAT > > > is eanbled then /proc/mtrr should be read-only. There's no problem > > > _looking_ at MTRR contents, as

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Ingo Molnar
* Yinghai Lu <[EMAIL PROTECTED]> wrote: > > thanks. But, i think we should rather do the following: if X86_PAT > > is eanbled then /proc/mtrr should be read-only. There's no problem > > _looking_ at MTRR contents, as long as we do not try to modify them. > > Hm? > > anyway > > depends on

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Yinghai Lu
On Friday 18 January 2008 12:10:40 am Ingo Molnar wrote: > > * Yinghai Lu <[EMAIL PROTECTED]> wrote: > > > config MTRR > > bool "MTRR (Memory Type Range Register) support" > > - depends on !PAT > > + depends on !X86_PAT > > ---help--- > > On Intel P6 family processors (Pentium

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Ingo Molnar
* Yinghai Lu <[EMAIL PROTECTED]> wrote: > config MTRR > bool "MTRR (Memory Type Range Register) support" > - depends on !PAT > + depends on !X86_PAT > ---help--- > On Intel P6 family processors (Pentium Pro, Pentium II and later) > the Memory Type Range

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Yinghai Lu
On Friday 18 January 2008 12:10:40 am Ingo Molnar wrote: * Yinghai Lu [EMAIL PROTECTED] wrote: config MTRR bool MTRR (Memory Type Range Register) support - depends on !PAT + depends on !X86_PAT ---help--- On Intel P6 family processors (Pentium Pro, Pentium II

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Ingo Molnar
* Pallipadi, Venkatesh [EMAIL PROTECTED] wrote: Ingo, can you remove this PAT MTRR exclusion. yeah, already did that. Actually, this exclusion will not work at all with the current code. Infact it should be PAT selects MTRR, for the current code. As pat_init() is called during mtrr init

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Ingo Molnar
* Dave Jones [EMAIL PROTECTED] wrote: you mean modifies MTRRs? Which code is that? (besides the /proc/mtrr userspace API) This exclusion is going to be a real pain in the ass for distro kernels. It's impossible for example to build a kernel that will now support the MTRR-alike

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Dave Jones
On Fri, Jan 18, 2008 at 01:31:40PM +0100, Ingo Molnar wrote: * Yinghai Lu [EMAIL PROTECTED] wrote: thanks. But, i think we should rather do the following: if X86_PAT is eanbled then /proc/mtrr should be read-only. There's no problem _looking_ at MTRR contents, as long as we do

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Dave Jones
On Fri, Jan 18, 2008 at 10:47:05AM -0800, Venki Pallipadi wrote: This exclusion is going to be a real pain in the ass for distro kernels. It's impossible for example to build a kernel that will now support the MTRR-alike registers on the AMD K6/early Cyrix etc and also support PAT.

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Dave Jones
On Fri, Jan 18, 2008 at 10:02:10PM +0100, Ingo Molnar wrote: * Dave Jones [EMAIL PROTECTED] wrote: you mean modifies MTRRs? Which code is that? (besides the /proc/mtrr userspace API) This exclusion is going to be a real pain in the ass for distro kernels. It's

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Ingo Molnar
* Yinghai Lu [EMAIL PROTECTED] wrote: thanks. But, i think we should rather do the following: if X86_PAT is eanbled then /proc/mtrr should be read-only. There's no problem _looking_ at MTRR contents, as long as we do not try to modify them. Hm? anyway depends on !PAT need to

RE: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Pallipadi, Venkatesh
-Original Message- From: Dave Jones [mailto:[EMAIL PROTECTED] Sent: Friday, January 18, 2008 10:25 AM To: Ingo Molnar Cc: Yinghai Lu; Pallipadi, Venkatesh; LKML Subject: Re: [PATCH] X86: fix typo PAT to X86_PAT On Fri, Jan 18, 2008 at 01:31:40PM +0100, Ingo Molnar wrote: * Yinghai

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Yinghai Lu
On Friday 18 January 2008 07:28:49 pm Dave Jones wrote: On Fri, Jan 18, 2008 at 10:02:10PM +0100, Ingo Molnar wrote: * Dave Jones [EMAIL PROTECTED] wrote: you mean modifies MTRRs? Which code is that? (besides the /proc/mtrr userspace API) This exclusion is going