Hi,
On Fri, 5 Jul 2019 08:26:12 -0400 Sven Van Asbroeck wrote:
> Hi Vinod,
>
> On Fri, Jul 5, 2019 at 3:32 AM Vinod Koul wrote:
> >
> > > + if (ret)
> > > + dev_warn(>dev, "failed to get firmware
> > > name\n");
> >
> > if should have braces!
> > Applied
On Fri, Jul 5, 2019 at 9:13 AM Vinod Koul wrote:
>
> To quote David you need to move to 21st century (like me).
So true :)
Your MAINTAINERS entry in linux-next is still pointing to
infradead, though. But that's becoming less and less useful,
now that most developers are moving to kernel.org ...
On 05-07-19, 09:08, Sven Van Asbroeck wrote:
> Hi Vinod,
>
> On Fri, Jul 5, 2019 at 8:50 AM Vinod Koul wrote:
> >
> > there is an else here too!
> >
>
> You are of course right, I was looking at the wrong if.
NO issues :)
>
> Apologies for the confusion, I did try to look at what you
>
On Fri, Jul 5, 2019 at 10:09 AM Sven Van Asbroeck wrote:
> You are of course right, I was looking at the wrong if.
>
> Apologies for the confusion, I did try to look at what you
> changed, but your git repo listed in MAINTAINERS appears
> unresponsive for me?
Works fine here:
Hi Vinod,
On Fri, Jul 5, 2019 at 8:50 AM Vinod Koul wrote:
>
> there is an else here too!
>
You are of course right, I was looking at the wrong if.
Apologies for the confusion, I did try to look at what you
changed, but your git repo listed in MAINTAINERS appears
unresponsive for me?
Thanks,
On 24-06-19, 10:07, Sven Van Asbroeck wrote:
Quoting orignal patch for better context:
> + if (pdata) {
> + ret = sdma_get_firmware(sdma, pdata->fw_name);
> + if (ret)
> + dev_warn(>dev, "failed to get firmware from
> platform data\n");
> + }
Hi Vinod,
On Fri, Jul 5, 2019 at 3:32 AM Vinod Koul wrote:
>
> > + if (ret)
> > + dev_warn(>dev, "failed to get firmware name\n");
>
> if should have braces!
> Applied after fixing braces!
checkpatch.pl output after adding braces:
WARNING: braces {} are not
On 24-06-19, 10:07, Sven Van Asbroeck wrote:
> If probe() fails anywhere beyond the point where
> sdma_get_firmware() is called, then a kernel oops may occur.
>
> Problematic sequence of events:
> 1. probe() calls sdma_get_firmware(), which schedules the
>firmware callback to run when
Reviewed-by: Robin Gong
> -Original Message-
> From: Sven Van Asbroeck
> Subject: [PATCH] dmaengine: imx-sdma: fix use-after-free on probe error path
>
> If probe() fails anywhere beyond the point where
> sdma_get_firmware() is called, then a kernel oops may occur.
>
> Problematic
9 matches
Mail list logo
