RE: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

On Thu, 19 May 2016 13:49:16 + "N, Soumya P" wrote: > Hi Steve, > > Thanks for the explanation. > I will take care of your comments and send v2 of the same patch. > >>No need, I just pulled in your patch and made the updates to the change log >>and subject myself. I'm

RE: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

On Thu, 19 May 2016 13:49:16 + "N, Soumya P" wrote: > Hi Steve, > > Thanks for the explanation. > I will take care of your comments and send v2 of the same patch. > >>No need, I just pulled in your patch and made the updates to the change log >>and subject myself. I'm starting my tests

Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

On Thu, 19 May 2016 13:49:16 + "N, Soumya P" wrote: > Hi Steve, > > Thanks for the explanation. > I will take care of your comments and send v2 of the same patch. > No need, I just pulled in your patch and made the updates to the change log and subject myself. I'm

Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

On Thu, 19 May 2016 13:49:16 + "N, Soumya P" wrote: > Hi Steve, > > Thanks for the explanation. > I will take care of your comments and send v2 of the same patch. > No need, I just pulled in your patch and made the updates to the change log and subject myself. I'm starting my tests on it

RE: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

Hi Steve, Thanks for the explanation. I will take care of your comments and send v2 of the same patch. Thanks, Soumya. -Original Message- From: Steven Rostedt [mailto:rost...@goodmis.org] Sent: Thursday, May 19, 2016 6:41 PM To: N, Soumya P Cc: mi...@redhat.com;

RE: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

Hi Steve, Thanks for the explanation. I will take care of your comments and send v2 of the same patch. Thanks, Soumya. -Original Message- From: Steven Rostedt [mailto:rost...@goodmis.org] Sent: Thursday, May 19, 2016 6:41 PM To: N, Soumya P Cc: mi...@redhat.com;

Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

On Thu, 19 May 2016 13:49:16 + "N, Soumya P" wrote: > Hi Steve, > > Thanks for the explanation. > I will take care of your comments and send v2 of the same patch. > I'll also note that in our forum (LKML), we do not do "top posting". We practice "inline replying" and

Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

On Thu, 19 May 2016 13:49:16 + "N, Soumya P" wrote: > Hi Steve, > > Thanks for the explanation. > I will take care of your comments and send v2 of the same patch. > I'll also note that in our forum (LKML), we do not do "top posting". We practice "inline replying" and "trimming". See

Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

On Thu, 19 May 2016 08:53:17 + "N, Soumya P" wrote: > Hi Steve, > > Could you please explain what this error means? > Is it related to length of subject? > I have run checkpatch.pl on patch and didn't show any error. > > Thanks, > Soumya. > > -Original Message-

Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

On Thu, 19 May 2016 08:53:17 + "N, Soumya P" wrote: > Hi Steve, > > Could you please explain what this error means? > Is it related to length of subject? > I have run checkpatch.pl on patch and didn't show any error. > > Thanks, > Soumya. > > -Original Message- > From: Steven

Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

Hi, I guess (from the error code) this is to do with your patch not having short one line subject before the detailed explanation of what your patch does. The automated script might be treating your patch detailed description as subject line. More can be found in the patch submitting guideline.

Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

Hi, I guess (from the error code) this is to do with your patch not having short one line subject before the detailed explanation of what your patch does. The automated script might be treating your patch detailed description as subject line. More can be found in the patch submitting guideline.

RE: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

Hi Steve, Could you please explain what this error means? Is it related to length of subject? I have run checkpatch.pl on patch and didn't show any error. Thanks, Soumya. -Original Message- From: Steven Rostedt [mailto:rost...@goodmis.org] Sent: Thursday, May 19, 2016 1:25 AM To: N,

RE: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

Hi Steve, Could you please explain what this error means? Is it related to length of subject? I have run checkpatch.pl on patch and didn't show any error. Thanks, Soumya. -Original Message- From: Steven Rostedt [mailto:rost...@goodmis.org] Sent: Thursday, May 19, 2016 1:25 AM To: N,

Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

-ERUNONSUBJECT -- Steve On Tue, 17 May 2016 21:31:14 +0530 Soumya PN wrote: > In ftrace.c inside the function alloc_retstack_tasklist()(which will be > invoked when function_graph tracing is on) the tasklist_lock is being > held as reader while iterating through list of

Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

-ERUNONSUBJECT -- Steve On Tue, 17 May 2016 21:31:14 +0530 Soumya PN wrote: > In ftrace.c inside the function alloc_retstack_tasklist()(which will be > invoked when function_graph tracing is on) the tasklist_lock is being > held as reader while iterating through list of threads. Here the