RE: [PATCH] kvm/fpu: Enable eager restore kvm FPU for MPX

2015-05-20 Thread Li, Liang Z
> > Is it better to use guest_cpuid_has_mpx() instead of > vmx_mpx_supported()? > > CPUID hasn't been set yet, so I think it is okay to key it on > vmx_mpx_supported(). It will be deactivated soon afterwards. > > Or even do it unconditionally; just make sure to add a comment about it. > > >>

RE: [PATCH] kvm/fpu: Enable eager restore kvm FPU for MPX

2015-05-20 Thread Zhang, Yang Z
Paolo Bonzini wrote on 2015-05-20: > > > On 20/05/2015 07:20, Zhang, Yang Z wrote: >> Li, Liang Z wrote on 2015-05-20: >>> The MPX feature requires eager KVM FPU restore support. We have >>> verified that MPX cannot work correctly with the current lazy KVM >>> FPU restore mechanism. Eager KVM

Re: [PATCH] kvm/fpu: Enable eager restore kvm FPU for MPX

2015-05-20 Thread Paolo Bonzini
On 20/05/2015 07:20, Zhang, Yang Z wrote: > Li, Liang Z wrote on 2015-05-20: >> The MPX feature requires eager KVM FPU restore support. We have >> verified that MPX cannot work correctly with the current lazy KVM FPU >> restore mechanism. Eager KVM FPU restore should be enabled if the MPX >>

RE: [PATCH] kvm/fpu: Enable eager restore kvm FPU for MPX

2015-05-20 Thread Zhang, Yang Z
Paolo Bonzini wrote on 2015-05-20: On 20/05/2015 07:20, Zhang, Yang Z wrote: Li, Liang Z wrote on 2015-05-20: The MPX feature requires eager KVM FPU restore support. We have verified that MPX cannot work correctly with the current lazy KVM FPU restore mechanism. Eager KVM FPU restore

Re: [PATCH] kvm/fpu: Enable eager restore kvm FPU for MPX

2015-05-20 Thread Paolo Bonzini
On 20/05/2015 07:20, Zhang, Yang Z wrote: Li, Liang Z wrote on 2015-05-20: The MPX feature requires eager KVM FPU restore support. We have verified that MPX cannot work correctly with the current lazy KVM FPU restore mechanism. Eager KVM FPU restore should be enabled if the MPX feature is

RE: [PATCH] kvm/fpu: Enable eager restore kvm FPU for MPX

2015-05-20 Thread Li, Liang Z
Is it better to use guest_cpuid_has_mpx() instead of vmx_mpx_supported()? CPUID hasn't been set yet, so I think it is okay to key it on vmx_mpx_supported(). It will be deactivated soon afterwards. Or even do it unconditionally; just make sure to add a comment about it. diff --git

RE: [PATCH] kvm/fpu: Enable eager restore kvm FPU for MPX

2015-05-19 Thread Zhang, Yang Z
Li, Liang Z wrote on 2015-05-20: > The MPX feature requires eager KVM FPU restore support. We have > verified that MPX cannot work correctly with the current lazy KVM FPU > restore mechanism. Eager KVM FPU restore should be enabled if the MPX > feature is exposed to VM. > > Signed-off-by: Liang

RE: [PATCH] kvm/fpu: Enable eager restore kvm FPU for MPX

2015-05-19 Thread Li, Liang Z
Correct Gleb's email address. Liang > -Original Message- > From: Li, Liang Z > Sent: Wednesday, May 20, 2015 10:36 PM > To: k...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: g...@kernel.or; pbonz...@redhat.com; t...@linutronix.de; > mi...@redhat.com; h...@zytor.com;

RE: [PATCH] kvm/fpu: Enable eager restore kvm FPU for MPX

2015-05-19 Thread Zhang, Yang Z
Li, Liang Z wrote on 2015-05-20: The MPX feature requires eager KVM FPU restore support. We have verified that MPX cannot work correctly with the current lazy KVM FPU restore mechanism. Eager KVM FPU restore should be enabled if the MPX feature is exposed to VM. Signed-off-by: Liang Li

RE: [PATCH] kvm/fpu: Enable eager restore kvm FPU for MPX

2015-05-19 Thread Li, Liang Z
Correct Gleb's email address. Liang -Original Message- From: Li, Liang Z Sent: Wednesday, May 20, 2015 10:36 PM To: k...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: g...@kernel.or; pbonz...@redhat.com; t...@linutronix.de; mi...@redhat.com; h...@zytor.com; x...@kernel.org;