Re: [PATCH] lib/spinlock_debug: Tweak the loop time to fit different _delay()

2014-04-30 Thread Peter Zijlstra
> Subject: Re: [PATCH] lib/spinlock_debug: Tweak the loop time to fit > > different > > _delay() > > > > On Wed, Apr 30, 2014 at 06:40:38PM -0400, Wang, Xiaoming wrote: > > > loops_per_jiffy*Hz is not always 1 second exactly > > > it depends on the realization o

RE: [PATCH] lib/spinlock_debug: Tweak the loop time to fit different _delay()

2014-04-30 Thread Liu, Chuansheng
Hello Peter, > -Original Message- > From: Peter Zijlstra [mailto:pet...@infradead.org] > Sent: Wednesday, April 30, 2014 4:55 PM > To: Wang, Xiaoming > Cc: mi...@redhat.com; linux-kernel@vger.kernel.org; Liu, Chuansheng > Subject: Re: [PATCH] lib/spinlock_debug: Tweak th

Re: [PATCH] lib/spinlock_debug: Tweak the loop time to fit different _delay()

2014-04-30 Thread Peter Zijlstra
On Wed, Apr 30, 2014 at 06:40:38PM -0400, Wang, Xiaoming wrote: > loops_per_jiffy*Hz is not always 1 second exactly > it depends on the realization of _delay() . > delay_tsc is used as _delay() in arch/x86/lib/delay.c This just states delay() is broken. The primary response should be to try and f

Re: [PATCH] lib/spinlock_debug: Tweak the loop time to fit different _delay()

2014-04-30 Thread Peter Zijlstra
On Wed, Apr 30, 2014 at 06:40:38PM -0400, Wang, Xiaoming wrote: > loops_per_jiffy*Hz is not always 1 second exactly > it depends on the realization of _delay() . > delay_tsc is used as _delay() in arch/x86/lib/delay.c > It makes loop loops_per_jiffy larger than exception > and causes one thread ca