RE: [PATCH] net: hns: Fix object reference leaks in hns_dsaf_roce_reset()

2019-02-18 Thread Salil Mehta
> From: John Garry > Sent: Friday, February 15, 2019 12:00 PM > > On 15/02/2019 11:25, Salil Mehta wrote: > >> From: John Garry > >> Sent: Friday, February 15, 2019 10:52 AM > >> > >> On 14/02/2019 06:41, Huang Zijiang wrote: > >>> The of_find_device_by_node() takes a reference to the underlying

Re: [PATCH] net: hns: Fix object reference leaks in hns_dsaf_roce_reset()

2019-02-15 Thread John Garry
On 15/02/2019 11:25, Salil Mehta wrote: From: John Garry Sent: Friday, February 15, 2019 10:52 AM On 14/02/2019 06:41, Huang Zijiang wrote: The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. of_find_device_by_node() is not

RE: [PATCH] net: hns: Fix object reference leaks in hns_dsaf_roce_reset()

2019-02-15 Thread Salil Mehta
> From: John Garry > Sent: Friday, February 15, 2019 10:52 AM > > On 14/02/2019 06:41, Huang Zijiang wrote: > > The of_find_device_by_node() takes a reference to the underlying device > > structure, we should release that reference. > > of_find_device_by_node() is not called for every path, so

Re: [PATCH] net: hns: Fix object reference leaks in hns_dsaf_roce_reset()

2019-02-15 Thread John Garry
On 14/02/2019 06:41, Huang Zijiang wrote: The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. of_find_device_by_node() is not called for every path, so is this change proper: /* find the platform device corresponding

Re: [PATCH] net: hns: Fix object reference leaks in hns_dsaf_roce_reset()

2019-02-14 Thread David Miller
From: Huang Zijiang Date: Thu, 14 Feb 2019 14:41:45 +0800 > The of_find_device_by_node() takes a reference to the underlying device > structure, we should release that reference. > > Signed-off-by: Huang Zijiang Applied, thank you.