Hi Wang-san, > From: Wang Dongsheng, Sent: Tuesday, December 19, 2017 8:37 PM > > of_usb_get_dr_mode_by_phy is implemented in usb/common/common.c. > So the PHY_RCAR_GEN3_USB2 must depend on USB_SUPPORT/USB_COMMON. > > LD vmlinux.o > MODPOST vmlinux.o > .../phy-rcar-gen3-usb2.o: In function `rcar_gen3_phy_usb2_probe': > ...: undefined reference to `of_usb_get_dr_mode_by_phy' > make: *** [vmlinux] Error 1 > > Signed-off-by: Wang Dongsheng <dongsheng.w...@hxt-semitech.com>
Thank you for the patch! However, Arnd already sent such a patch before [1] and it will be merged into the usb repository [2] in near the future. [1] https://lkml.org/lkml/2017/11/2/373 [2] git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. Best regards, Yoshihiro Shimoda > --- > drivers/phy/renesas/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig > index cb09245..c845fac 100644 > --- a/drivers/phy/renesas/Kconfig > +++ b/drivers/phy/renesas/Kconfig > @@ -12,7 +12,9 @@ config PHY_RCAR_GEN3_USB2 > tristate "Renesas R-Car generation 3 USB 2.0 PHY driver" > depends on ARCH_RENESAS > depends on EXTCON > + depends on USB_SUPPORT > select GENERIC_PHY > + select USB_COMMON > help > Support for USB 2.0 PHY found on Renesas R-Car generation 3 SoCs. > > -- > 2.7.4
