RE: [PATCH] pinctrl: tegra: add suspend-resume support

2013-04-23 Thread Bibek Basu
On 23/04/2013 11:25 PM, Bibek Basu wrote: > -Original Message- > From: Linus Walleij [mailto:linus.wall...@linaro.org] > Sent: Wednesday, April 03, 2013 9:52 PM > To: Bibek Basu > Cc: linux-kernel@vger.kernel.org; Pritesh Raithatha > Subject: Re: [PATCH] pinctrl: tegra:

RE: [PATCH] pinctrl: tegra: add suspend-resume support

2013-04-23 Thread Bibek Basu
On 23/04/2013 11:25 PM, Bibek Basu wrote: -Original Message- From: Linus Walleij [mailto:linus.wall...@linaro.org] Sent: Wednesday, April 03, 2013 9:52 PM To: Bibek Basu Cc: linux-kernel@vger.kernel.org; Pritesh Raithatha Subject: Re: [PATCH] pinctrl: tegra: add suspend-resume

Re: [PATCH] pinctrl: tegra: add suspend-resume support

2013-04-03 Thread Linus Walleij
On Wed, Apr 3, 2013 at 7:16 PM, Stephen Warren wrote: > It's possible program the registers so that the same signal is connected > to (or from depending on signal direction) multiple pins at once. If > this is done, the behaviour is unspecified; who knows which pin will > actually receive (or

Re: [PATCH] pinctrl: tegra: add suspend-resume support

2013-04-03 Thread Stephen Warren
On 04/03/2013 08:09 AM, Linus Walleij wrote: > On Thu, Mar 28, 2013 at 6:48 PM, Stephen Warren wrote: > >> Why can't we just use the device suspend/resume functions rather than >> global (syscore) suspend/resume functions? Presumably this is to ensure >> that all other drivers suspend first,

Re: [PATCH] pinctrl: tegra: add suspend-resume support

2013-04-03 Thread Linus Walleij
On Thu, Mar 28, 2013 at 6:11 PM, Bibek Basu wrote: Hm I recognize this name :-) > This patch adds suspend and resume callbacks to the pinctrl-tegra driver. Please be more verbose. How is this achieved? I have to guess what the code is doing.. > +#ifdef CONFIG_PM_SLEEP > + > +static int

Re: [PATCH] pinctrl: tegra: add suspend-resume support

2013-04-03 Thread Linus Walleij
On Thu, Mar 28, 2013 at 6:48 PM, Stephen Warren wrote: > Why can't we just use the device suspend/resume functions rather than > global (syscore) suspend/resume functions? Presumably this is to ensure > that all other drivers suspend first, then the pinctrl driver does, and > the reverse for

Re: [PATCH] pinctrl: tegra: add suspend-resume support

2013-04-03 Thread Linus Walleij
On Thu, Mar 28, 2013 at 6:48 PM, Stephen Warren swar...@wwwdotorg.org wrote: Why can't we just use the device suspend/resume functions rather than global (syscore) suspend/resume functions? Presumably this is to ensure that all other drivers suspend first, then the pinctrl driver does, and

Re: [PATCH] pinctrl: tegra: add suspend-resume support

2013-04-03 Thread Linus Walleij
On Thu, Mar 28, 2013 at 6:11 PM, Bibek Basu bb...@nvidia.com wrote: Hm I recognize this name :-) This patch adds suspend and resume callbacks to the pinctrl-tegra driver. Please be more verbose. How is this achieved? I have to guess what the code is doing.. +#ifdef CONFIG_PM_SLEEP +

Re: [PATCH] pinctrl: tegra: add suspend-resume support

2013-04-03 Thread Stephen Warren
On 04/03/2013 08:09 AM, Linus Walleij wrote: On Thu, Mar 28, 2013 at 6:48 PM, Stephen Warren swar...@wwwdotorg.org wrote: Why can't we just use the device suspend/resume functions rather than global (syscore) suspend/resume functions? Presumably this is to ensure that all other drivers

Re: [PATCH] pinctrl: tegra: add suspend-resume support

2013-04-03 Thread Linus Walleij
On Wed, Apr 3, 2013 at 7:16 PM, Stephen Warren swar...@wwwdotorg.org wrote: It's possible program the registers so that the same signal is connected to (or from depending on signal direction) multiple pins at once. If this is done, the behaviour is unspecified; who knows which pin will

Re: [PATCH] pinctrl: tegra: add suspend-resume support

2013-04-01 Thread Stephen Warren
On 03/31/2013 10:34 PM, Bibek Basu wrote: > Hi Stephen, > > My response inline. Upstream, responses should always be inline, so there's no need to mention that. By the way, can you please configure your email client to: a) Not re-wrap the email you're replying to; email should be wrapped to

Re: [PATCH] pinctrl: tegra: add suspend-resume support

2013-04-01 Thread Stephen Warren
On 03/31/2013 10:34 PM, Bibek Basu wrote: Hi Stephen, My response inline. Upstream, responses should always be inline, so there's no need to mention that. By the way, can you please configure your email client to: a) Not re-wrap the email you're replying to; email should be wrapped to about

RE: [PATCH] pinctrl: tegra: add suspend-resume support

2013-03-31 Thread Bibek Basu
Hi Stephen, My response inline. Regards Bibek -Original Message- From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Thursday, March 28, 2013 11:19 PM To: Bibek Basu Cc: Linus Walleij; linux-kernel@vger.kernel.org; Pritesh Raithatha Subject: Re: [PATCH] pinctrl: tegra: add

RE: [PATCH] pinctrl: tegra: add suspend-resume support

2013-03-31 Thread Bibek Basu
Hi Stephen, My response inline. Regards Bibek -Original Message- From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Thursday, March 28, 2013 11:19 PM To: Bibek Basu Cc: Linus Walleij; linux-kernel@vger.kernel.org; Pritesh Raithatha Subject: Re: [PATCH] pinctrl: tegra: add

Re: [PATCH] pinctrl: tegra: add suspend-resume support

2013-03-28 Thread Stephen Warren
On 03/28/2013 11:11 AM, Bibek Basu wrote: > From: Pritesh Raithatha > > This patch adds suspend and resume callbacks to the pinctrl-tegra driver. > > Based on work by: > Pritesh Raithatha Those two lines are somewhat implied by the fact the commit's git author field is Pritesh, and his s-o-b

Re: [PATCH] pinctrl: tegra: add suspend-resume support

2013-03-28 Thread Stephen Warren
On 03/28/2013 11:11 AM, Bibek Basu wrote: From: Pritesh Raithatha praitha...@nvidia.com This patch adds suspend and resume callbacks to the pinctrl-tegra driver. Based on work by: Pritesh Raithatha praitha...@nvidia.com Those two lines are somewhat implied by the fact the commit's git

Re: [PATCH] pinctrl: tegra: add suspend/resume support

2012-11-01 Thread Stephen Warren
On 11/01/2012 09:53 AM, Dmitry Osipenko wrote: > Added suspend/resume pm ops. We need to store current regs vals on suspend and > restore them on resume. Interesting. Just literally a couple days ago, I was reviewing a patch to our internal kernel tree that implemented the same thing for the

Re: [PATCH] pinctrl: tegra: add suspend/resume support

2012-11-01 Thread Stephen Warren
On 11/01/2012 09:53 AM, Dmitry Osipenko wrote: Added suspend/resume pm ops. We need to store current regs vals on suspend and restore them on resume. Interesting. Just literally a couple days ago, I was reviewing a patch to our internal kernel tree that implemented the same thing for the