Re: [PATCH] pwm_lpss: Add support for PCI devices

2014-05-13 Thread Thierry Reding
On Mon, May 12, 2014 at 04:18:16PM -0700, Darren Hart wrote: > On Sat, Apr 12, 2014 at 09:58:51PM +0800, Chew Chiau Ee wrote: > > From: Alan Cox > > > > Not all systems enumerate the PWM devices via ACPI. They can also be exposed > > via the PCI interface. > > > > Signed-off-by: Alan Cox > > Si

Re: [PATCH] pwm_lpss: Add support for PCI devices

2014-05-12 Thread Darren Hart
On Sat, Apr 12, 2014 at 09:58:51PM +0800, Chew Chiau Ee wrote: > From: Alan Cox > > Not all systems enumerate the PWM devices via ACPI. They can also be exposed > via the PCI interface. > > Signed-off-by: Alan Cox > Signed-off-by: Chew, Chiau Ee > --- > drivers/pwm/pwm-lpss.c | 160 +

RE: [PATCH] pwm_lpss: Add support for PCI devices

2014-04-15 Thread Chew, Chiau Ee
> On Tue, Apr 15, 2014 at 08:41:02AM +, Chew, Chiau Ee wrote: > > > > > > > > +static struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, > > > > + struct resource *r, struct pwm_lpss_boardinfo > > > > *info) > > > > { > > > > struct pwm_lpss_chip *lpwm; > >

RE: [PATCH] pwm_lpss: Add support for PCI devices

2014-04-15 Thread Chew, Chiau Ee
> On Mon, Apr 14, 2014 at 02:05:25AM +, Chew, Chiau Ee wrote: > > > > MODULE_DESCRIPTION("PWM driver for Intel LPSS"); > > > >MODULE_AUTHOR("Mika Westerberg > > > >"); > > > > MODULE_LICENSE("GPL v2"); > > > > MODULE_ALIAS("platform:pwm-lpss"); > > > > > > Looks a good idea to combine pci a

Re: [PATCH] pwm_lpss: Add support for PCI devices

2014-04-15 Thread Mika Westerberg
On Tue, Apr 15, 2014 at 08:41:02AM +, Chew, Chiau Ee wrote: > > > > > +static struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, > > > + struct resource *r, struct pwm_lpss_boardinfo *info) > > > { > > > struct pwm_lpss_chip *lpwm; > > > - struct resource *r; > > >

RE: [PATCH] pwm_lpss: Add support for PCI devices

2014-04-15 Thread Chew, Chiau Ee
> > +static struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, > > + struct resource *r, struct pwm_lpss_boardinfo *info) > > { > > struct pwm_lpss_chip *lpwm; > > - struct resource *r; > > int ret; > > > > - lpwm = devm_kzalloc(&pdev->dev, sizeof(*lpwm), GFP_

Re: [PATCH] pwm_lpss: Add support for PCI devices

2014-04-14 Thread Mika Westerberg
On Mon, Apr 14, 2014 at 02:05:25AM +, Chew, Chiau Ee wrote: > > > MODULE_DESCRIPTION("PWM driver for Intel LPSS"); > > >MODULE_AUTHOR("Mika > > > Westerberg "); > > > MODULE_LICENSE("GPL v2"); > > > MODULE_ALIAS("platform:pwm-lpss"); > > > > Looks a good idea to combine pci and acpi driver

Re: [PATCH] pwm_lpss: Add support for PCI devices

2014-04-14 Thread Mika Westerberg
On Sat, Apr 12, 2014 at 09:58:51PM +0800, Chew Chiau Ee wrote: > From: Alan Cox > > Not all systems enumerate the PWM devices via ACPI. They can also be exposed > via the PCI interface. > > Signed-off-by: Alan Cox > Signed-off-by: Chew, Chiau Ee > --- > drivers/pwm/pwm-lpss.c | 160 +

RE: [PATCH] pwm_lpss: Add support for PCI devices

2014-04-13 Thread Chew, Chiau Ee
> > MODULE_DESCRIPTION("PWM driver for Intel LPSS"); > >MODULE_AUTHOR("Mika > > Westerberg "); > > MODULE_LICENSE("GPL v2"); > > MODULE_ALIAS("platform:pwm-lpss"); > > Looks a good idea to combine pci and acpi driver together. > Since pci driver is added, here the alias need to be refined. > Ot

Re: [PATCH] pwm_lpss: Add support for PCI devices

2014-04-13 Thread Li, Aubrey
On 2014/4/12 21:58, Chew Chiau Ee wrote: > From: Alan Cox > > Not all systems enumerate the PWM devices via ACPI. They can also be exposed > via the PCI interface. > > Signed-off-by: Alan Cox > Signed-off-by: Chew, Chiau Ee > --- > drivers/pwm/pwm-lpss.c | 160 +++