RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-09-08 Thread H. Peter Anvin
Please answer the questions that I asked, not something else entirely. "Liu, Chuansheng" wrote: >Hello hpa, > >> I could be wrong and the cold/warm reset values in CF9 end up having >> exactly the same function as the magic BIOS signature does; if so, >then >> I would like to be told so

RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-09-08 Thread Liu, Chuansheng
Hello hpa, > I could be wrong and the cold/warm reset values in CF9 end up having > exactly the same function as the magic BIOS signature does; if so, then > I would like to be told so explicitly, ideally with an explanation about > how it works on the hw level (or a pointer to relevant

RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-09-08 Thread Liu, Chuansheng
Hello hpa, I could be wrong and the cold/warm reset values in CF9 end up having exactly the same function as the magic BIOS signature does; if so, then I would like to be told so explicitly, ideally with an explanation about how it works on the hw level (or a pointer to relevant

RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-09-08 Thread H. Peter Anvin
Please answer the questions that I asked, not something else entirely. Liu, Chuansheng chuansheng@intel.com wrote: Hello hpa, I could be wrong and the cold/warm reset values in CF9 end up having exactly the same function as the magic BIOS signature does; if so, then I would like to be

Re: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-09-03 Thread H. Peter Anvin
On 08/21/2013 08:32 PM, Li, Fei wrote: > > In fact, ACPI method also implements reset by writing RESET_VALUE into > RESET_REG > port. In our platform, it also uses port 0xCF9. The difference between cold > and wart reset > is whether power cycle is involved or not. After all, this is another

Re: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-09-03 Thread H. Peter Anvin
On 08/21/2013 08:32 PM, Li, Fei wrote: In fact, ACPI method also implements reset by writing RESET_VALUE into RESET_REG port. In our platform, it also uses port 0xCF9. The difference between cold and wart reset is whether power cycle is involved or not. After all, this is another topic.

RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-08-21 Thread Li, Fei
> Subject: RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type > > The thing is that the existing "warm" and "cold" means something different, I > believe (skip post vs do post.) It is possible it just works, but it would > be good to > know

RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-08-21 Thread H. Peter Anvin
The thing is that the existing "warm" and "cold" means something different, I believe (skip post vs do post.) It is possible it just works, but it would be good to know which platforms or works on. Also, why do you need the cf9 boot method at all? All current systems * should * use the ACPI

RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-08-21 Thread Li, Fei
> Careful. This is a very different definition of warm vs cold boot used > elsewhere. We have tested both warm and cold reboot on our x86 platform, and it works well. Besides with commit, the expected warm and reboot type can be specified through command line. > >Looks good, but please

Re: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-08-21 Thread H. Peter Anvin
Careful. This is a very different definition of warm vs cold boot used elsewhere. Ingo Molnar wrote: > >* Li Fei wrote: > >> In current implementation for reboot type CF9 and CF9_COND, >> warm and cold reset are not differentiated, and both are >> performed by writing 0x06 to port 0xCF9 as

Re: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-08-21 Thread Ingo Molnar
* Li Fei wrote: > In current implementation for reboot type CF9 and CF9_COND, > warm and cold reset are not differentiated, and both are > performed by writing 0x06 to port 0xCF9 as warm reset. It's not > correct. > > This commit will differentiate warm and cold reset, and perform > them

Re: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-08-21 Thread Ingo Molnar
* Li Fei fei...@intel.com wrote: In current implementation for reboot type CF9 and CF9_COND, warm and cold reset are not differentiated, and both are performed by writing 0x06 to port 0xCF9 as warm reset. It's not correct. This commit will differentiate warm and cold reset, and perform

Re: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-08-21 Thread H. Peter Anvin
Careful. This is a very different definition of warm vs cold boot used elsewhere. Ingo Molnar mi...@kernel.org wrote: * Li Fei fei...@intel.com wrote: In current implementation for reboot type CF9 and CF9_COND, warm and cold reset are not differentiated, and both are performed by writing

RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-08-21 Thread Li, Fei
Careful. This is a very different definition of warm vs cold boot used elsewhere. We have tested both warm and cold reboot on our x86 platform, and it works well. Besides with commit, the expected warm and reboot type can be specified through command line. Looks good, but please introduce a

RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-08-21 Thread H. Peter Anvin
The thing is that the existing warm and cold means something different, I believe (skip post vs do post.) It is possible it just works, but it would be good to know which platforms or works on. Also, why do you need the cf9 boot method at all? All current systems * should * use the ACPI

RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type

2013-08-21 Thread Li, Fei
Subject: RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type The thing is that the existing warm and cold means something different, I believe (skip post vs do post.) It is possible it just works, but it would be good to know which platforms or works on. Also, why do you