Re: [PATCH] rtc: pcf2127: clear the flag TSF1 before enabling interrupt generation

2020-12-02 Thread kernel test robot
Hi Biwen, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on abelloni/rtc-next] [also build test WARNING on v5.10-rc6 next-20201201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

RE: [PATCH] rtc: pcf2127: clear the flag TSF1 before enabling interrupt generation

2020-12-01 Thread Biwen Li (OSS)
> > Hi, > > On 01/12/2020 16:47:46+0800, Biwen Li wrote: > > From: Biwen Li > > > > - clear the flag TSF1 before enabling interrupt generation > > - properly set flag WD_CD for rtc chips(pcf2129, pca2129) > > > > This change has to be a separate patch. Sure, np. Will separate the patch in v2.

Re: [PATCH] rtc: pcf2127: clear the flag TSF1 before enabling interrupt generation

2020-12-01 Thread Alexandre Belloni
Hi, On 01/12/2020 16:47:46+0800, Biwen Li wrote: > From: Biwen Li > > - clear the flag TSF1 before enabling interrupt generation > - properly set flag WD_CD for rtc chips(pcf2129, pca2129) > This change has to be a separate patch. > Signed-off-by: Biwen Li > --- > drivers/rtc/rtc-pcf2127.c

Re: [PATCH] rtc: pcf2127: clear the flag TSF1 before enabling interrupt generation

2020-12-01 Thread kernel test robot
Hi Biwen, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on abelloni/rtc-next] [also build test WARNING on v5.10-rc6 next-20201130] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as