Re: [PATCH] staging: comedi: amplc_pci230: fix DACOUT write

2014-09-09 Thread Ian Abbott
On 2014-09-08 20:34, Hartley Sweeten wrote: On Monday, September 08, 2014 12:15 PM, Greg Kroah-Hartman wrote: On Tue, Aug 19, 2014 at 12:32:36PM +0100, Ian Abbott wrote: Commit 4f9c63fe5333b27ab23ed399830c7977f6970744 ("staging: comedi: amplc_pci230: refactor iobase addresses") removed some

Re: [PATCH] staging: comedi: amplc_pci230: fix DACOUT write

2014-09-09 Thread Ian Abbott
On 2014-09-08 20:34, Hartley Sweeten wrote: On Monday, September 08, 2014 12:15 PM, Greg Kroah-Hartman wrote: On Tue, Aug 19, 2014 at 12:32:36PM +0100, Ian Abbott wrote: Commit 4f9c63fe5333b27ab23ed399830c7977f6970744 (staging: comedi: amplc_pci230: refactor iobase addresses) removed some

RE: [PATCH] staging: comedi: amplc_pci230: fix DACOUT write

2014-09-08 Thread Hartley Sweeten
On Monday, September 08, 2014 12:15 PM, Greg Kroah-Hartman wrote: > On Tue, Aug 19, 2014 at 12:32:36PM +0100, Ian Abbott wrote: >> Commit 4f9c63fe5333b27ab23ed399830c7977f6970744 ("staging: comedi: >> amplc_pci230: refactor iobase addresses") removed some parentheses >> (presumably to keep the

Re: [PATCH] staging: comedi: amplc_pci230: fix DACOUT write

2014-09-08 Thread Greg Kroah-Hartman
On Tue, Aug 19, 2014 at 12:32:36PM +0100, Ian Abbott wrote: > Commit 4f9c63fe5333b27ab23ed399830c7977f6970744 ("staging: comedi: > amplc_pci230: refactor iobase addresses") removed some parentheses > (presumably to keep the line withing 80 chars) in > `pci230_ao_write_nofifo()` when writing to the

Re: [PATCH] staging: comedi: amplc_pci230: fix DACOUT write

2014-09-08 Thread Greg Kroah-Hartman
On Tue, Aug 19, 2014 at 12:32:36PM +0100, Ian Abbott wrote: Commit 4f9c63fe5333b27ab23ed399830c7977f6970744 (staging: comedi: amplc_pci230: refactor iobase addresses) removed some parentheses (presumably to keep the line withing 80 chars) in `pci230_ao_write_nofifo()` when writing to the

RE: [PATCH] staging: comedi: amplc_pci230: fix DACOUT write

2014-09-08 Thread Hartley Sweeten
On Monday, September 08, 2014 12:15 PM, Greg Kroah-Hartman wrote: On Tue, Aug 19, 2014 at 12:32:36PM +0100, Ian Abbott wrote: Commit 4f9c63fe5333b27ab23ed399830c7977f6970744 (staging: comedi: amplc_pci230: refactor iobase addresses) removed some parentheses (presumably to keep the line withing