Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-31 Thread Nicholas A. Bellinger
On Thu, 2015-07-23 at 15:27 -0700, Spencer Baugh wrote: > From: Brian Bunker > > AIX servers using VIOS servers that virtualize FC cards will have a > problem booting without support for START_STOP_UNIT. > > v2: Cite sb3r36 exactly, clean up if conditions > > Signed-off-by: Brian Bunker >

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-31 Thread Nicholas A. Bellinger
On Thu, 2015-07-23 at 15:27 -0700, Spencer Baugh wrote: From: Brian Bunker br...@purestorage.com AIX servers using VIOS servers that virtualize FC cards will have a problem booting without support for START_STOP_UNIT. v2: Cite sb3r36 exactly, clean up if conditions Signed-off-by: Brian

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-25 Thread Christoph Hellwig
On Fri, Jul 24, 2015 at 03:06:12AM +, Elliott, Robert (Server Storage) wrote: > Note that the officially published versions of the ISO and ANSI > standards don't carry that revision number r36; they just have > the standard name and year. SBC-3 revision 36 became > "ANSI INCITS 514-2014

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-25 Thread Christoph Hellwig
On Fri, Jul 24, 2015 at 03:06:12AM +, Elliott, Robert (Server Storage) wrote: Note that the officially published versions of the ISO and ANSI standards don't carry that revision number r36; they just have the standard name and year. SBC-3 revision 36 became ANSI INCITS 514-2014

RE: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Spencer Baugh > Sent: Thursday, July 23, 2015 5:28 PM > To: Christoph Hellwig ; Spencer Baugh > ... > Subject: Re: [PATCH] target: add suppor

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Spencer Baugh
From: Brian Bunker AIX servers using VIOS servers that virtualize FC cards will have a problem booting without support for START_STOP_UNIT. v2: Cite sb3r36 exactly, clean up if conditions Signed-off-by: Brian Bunker Signed-off-by: Spencer Baugh --- drivers/target/target_core_sbc.c | 36

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Christoph Hellwig
On Tue, Jul 21, 2015 at 03:07:53PM -0700, Spencer Baugh wrote: > +static sense_reason_t > +sbc_emulate_startstop(struct se_cmd *cmd) > +{ > + unsigned char *cdb = cmd->t_task_cdb; > + > + /* From SBC-3: > + * Immediate bit should be set since there is nothing to complete > + *

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Spencer Baugh
From: Brian Bunker br...@purestorage.com AIX servers using VIOS servers that virtualize FC cards will have a problem booting without support for START_STOP_UNIT. v2: Cite sb3r36 exactly, clean up if conditions Signed-off-by: Brian Bunker br...@purestorage.com Signed-off-by: Spencer Baugh

RE: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Elliott, Robert (Server Storage)
-Original Message- From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- ow...@vger.kernel.org] On Behalf Of Spencer Baugh Sent: Thursday, July 23, 2015 5:28 PM To: Christoph Hellwig h...@infradead.org; Spencer Baugh sba...@catern.com ... Subject: Re: [PATCH] target: add

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Christoph Hellwig
On Tue, Jul 21, 2015 at 03:07:53PM -0700, Spencer Baugh wrote: +static sense_reason_t +sbc_emulate_startstop(struct se_cmd *cmd) +{ + unsigned char *cdb = cmd-t_task_cdb; + + /* From SBC-3: + * Immediate bit should be set since there is nothing to complete + * POWER