Re: [PATCH] usb: gadget: don't create new string_container if already exist

2014-11-05 Thread Felipe Balbi
g > > Cc: ba...@ti.com; gre...@linuxfoundation.org > > Subject: Re: [PATCH] usb: gadget: don't create new string_container if > > already > > exist > > > > Hi, > > > > W dniu 28.10.2014 o 12:33, Neil Zhang pisze: > > > Don't create new usb_gadget_stri

Re: [PATCH] usb: gadget: don't create new string_container if already exist

2014-11-05 Thread Felipe Balbi
Subject: Re: [PATCH] usb: gadget: don't create new string_container if already exist Hi, W dniu 28.10.2014 o 12:33, Neil Zhang pisze: Don't create new usb_gadget_string_container if the current strings are already exist in the usb_composite_dev. Otherwise the ids_tab

Re: [PATCH] usb: gadget: don't create new string_container if already exist

2014-11-04 Thread Andrzej Pietrasiewicz
] usb: gadget: don't create new string_container if already exist The problem you are describing does not exist in mainline kernel, where functions are always unbound as part of the whole gadget's unbind - regardless of whether it is a legacy gadget or configfs-composed gadget. When the whole

RE: [PATCH] usb: gadget: don't create new string_container if already exist

2014-11-04 Thread Neil Zhang
> -Original Message- > From: Andrzej Pietrasiewicz [mailto:andrze...@samsung.com] > Sent: 2014年10月28日 21:10 > To: Neil Zhang; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: ba...@ti.com; gre...@linuxfoundation.org > Subject: Re: [PATCH] usb: gadget

RE: [PATCH] usb: gadget: don't create new string_container if already exist

2014-11-04 Thread Neil Zhang
-Original Message- From: Andrzej Pietrasiewicz [mailto:andrze...@samsung.com] Sent: 2014年10月28日 21:10 To: Neil Zhang; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: ba...@ti.com; gre...@linuxfoundation.org Subject: Re: [PATCH] usb: gadget: don't create new

Re: [PATCH] usb: gadget: don't create new string_container if already exist

2014-11-04 Thread Andrzej Pietrasiewicz
] usb: gadget: don't create new string_container if already exist snip The problem you are describing does not exist in mainline kernel, where functions are always unbound as part of the whole gadget's unbind - regardless of whether it is a legacy gadget or configfs-composed gadget. When

Re: [PATCH] usb: gadget: don't create new string_container if already exist

2014-10-28 Thread Andrzej Pietrasiewicz
Hi, W dniu 28.10.2014 o 12:33, Neil Zhang pisze: Don't create new usb_gadget_string_container if the current strings are already exist in the usb_composite_dev. Otherwise the ids_tab will overflow soon if we bind / unbind usb functions frequently like android does. The problem you are

Re: [PATCH] usb: gadget: don't create new string_container if already exist

2014-10-28 Thread Andrzej Pietrasiewicz
Hi, W dniu 28.10.2014 o 12:33, Neil Zhang pisze: Don't create new usb_gadget_string_container if the current strings are already exist in the usb_composite_dev. Otherwise the ids_tab will overflow soon if we bind / unbind usb functions frequently like android does. The problem you are