RE: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-04-03 Thread Venu Byravarasu
Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init > > On 04/02/2013 01:12 AM, Venu Byravarasu wrote: > >> gre...@linuxfoundation.org wrote at Tuesday, March 05, 2013 6:04 AM: > >> On Mon, Mar 04, 2013 at 09:55:44AM -0700, Stephen Warren wrote: > &

RE: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-04-03 Thread Venu Byravarasu
: Reset Tegra USB controller before init On 04/02/2013 01:12 AM, Venu Byravarasu wrote: gre...@linuxfoundation.org wrote at Tuesday, March 05, 2013 6:04 AM: On Mon, Mar 04, 2013 at 09:55:44AM -0700, Stephen Warren wrote: On 03/04/2013 12:55 AM, Venu Byravarasu wrote: Stephen Warren wrote

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-04-02 Thread Stephen Warren
On 04/02/2013 01:12 AM, Venu Byravarasu wrote: >> gre...@linuxfoundation.org wrote at Tuesday, March 05, 2013 6:04 AM: >> On Mon, Mar 04, 2013 at 09:55:44AM -0700, Stephen Warren wrote: >>> On 03/04/2013 12:55 AM, Venu Byravarasu wrote: Stephen Warren wrote at Thursday, February 28, 2013

RE: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-04-02 Thread Venu Byravarasu
ject: Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init > > On Mon, Mar 04, 2013 at 09:55:44AM -0700, Stephen Warren wrote: > > On 03/04/2013 12:55 AM, Venu Byravarasu wrote: > > > Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: > >

RE: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-04-02 Thread Venu Byravarasu
: tegra: Reset Tegra USB controller before init On Mon, Mar 04, 2013 at 09:55:44AM -0700, Stephen Warren wrote: On 03/04/2013 12:55 AM, Venu Byravarasu wrote: Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: On 02/27/2013 11:36 PM, Venu Byravarasu wrote: To clear any

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-04-02 Thread Stephen Warren
On 04/02/2013 01:12 AM, Venu Byravarasu wrote: gre...@linuxfoundation.org wrote at Tuesday, March 05, 2013 6:04 AM: On Mon, Mar 04, 2013 at 09:55:44AM -0700, Stephen Warren wrote: On 03/04/2013 12:55 AM, Venu Byravarasu wrote: Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: On

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-03-04 Thread gre...@linuxfoundation.org
On Mon, Mar 04, 2013 at 09:55:44AM -0700, Stephen Warren wrote: > On 03/04/2013 12:55 AM, Venu Byravarasu wrote: > > Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: > >> On 02/27/2013 11:36 PM, Venu Byravarasu wrote: > >>> To clear any configurations made by U-Boot on Tegra USB

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-03-04 Thread Alan Stern
On Mon, 4 Mar 2013, Stephen Warren wrote: > On 03/04/2013 12:55 AM, Venu Byravarasu wrote: > > Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: > >> On 02/27/2013 11:36 PM, Venu Byravarasu wrote: > >>> To clear any configurations made by U-Boot on Tegra USB controller, > >>> reset it

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-03-04 Thread Stephen Warren
On 03/04/2013 12:55 AM, Venu Byravarasu wrote: > Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: >> On 02/27/2013 11:36 PM, Venu Byravarasu wrote: >>> To clear any configurations made by U-Boot on Tegra USB controller, >>> reset it before init in probe. >> >>> diff --git

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-03-04 Thread Stephen Warren
On 03/04/2013 12:55 AM, Venu Byravarasu wrote: Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: On 02/27/2013 11:36 PM, Venu Byravarasu wrote: To clear any configurations made by U-Boot on Tegra USB controller, reset it before init in probe. diff --git

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-03-04 Thread Alan Stern
On Mon, 4 Mar 2013, Stephen Warren wrote: On 03/04/2013 12:55 AM, Venu Byravarasu wrote: Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: On 02/27/2013 11:36 PM, Venu Byravarasu wrote: To clear any configurations made by U-Boot on Tegra USB controller, reset it before init

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-03-04 Thread gre...@linuxfoundation.org
On Mon, Mar 04, 2013 at 09:55:44AM -0700, Stephen Warren wrote: On 03/04/2013 12:55 AM, Venu Byravarasu wrote: Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: On 02/27/2013 11:36 PM, Venu Byravarasu wrote: To clear any configurations made by U-Boot on Tegra USB controller,

RE: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-03-03 Thread Venu Byravarasu
ject: Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init > > On 02/27/2013 11:36 PM, Venu Byravarasu wrote: > > To clear any configurations made by U-Boot on Tegra USB controller, > > reset it before init in probe. > > > diff --git a/drivers/usb/h

RE: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-03-03 Thread Venu Byravarasu
: tegra: Reset Tegra USB controller before init On 02/27/2013 11:36 PM, Venu Byravarasu wrote: To clear any configurations made by U-Boot on Tegra USB controller, reset it before init in probe. diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c @@ -691,6 +692,10

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Stephen Warren
On 02/28/2013 11:52 AM, Alan Stern wrote: > On Thu, 28 Feb 2013, Stephen Warren wrote: > >> I think this patch might cause unintended consequences. >> >> When the Tegra PHY code is converted to a driver (i.e. has its own >> probe), the initial order of execution of the PHY and EHCI driver probes

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Alan Stern
On Thu, 28 Feb 2013, Stephen Warren wrote: > I think this patch might cause unintended consequences. > > When the Tegra PHY code is converted to a driver (i.e. has its own > probe), the initial order of execution of the PHY and EHCI driver probes > will not be guaranteed. > > In particular,

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Stephen Warren
On 02/27/2013 11:36 PM, Venu Byravarasu wrote: > To clear any configurations made by U-Boot on Tegra USB controller, > reset it before init in probe. > diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c > @@ -691,6 +692,10 @@ static int tegra_ehci_probe(struct

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Stephen Warren
On 02/28/2013 08:09 AM, Alan Stern wrote: > On Thu, 28 Feb 2013, Venu Byravarasu wrote: > >> To clear any configurations made by U-Boot on Tegra USB controller, >> reset it before init in probe. >> >> Signed-off-by: Venu Byravarasu >> --- >> When U-Boot configures a Tegra USB controller in

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Alan Stern
On Thu, 28 Feb 2013, Venu Byravarasu wrote: > To clear any configurations made by U-Boot on Tegra USB controller, > reset it before init in probe. > > Signed-off-by: Venu Byravarasu > --- > When U-Boot configures a Tegra USB controller in device mode and if the EHCI > driver of kernel tries to

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Alan Stern
On Thu, 28 Feb 2013, Venu Byravarasu wrote: To clear any configurations made by U-Boot on Tegra USB controller, reset it before init in probe. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com --- When U-Boot configures a Tegra USB controller in device mode and if the EHCI driver of

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Stephen Warren
On 02/28/2013 08:09 AM, Alan Stern wrote: On Thu, 28 Feb 2013, Venu Byravarasu wrote: To clear any configurations made by U-Boot on Tegra USB controller, reset it before init in probe. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com --- When U-Boot configures a Tegra USB controller

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Stephen Warren
On 02/27/2013 11:36 PM, Venu Byravarasu wrote: To clear any configurations made by U-Boot on Tegra USB controller, reset it before init in probe. diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c @@ -691,6 +692,10 @@ static int tegra_ehci_probe(struct platform_device

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Alan Stern
On Thu, 28 Feb 2013, Stephen Warren wrote: I think this patch might cause unintended consequences. When the Tegra PHY code is converted to a driver (i.e. has its own probe), the initial order of execution of the PHY and EHCI driver probes will not be guaranteed. In particular, since the

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Stephen Warren
On 02/28/2013 11:52 AM, Alan Stern wrote: On Thu, 28 Feb 2013, Stephen Warren wrote: I think this patch might cause unintended consequences. When the Tegra PHY code is converted to a driver (i.e. has its own probe), the initial order of execution of the PHY and EHCI driver probes will not