Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Wei Liu
On Thu, Feb 28, 2019 at 12:07:07PM +, Paul Durrant wrote: > Yes, I meant kfree_skb(nskb). > In that case I think your patch looks fine. Wei.

RE: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Paul Durrant
y 2019 11:02 > > To: Paul Durrant > > Cc: Igor Druzhinin ; > > xen-de...@lists.xenproject.org; > > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Wei Liu > > ; > > da...@davemloft.net > > Subject: Re: [PATCH] xen-netback: fix occasional leak of g

RE: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Paul Durrant
Subject: Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings > under memory pressure > > On 28/02/2019 11:21, Paul Durrant wrote: > >>> @@ -1153,6 +1152,10 @@ static int xenvif_tx_submit(struct xenvif_queue > >>> *q

Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Igor Druzhinin
On 28/02/2019 11:21, Paul Durrant wrote: >>> @@ -1153,6 +1152,10 @@ static int xenvif_tx_submit(struct xenvif_queue >>> *queue) >>> kfree_skb(skb); >>> continue; >>> } >>> + >>> + /*

RE: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Paul Durrant
t.net > Subject: Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings > under memory pressure > > On Thu, Feb 28, 2019 at 09:46:57AM +, Paul Durrant wrote: > > > -Original Message- > > > From: Igor Druzhinin [mailto:igor.druzhi...@citrix

Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Wei Liu
On Thu, Feb 28, 2019 at 09:46:57AM +, Paul Durrant wrote: > > -Original Message- > > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > > Sent: 28 February 2019 02:03 > > To: xen-de...@lists.xenproject.org; net...@vger.kernel.org; > > linux-kernel@vger.kernel.org > > Cc: Wei

RE: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 28 February 2019 02:03 > To: xen-de...@lists.xenproject.org; net...@vger.kernel.org; > linux-kernel@vger.kernel.org > Cc: Wei Liu ; Paul Durrant ; > da...@davemloft.net; Igor > Druzhinin > Subject: