RE: [PATCH ] tbfadt.c: output warning only when 64bit 32bit address of FACS/DSDT all have value but not equal to each other

2012-11-15 Thread Moore, Robert
an.ker...@gmail.com] > Sent: Thursday, November 15, 2012 9:47 PM > To: Moore, Robert > Cc: LKML > Subject: Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit > address of FACS/DSDT all have value but not equal to each other > > Bob, > How about moving some ch

Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit address of FACS/DSDT all have value but not equal to each other

2012-11-15 Thread Ethan Zhao
l investigating > > >> -Original Message- >> From: Ethan Zhao [mailto:ethan.ker...@gmail.com] >> Sent: Thursday, November 15, 2012 7:47 PM >> To: Moore, Robert >> Subject: Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit >> address of FA

RE: [PATCH ] tbfadt.c: output warning only when 64bit 32bit address of FACS/DSDT all have value but not equal to each other

2012-11-15 Thread Moore, Robert
Ethan Zhao [mailto:ethan.ker...@gmail.com] > Sent: Thursday, November 15, 2012 6:29 PM > To: Moore, Robert > Cc: Brown, Len; Zheng, Lv; LKML > Subject: Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit > address of FACS/DSDT all have value but not equal to each other > &g

Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit address of FACS/DSDT all have value but not equal to each other

2012-11-15 Thread Ethan Zhao
Bob, Thanks for your detailed reviewing about the whole possible conditions. I.C. So that is impossible zero value for Xfacs /Xdsdt if facs/dsdt >0, for they are assigned in acpi_tb_convert_fadt(), I need to move my eyes one line code higher to see why it yelled twice but not using

RE: [PATCH ] tbfadt.c: output warning only when 64bit 32bit address of FACS/DSDT all have value but not equal to each other

2012-11-13 Thread Moore, Robert
Ethan, Does this actually solve a problem that you have seen? I ask because of the code that converts the FADT to the common internal format: acpi_tb_convert_fadt ( ... /* * Expand the 32-bit FACS and DSDT addresses to 64-bit as necessary. * Later code will always use t