RE: [PATCH 03/13] ACPI/IPMI: Fix race caused by the unprotected ACPI IPMI transfers

2013-07-25 Thread Zheng, Lv
> From: Corey Minyard [mailto:tcminy...@gmail.com] > Sent: Friday, July 26, 2013 8:48 AM > > On 07/25/2013 07:16 PM, Zheng, Lv wrote: > >> > >> If I understand this correctly, the problem would be if: > >> > >> rem_time = wait_for_completion_timeout(&tx_msg->tx_complete, > >>

Re: [PATCH 03/13] ACPI/IPMI: Fix race caused by the unprotected ACPI IPMI transfers

2013-07-25 Thread Corey Minyard
On 07/25/2013 07:16 PM, Zheng, Lv wrote: If I understand this correctly, the problem would be if: rem_time = wait_for_completion_timeout(&tx_msg->tx_complete, IPMI_TIMEOUT); returns on a timeout, then checks msg_done and races with something setting ms

RE: [PATCH 03/13] ACPI/IPMI: Fix race caused by the unprotected ACPI IPMI transfers

2013-07-25 Thread Zheng, Lv
> From: linux-acpi-ow...@vger.kernel.org > [mailto:linux-acpi-ow...@vger.kernel.org] On Behalf Of Rafael J. Wysocki > Sent: Friday, July 26, 2013 3:33 AM > > On Thursday, July 25, 2013 01:12:38 PM Corey Minyard wrote: > > On 07/25/2013 07:06 AM, Rafael J. Wysocki wrote: > > > On Thursday, July 25,

RE: [PATCH 03/13] ACPI/IPMI: Fix race caused by the unprotected ACPI IPMI transfers

2013-07-25 Thread Zheng, Lv
> From: Corey Minyard [mailto:tcminy...@gmail.com] > Sent: Friday, July 26, 2013 2:13 AM > > On 07/25/2013 07:06 AM, Rafael J. Wysocki wrote: > > On Thursday, July 25, 2013 03:09:35 AM Zheng, Lv wrote: > >> -stable according to the previous conversation. > >> > >>> From: Rafael J. Wysocki [mailto:

RE: [PATCH 03/13] ACPI/IPMI: Fix race caused by the unprotected ACPI IPMI transfers

2013-07-25 Thread Zheng, Lv
> From: Rafael J. Wysocki [mailto:r...@sisk.pl] > Sent: Thursday, July 25, 2013 8:07 PM > > On Thursday, July 25, 2013 03:09:35 AM Zheng, Lv wrote: > > -stable according to the previous conversation. > > > > > From: Rafael J. Wysocki [mailto:r...@sisk.pl] > > > Sent: Thursday, July 25, 2013 7:38

Re: [PATCH 03/13] ACPI/IPMI: Fix race caused by the unprotected ACPI IPMI transfers

2013-07-25 Thread Rafael J. Wysocki
On Thursday, July 25, 2013 01:12:38 PM Corey Minyard wrote: > On 07/25/2013 07:06 AM, Rafael J. Wysocki wrote: > > On Thursday, July 25, 2013 03:09:35 AM Zheng, Lv wrote: > >> -stable according to the previous conversation. > >> > >>> From: Rafael J. Wysocki [mailto:r...@sisk.pl] > >>> Sent: Thursd

Re: [PATCH 03/13] ACPI/IPMI: Fix race caused by the unprotected ACPI IPMI transfers

2013-07-25 Thread Corey Minyard
On 07/25/2013 07:06 AM, Rafael J. Wysocki wrote: On Thursday, July 25, 2013 03:09:35 AM Zheng, Lv wrote: -stable according to the previous conversation. From: Rafael J. Wysocki [mailto:r...@sisk.pl] Sent: Thursday, July 25, 2013 7:38 AM On Tuesday, July 23, 2013 04:09:15 PM Lv Zheng wrote: T

Re: [PATCH 03/13] ACPI/IPMI: Fix race caused by the unprotected ACPI IPMI transfers

2013-07-25 Thread Rafael J. Wysocki
On Thursday, July 25, 2013 03:09:35 AM Zheng, Lv wrote: > -stable according to the previous conversation. > > > From: Rafael J. Wysocki [mailto:r...@sisk.pl] > > Sent: Thursday, July 25, 2013 7:38 AM > > > > On Tuesday, July 23, 2013 04:09:15 PM Lv Zheng wrote: > > > This patch fixes races caused

RE: [PATCH 03/13] ACPI/IPMI: Fix race caused by the unprotected ACPI IPMI transfers

2013-07-24 Thread Zheng, Lv
-stable according to the previous conversation. > From: Rafael J. Wysocki [mailto:r...@sisk.pl] > Sent: Thursday, July 25, 2013 7:38 AM > > On Tuesday, July 23, 2013 04:09:15 PM Lv Zheng wrote: > > This patch fixes races caused by unprotected ACPI IPMI transfers. > > > > We can see the following

Re: [PATCH 03/13] ACPI/IPMI: Fix race caused by the unprotected ACPI IPMI transfers

2013-07-24 Thread Rafael J. Wysocki
On Tuesday, July 23, 2013 04:09:15 PM Lv Zheng wrote: > This patch fixes races caused by unprotected ACPI IPMI transfers. > > We can see the following crashes may occur: > 1. There is no tx_msg_lock held for iterating tx_msg_list in >ipmi_flush_tx_msg() while it is parellel unlinked on failure