RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets

2016-05-20 Thread Hartley Sweeten
On Friday, May 20, 2016 9:31 AM, Ian Abbott wrote: > On 20/05/16 17:21, Hartley Sweeten wrote: >> Just an comment on your renaming. >> >> You also renamed the registers in the daqbook2000 driver in the >> _REG_ format. Personally I prefer the format to be >> __REG. That way a grep for _ will >>

RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets

2016-05-20 Thread Hartley Sweeten
On Friday, May 20, 2016 9:31 AM, Ian Abbott wrote: > On 20/05/16 17:21, Hartley Sweeten wrote: >> Just an comment on your renaming. >> >> You also renamed the registers in the daqbook2000 driver in the >> _REG_ format. Personally I prefer the format to be >> __REG. That way a grep for _ will >>

Re: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets

2016-05-20 Thread Ian Abbott
On 20/05/16 17:21, Hartley Sweeten wrote: On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: Rename the macros in "plx9080.h" that define the offsets of registers, following the pattern `PLX_REG_`, where `` is the register name from the PLX PCI 9080 Data Book. Add defines for the "Mailbox"

Re: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets

2016-05-20 Thread Ian Abbott
On 20/05/16 17:21, Hartley Sweeten wrote: On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: Rename the macros in "plx9080.h" that define the offsets of registers, following the pattern `PLX_REG_`, where `` is the register name from the PLX PCI 9080 Data Book. Add defines for the "Mailbox"

RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets

2016-05-20 Thread Hartley Sweeten
On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: > Rename the macros in "plx9080.h" that define the offsets of registers, > following the pattern `PLX_REG_`, where `` is the register > name from the PLX PCI 9080 Data Book. > > Add defines for the "Mailbox" registers, and add parameterized macros

RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets

2016-05-20 Thread Hartley Sweeten
On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: > Rename the macros in "plx9080.h" that define the offsets of registers, > following the pattern `PLX_REG_`, where `` is the register > name from the PLX PCI 9080 Data Book. > > Add defines for the "Mailbox" registers, and add parameterized macros