Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-30 Thread Wolfram Sang
> > > > The driver disables TX interrupt when it is not needed anymore or > > > > when TX gets aborted but the above will re-enable all interrupts > > regardless. > > > > Is that the intention? > > > No, i2c controller can trigger next interrupt only after re-enable all > > > interrupt. > > > >

Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-30 Thread Wolfram Sang
> > > > The driver disables TX interrupt when it is not needed anymore or > > > > when TX gets aborted but the above will re-enable all interrupts > > regardless. > > > > Is that the intention? > > > No, i2c controller can trigger next interrupt only after re-enable all > > > interrupt. > > > >

RE: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-06 Thread Yu, Xiangliang
er.kernel.org; Xue, Ken; Wan, Vincent; > Huang, Ray; Wang, Annie; Li, Tony > Subject: Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD > controller > > On 06.11.2015 06:34, Yu, Xiangliang wrote: > >> -Original Message- > >> From: Mika

Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-06 Thread Jarkko Nikula
On 06.11.2015 06:34, Yu, Xiangliang wrote: -Original Message- From: Mika Westerberg [mailto:mika.westerb...@linux.intel.com] --- a/drivers/i2c/busses/i2c-designware-core.c +++ b/drivers/i2c/busses/i2c-designware-core.c @@ -783,6 +783,9 @@ irqreturn_t i2c_dw_isr(int this_irq, void

RE: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-06 Thread Yu, Xiangliang
.org; linux- > ker...@vger.kernel.org; Xue, Ken; Wan, Vincent; Huang, Ray; Wang, Annie; > Li, Tony > Subject: Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD > controller > > On Fri, Nov 06, 2015 at 04:34:19AM +, Yu, Xiangliang wrote: > > > -Orig

RE: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-06 Thread Yu, Xiangliang
.org; linux- > ker...@vger.kernel.org; Xue, Ken; Wan, Vincent; Huang, Ray; Wang, Annie; > Li, Tony > Subject: Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD > controller > > On Fri, Nov 06, 2015 at 04:34:19AM +, Yu, Xiangliang wrote: > > > -Orig

Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-06 Thread Jarkko Nikula
On 06.11.2015 06:34, Yu, Xiangliang wrote: -Original Message- From: Mika Westerberg [mailto:mika.westerb...@linux.intel.com] --- a/drivers/i2c/busses/i2c-designware-core.c +++ b/drivers/i2c/busses/i2c-designware-core.c @@ -783,6 +783,9 @@ irqreturn_t i2c_dw_isr(int this_irq, void

RE: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-06 Thread Yu, Xiangliang
er.kernel.org; Xue, Ken; Wan, Vincent; > Huang, Ray; Wang, Annie; Li, Tony > Subject: Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD > controller > > On 06.11.2015 06:34, Yu, Xiangliang wrote: > >> -Original Message- > >> From: Mika

Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-05 Thread Mika Westerberg
..@linux.intel.com; jarkko.nik...@linux.intel.com; > > w...@the-dreams.de; linux-...@vger.kernel.org; linux- > > ker...@vger.kernel.org; Xue, Ken; Wan, Vincent; Huang, Ray; Wang, Annie; > > Li, Tony > > Subject: Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD > >

RE: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-05 Thread Yu, Xiangliang
.org; linux- > ker...@vger.kernel.org; Xue, Ken; Wan, Vincent; Huang, Ray; Wang, Annie; > Li, Tony > Subject: Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD > controller > > On Thu, Nov 05, 2015 at 08:34:44PM +0800, Xiangliang Yu wrote: > > Because of some har

Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-05 Thread Mika Westerberg
On Thu, Nov 05, 2015 at 08:34:44PM +0800, Xiangliang Yu wrote: > Because of some hardware limitation, AMD I2C controller can't > trigger next interrupt if interrupt status has been changed > after clearing interrupt status bits. Then, I2C will lost > interrupt and IO timeout. > > According to

RE: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-05 Thread Yu, Xiangliang
.org; linux- > ker...@vger.kernel.org; Xue, Ken; Wan, Vincent; Huang, Ray; Wang, Annie; > Li, Tony > Subject: Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD > controller > > On Thu, Nov 05, 2015 at 08:34:44PM +0800, Xiangliang Yu wrote: > > Because of some har

Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-05 Thread Mika Westerberg
..@linux.intel.com; jarkko.nik...@linux.intel.com; > > w...@the-dreams.de; linux-...@vger.kernel.org; linux- > > ker...@vger.kernel.org; Xue, Ken; Wan, Vincent; Huang, Ray; Wang, Annie; > > Li, Tony > > Subject: Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD > >

Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-05 Thread Mika Westerberg
On Thu, Nov 05, 2015 at 08:34:44PM +0800, Xiangliang Yu wrote: > Because of some hardware limitation, AMD I2C controller can't > trigger next interrupt if interrupt status has been changed > after clearing interrupt status bits. Then, I2C will lost > interrupt and IO timeout. > > According to