RE: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions in hwdrv_apci1564.c

2014-03-03 Thread Hartley Sweeten
On Saturday, March 01, 2014 3:28 AM, Chase Southwood wrote: > Subject: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* > helper functions in hwdrv_apci1564.c > > This patch introduces a handful of outl and inl helper functions with the > ultimate goal of improving code

RE: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions in hwdrv_apci1564.c

2014-03-03 Thread Hartley Sweeten
On Saturday, March 01, 2014 3:28 AM, Chase Southwood wrote: Subject: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions in hwdrv_apci1564.c This patch introduces a handful of outl and inl helper functions with the ultimate goal of improving code readability

Re: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions in hwdrv_apci1564.c

2014-03-01 Thread Chase Southwood
>On Saturday, March 1, 2014 6:18 PM, Chase Southwood > wrote: >Hi Dan, > [snip] > >I like this idea.  Just to clarify though, basically all of the macros would >change to something like  > >#define APCI1564_DIGITAL_IP 0x4 #define APCI1564_DIGITAL_IP_INTERRUPT_MODE1 >(0x4 + 0x4) >#define

Re: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions in hwdrv_apci1564.c

2014-03-01 Thread Chase Southwood
Hi Dan, >On Saturday, March 1, 2014 6:46 AM, Dan Carpenter >wrote: >>On Sat, Mar 01, 2014 at 04:28:27AM -0600, Chase Southwood wrote: >> This patch introduces a handful of outl and inl helper functions with the >> ultimate goal of improving code readability and allowing several lines >> which

Re: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions in hwdrv_apci1564.c

2014-03-01 Thread Dan Carpenter
On Sat, Mar 01, 2014 at 03:44:18PM +0300, Dan Carpenter wrote: > On Sat, Mar 01, 2014 at 04:28:27AM -0600, Chase Southwood wrote: > > This patch introduces a handful of outl and inl helper functions with the > > ultimate goal of improving code readability and allowing several lines > > which

Re: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions in hwdrv_apci1564.c

2014-03-01 Thread Dan Carpenter
On Sat, Mar 01, 2014 at 04:28:27AM -0600, Chase Southwood wrote: > This patch introduces a handful of outl and inl helper functions with the > ultimate goal of improving code readability and allowing several lines > which violate the character limit to be shortened in a sane way. > > Cc: Dan

Re: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions in hwdrv_apci1564.c

2014-03-01 Thread Dan Carpenter
On Sat, Mar 01, 2014 at 04:28:27AM -0600, Chase Southwood wrote: This patch introduces a handful of outl and inl helper functions with the ultimate goal of improving code readability and allowing several lines which violate the character limit to be shortened in a sane way. Cc: Dan Carpenter

Re: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions in hwdrv_apci1564.c

2014-03-01 Thread Dan Carpenter
On Sat, Mar 01, 2014 at 03:44:18PM +0300, Dan Carpenter wrote: On Sat, Mar 01, 2014 at 04:28:27AM -0600, Chase Southwood wrote: This patch introduces a handful of outl and inl helper functions with the ultimate goal of improving code readability and allowing several lines which violate the

Re: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions in hwdrv_apci1564.c

2014-03-01 Thread Chase Southwood
Hi Dan, On Saturday, March 1, 2014 6:46 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, Mar 01, 2014 at 04:28:27AM -0600, Chase Southwood wrote: This patch introduces a handful of outl and inl helper functions with the ultimate goal of improving code readability and allowing several

Re: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions in hwdrv_apci1564.c

2014-03-01 Thread Chase Southwood
On Saturday, March 1, 2014 6:18 PM, Chase Southwood chase.southw...@yahoo.com wrote: Hi Dan, [snip] I like this idea.  Just to clarify though, basically all of the macros would change to something like  #define APCI1564_DIGITAL_IP 0x4 #define APCI1564_DIGITAL_IP_INTERRUPT_MODE1 (0x4 + 0x4)