RE: [PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

2012-08-30 Thread Kim, Milo
Best Regards, Milo > -Original Message- > From: Devendra Naga [mailto:develkernel412...@gmail.com] > Sent: Friday, August 24, 2012 1:52 AM > To: Anton Vorontsov > Cc: David Woodhouse; linux-kernel@vger.kernel.org; Kim, Milo > Subject: Re: [PATCH 1/2] lp8727_char

RE: [PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

2012-08-30 Thread Kim, Milo
Best Regards, Milo -Original Message- From: Devendra Naga [mailto:develkernel412...@gmail.com] Sent: Friday, August 24, 2012 1:52 AM To: Anton Vorontsov Cc: David Woodhouse; linux-kernel@vger.kernel.org; Kim, Milo Subject: Re: [PATCH 1/2] lp8727_charger: free_irq when

Re: [PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

2012-08-23 Thread Devendra Naga
Hi Anton, On Mon, Aug 20, 2012 at 2:20 AM, Anton Vorontsov wrote: > On Fri, Aug 10, 2012 at 10:05:55AM +0530, Devendra wrote: >> Sorry Guys on disturbing you, >> >> Will you guys please ACK, NACK or comment on this? > > Technically, it looks OK. But the irq registration logic is sill broken, >

Re: [PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

2012-08-23 Thread Devendra Naga
Hi Anton, On Mon, Aug 20, 2012 at 2:20 AM, Anton Vorontsov cbouatmai...@gmail.com wrote: On Fri, Aug 10, 2012 at 10:05:55AM +0530, Devendra wrote: Sorry Guys on disturbing you, Will you guys please ACK, NACK or comment on this? Technically, it looks OK. But the irq registration logic is

Re: [PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

2012-08-19 Thread Anton Vorontsov
On Fri, Aug 10, 2012 at 10:05:55AM +0530, Devendra wrote: > Sorry Guys on disturbing you, > > Will you guys please ACK, NACK or comment on this? Technically, it looks OK. But the irq registration logic is sill broken, and the hidden issue is much more serious. 1. lp8727_init_device() -> the

Re: [PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

2012-08-19 Thread Devendra
Sorry Guys on disturbing you, Will you guys please ACK, NACK or comment on this? Thanks, On Sun, 2012-07-29 at 23:31 +0545, Devendra Naga wrote: > actually the driver does a request_threaded_irq and after this it calls > lp8727_register_psy, and if it fails it doesn't free the irqs that it >

Re: [PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

2012-08-19 Thread Devendra
Sorry Guys on disturbing you, Will you guys please ACK, NACK or comment on this? Thanks, On Sun, 2012-07-29 at 23:31 +0545, Devendra Naga wrote: actually the driver does a request_threaded_irq and after this it calls lp8727_register_psy, and if it fails it doesn't free the irqs that it

Re: [PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

2012-08-19 Thread Anton Vorontsov
On Fri, Aug 10, 2012 at 10:05:55AM +0530, Devendra wrote: Sorry Guys on disturbing you, Will you guys please ACK, NACK or comment on this? Technically, it looks OK. But the irq registration logic is sill broken, and the hidden issue is much more serious. 1. lp8727_init_device() - the

Re: [PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

2012-08-09 Thread Devendra Naga
Sorry to ask this again, But will anybody please ACK , NACK or comment on this patch? Thanks, Devendra. On Sun, Jul 29, 2012 at 11:16 PM, Devendra Naga wrote: > actually the driver does a request_threaded_irq and after this it calls > lp8727_register_psy, and if it fails it doesn't free the

Re: [PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

2012-08-09 Thread Devendra Naga
Sorry to ask this again, But will anybody please ACK , NACK or comment on this patch? Thanks, Devendra. On Sun, Jul 29, 2012 at 11:16 PM, Devendra Naga develkernel412...@gmail.com wrote: actually the driver does a request_threaded_irq and after this it calls lp8727_register_psy, and if it