Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-26 Thread Grant Grundler
On Fri, May 25, 2007 at 01:16:57PM -0700, Jonathan Lundell wrote: > On May 24, 2007, at 10:51 PM, Andi Kleen wrote: > > >>Do we have a feel for how much performace we're losing on those > >>systems which _could_ do MSI, but which will end up defaulting > >>to not using it? > > > >At least on 10GB

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-26 Thread Grant Grundler
On Fri, May 25, 2007 at 01:35:01PM -0700, Greg KH wrote: ... > And again, over time, like years, this list is going to grow way beyond > a managable thing, especially as any new chipset that comes out in 2009 > is going to have working MSI, right? I think our blacklist is easier to > manage over

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-26 Thread Grant Grundler
On Fri, May 25, 2007 at 01:35:01PM -0700, Greg KH wrote: ... And again, over time, like years, this list is going to grow way beyond a managable thing, especially as any new chipset that comes out in 2009 is going to have working MSI, right? I think our blacklist is easier to manage over

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-26 Thread Grant Grundler
On Fri, May 25, 2007 at 01:16:57PM -0700, Jonathan Lundell wrote: On May 24, 2007, at 10:51 PM, Andi Kleen wrote: Do we have a feel for how much performace we're losing on those systems which _could_ do MSI, but which will end up defaulting to not using it? At least on 10GB ethernet it is

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Brice Goglin
Eric W. Biederman wrote: > @@ -1677,43 +1650,16 @@ static int __devinit msi_ht_cap_enabled(struct > pci_dev *dev) > return 0; > } > > -/* Check the hypertransport MSI mapping to know whether MSI is enabled or > not */ > +/* Enable MSI on hypertransport chipsets supporting MSI */ >

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Greg KH
On Fri, May 25, 2007 at 03:06:22PM -0600, Eric W. Biederman wrote: > Greg KH <[EMAIL PROTECTED]> writes: > > It's a trade off, and I'd like to choose the one that over the long > > term, causes the least ammount of work and maintaiblity. I think the > > current blacklist meets that goal. > > A

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Roland Dreier
> I think for most of Intel I can reduce my test to: > If (bus == 0 , device == 0, function == 0 && vendor == Intel && > has a pci express capability) { > Enable msi on all busses(). > } MSI was working on every Intel PCI-X chipset I ever saw too... - R. - To unsubscribe from this

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Eric W. Biederman
Greg KH <[EMAIL PROTECTED]> writes: >> MSI appears to have enough problems that enabling it in a kernel >> that is supposed to run lots of different hardware (like a distro >> kernel) is a recipe for disaster. > > Oh, I agree it's a major pain in the ass at times... > > But I'm real hesitant to

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Roland Dreier
> > In addition to PCI INTx compatible interrupt emulation, PCI Express > > requires support of MSI or MSI-X or both. > Which suggests that INTx support is required. > > I do not find any wording that suggest the opposite. > I do see it stated that it is intended to EOL support for INTx at

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Greg KH
On Fri, May 25, 2007 at 09:17:35AM -0600, Eric W. Biederman wrote: > Greg KH <[EMAIL PROTECTED]> writes: > > > Originally I would have thought this would be a good idea, but now that > > Vista is out, which supports MSI, I don't think we are going to need > > this in the future. All new chipsets

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Jonathan Lundell
On May 24, 2007, at 10:51 PM, Andi Kleen wrote: Do we have a feel for how much performace we're losing on those systems which _could_ do MSI, but which will end up defaulting to not using it? At least on 10GB ethernet it is a significant difference; you usually cannot go anywhere near line

RE: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread David Schwartz
> Hmm... > I find in section 6.1: > > In addition to PCI INTx compatible interrupt emulation, PCI Express > > requires support of MSI or MSI-X or both. > Which suggests that INTx support is required. Unfortunately, this can be equally well read to suggest that MSI/MSI-X is not required, but

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Eric W. Biederman
Roland Dreier <[EMAIL PROTECTED]> writes: > > > - In spec hardware does not require MSI to generate interrupts > > > Which leaves enabling MSI optional. > > > > Actually at least the Qlogic/Pathscale PCI Express ipath adapters > > cannot generate INTx interrupts -- they definitely do

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Roland Dreier
> > - In spec hardware does not require MSI to generate interrupts > > Which leaves enabling MSI optional. > > Actually at least the Qlogic/Pathscale PCI Express ipath adapters > cannot generate INTx interrupts -- they definitely do require MSI to > operate. Oh yeah... when I first

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Roland Dreier
> - In spec hardware does not require MSI to generate interrupts > Which leaves enabling MSI optional. Actually at least the Qlogic/Pathscale PCI Express ipath adapters cannot generate INTx interrupts -- they definitely do require MSI to operate. - R. - To unsubscribe from this list: send

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Chuck Ebbert
On 05/25/2007 11:17 AM, Eric W. Biederman wrote: > > MSI appears to have enough problems that enabling it in a kernel > that is supposed to run lots of different hardware (like a distro > kernel) is a recipe for disaster. Ubuntu and Fedora have disabled it and added a "pci=msi" option to enable

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Eric W. Biederman
Greg KH <[EMAIL PROTECTED]> writes: > Originally I would have thought this would be a good idea, but now that > Vista is out, which supports MSI, I don't think we are going to need > this in the future. All new chipsets should support MSI fine and this > table will only grow in the future, while

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread David Miller
From: Michael Ellerman <[EMAIL PROTECTED]> Date: Fri, 25 May 2007 15:14:10 +1000 > On Thu, 2007-05-24 at 22:19 -0600, Eric W. Biederman wrote: > > Currently we blacklist known bad msi configurations which means we > > keep getting MSI enabled on chipsets that either do not support MSI, > > or MSI

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Eric W. Biederman
Michael Ellerman <[EMAIL PROTECTED]> writes: > On Thu, 2007-05-24 at 22:19 -0600, Eric W. Biederman wrote: >> Currently we blacklist known bad msi configurations which means we >> keep getting MSI enabled on chipsets that either do not support MSI, >> or MSI is implemented improperly. Since the

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: On Thu, 2007-05-24 at 22:19 -0600, Eric W. Biederman wrote: Currently we blacklist known bad msi configurations which means we keep getting MSI enabled on chipsets that either do not support MSI, or MSI is implemented improperly. Since the normal

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread David Miller
From: Michael Ellerman [EMAIL PROTECTED] Date: Fri, 25 May 2007 15:14:10 +1000 On Thu, 2007-05-24 at 22:19 -0600, Eric W. Biederman wrote: Currently we blacklist known bad msi configurations which means we keep getting MSI enabled on chipsets that either do not support MSI, or MSI is

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Eric W. Biederman
Greg KH [EMAIL PROTECTED] writes: Originally I would have thought this would be a good idea, but now that Vista is out, which supports MSI, I don't think we are going to need this in the future. All new chipsets should support MSI fine and this table will only grow in the future, while the

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Chuck Ebbert
On 05/25/2007 11:17 AM, Eric W. Biederman wrote: MSI appears to have enough problems that enabling it in a kernel that is supposed to run lots of different hardware (like a distro kernel) is a recipe for disaster. Ubuntu and Fedora have disabled it and added a pci=msi option to enable it if

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Roland Dreier
- In spec hardware does not require MSI to generate interrupts Which leaves enabling MSI optional. Actually at least the Qlogic/Pathscale PCI Express ipath adapters cannot generate INTx interrupts -- they definitely do require MSI to operate. - R. - To unsubscribe from this list: send the

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Roland Dreier
- In spec hardware does not require MSI to generate interrupts Which leaves enabling MSI optional. Actually at least the Qlogic/Pathscale PCI Express ipath adapters cannot generate INTx interrupts -- they definitely do require MSI to operate. Oh yeah... when I first found out

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Eric W. Biederman
Roland Dreier [EMAIL PROTECTED] writes: - In spec hardware does not require MSI to generate interrupts Which leaves enabling MSI optional. Actually at least the Qlogic/Pathscale PCI Express ipath adapters cannot generate INTx interrupts -- they definitely do require MSI to

RE: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread David Schwartz
Hmm... I find in section 6.1: In addition to PCI INTx compatible interrupt emulation, PCI Express requires support of MSI or MSI-X or both. Which suggests that INTx support is required. Unfortunately, this can be equally well read to suggest that MSI/MSI-X is not required, but that

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Jonathan Lundell
On May 24, 2007, at 10:51 PM, Andi Kleen wrote: Do we have a feel for how much performace we're losing on those systems which _could_ do MSI, but which will end up defaulting to not using it? At least on 10GB ethernet it is a significant difference; you usually cannot go anywhere near line

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Greg KH
On Fri, May 25, 2007 at 09:17:35AM -0600, Eric W. Biederman wrote: Greg KH [EMAIL PROTECTED] writes: Originally I would have thought this would be a good idea, but now that Vista is out, which supports MSI, I don't think we are going to need this in the future. All new chipsets should

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Roland Dreier
In addition to PCI INTx compatible interrupt emulation, PCI Express requires support of MSI or MSI-X or both. Which suggests that INTx support is required. I do not find any wording that suggest the opposite. I do see it stated that it is intended to EOL support for INTx at some

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Eric W. Biederman
Greg KH [EMAIL PROTECTED] writes: MSI appears to have enough problems that enabling it in a kernel that is supposed to run lots of different hardware (like a distro kernel) is a recipe for disaster. Oh, I agree it's a major pain in the ass at times... But I'm real hesitant to change things

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Roland Dreier
I think for most of Intel I can reduce my test to: If (bus == 0 , device == 0, function == 0 vendor == Intel has a pci express capability) { Enable msi on all busses(). } MSI was working on every Intel PCI-X chipset I ever saw too... - R. - To unsubscribe from this list:

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Greg KH
On Fri, May 25, 2007 at 03:06:22PM -0600, Eric W. Biederman wrote: Greg KH [EMAIL PROTECTED] writes: It's a trade off, and I'd like to choose the one that over the long term, causes the least ammount of work and maintaiblity. I think the current blacklist meets that goal. A reasonable

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Brice Goglin
Eric W. Biederman wrote: @@ -1677,43 +1650,16 @@ static int __devinit msi_ht_cap_enabled(struct pci_dev *dev) return 0; } -/* Check the hypertransport MSI mapping to know whether MSI is enabled or not */ +/* Enable MSI on hypertransport chipsets supporting MSI */ static void

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Eric W. Biederman
Greg KH <[EMAIL PROTECTED]> writes: > On Thu, May 24, 2007 at 10:19:09PM -0600, Eric W. Biederman wrote: >> >> Currently we blacklist known bad msi configurations which means we >> keep getting MSI enabled on chipsets that either do not support MSI, >> or MSI is implemented improperly. Since

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Andi Kleen
> Do we have a feel for how much performace we're losing on those > systems which _could_ do MSI, but which will end up defaulting > to not using it? At least on 10GB ethernet it is a significant difference; you usually cannot go anywhere near line speed without MSI I suspect it is visible on

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Grant Grundler
On Thu, May 24, 2007 at 09:31:57PM -0700, Andrew Morton wrote: > On Thu, 24 May 2007 22:19:09 -0600 [EMAIL PROTECTED] (Eric W. Biederman) > wrote: > > > Currently we blacklist known bad msi configurations which means we > > keep getting MSI enabled on chipsets that either do not support MSI, > >

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Eric W. Biederman
Andrew Morton <[EMAIL PROTECTED]> writes: > On Thu, 24 May 2007 22:19:09 -0600 [EMAIL PROTECTED] (Eric W. Biederman) > wrote: > >> Currently we blacklist known bad msi configurations which means we >> keep getting MSI enabled on chipsets that either do not support MSI, >> or MSI is implemented

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Greg KH
On Thu, May 24, 2007 at 10:19:09PM -0600, Eric W. Biederman wrote: > > Currently we blacklist known bad msi configurations which means we > keep getting MSI enabled on chipsets that either do not support MSI, > or MSI is implemented improperly. Since the normal IRQ routing > mechanism seems to

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Michael Ellerman
On Thu, 2007-05-24 at 22:19 -0600, Eric W. Biederman wrote: > Currently we blacklist known bad msi configurations which means we > keep getting MSI enabled on chipsets that either do not support MSI, > or MSI is implemented improperly. Since the normal IRQ routing > mechanism seems to works even

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Andrew Morton
On Thu, 24 May 2007 22:19:09 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: > Currently we blacklist known bad msi configurations which means we > keep getting MSI enabled on chipsets that either do not support MSI, > or MSI is implemented improperly. Since the normal IRQ routing > mechanism

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Andrew Morton
On Thu, 24 May 2007 22:19:09 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: Currently we blacklist known bad msi configurations which means we keep getting MSI enabled on chipsets that either do not support MSI, or MSI is implemented improperly. Since the normal IRQ routing mechanism

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Michael Ellerman
On Thu, 2007-05-24 at 22:19 -0600, Eric W. Biederman wrote: Currently we blacklist known bad msi configurations which means we keep getting MSI enabled on chipsets that either do not support MSI, or MSI is implemented improperly. Since the normal IRQ routing mechanism seems to works even when

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Greg KH
On Thu, May 24, 2007 at 10:19:09PM -0600, Eric W. Biederman wrote: Currently we blacklist known bad msi configurations which means we keep getting MSI enabled on chipsets that either do not support MSI, or MSI is implemented improperly. Since the normal IRQ routing mechanism seems to works

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Eric W. Biederman
Andrew Morton [EMAIL PROTECTED] writes: On Thu, 24 May 2007 22:19:09 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: Currently we blacklist known bad msi configurations which means we keep getting MSI enabled on chipsets that either do not support MSI, or MSI is implemented improperly.

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Grant Grundler
On Thu, May 24, 2007 at 09:31:57PM -0700, Andrew Morton wrote: On Thu, 24 May 2007 22:19:09 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: Currently we blacklist known bad msi configurations which means we keep getting MSI enabled on chipsets that either do not support MSI, or MSI

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Andi Kleen
Do we have a feel for how much performace we're losing on those systems which _could_ do MSI, but which will end up defaulting to not using it? At least on 10GB ethernet it is a significant difference; you usually cannot go anywhere near line speed without MSI I suspect it is visible on

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-24 Thread Eric W. Biederman
Greg KH [EMAIL PROTECTED] writes: On Thu, May 24, 2007 at 10:19:09PM -0600, Eric W. Biederman wrote: Currently we blacklist known bad msi configurations which means we keep getting MSI enabled on chipsets that either do not support MSI, or MSI is implemented improperly. Since the normal