RE: [PATCH 1/4] ACPICA: Add to remove mis-ordered inclusion of from .

2014-04-22 Thread Zheng, Lv
Hi, Rafael > From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] > Sent: Tuesday, April 22, 2014 7:16 PM > > On Tuesday, April 22, 2014 02:01:57 AM Zheng, Lv wrote: > > Hi, > > > > > > > > > > +#define ACPI_NATIVE_INTERFACE_HEADER > > > > > > This is not good. > > > > > > We don't do things

Re: [PATCH 1/4] ACPICA: Add to remove mis-ordered inclusion of from .

2014-04-22 Thread Rafael J. Wysocki
On Tuesday, April 22, 2014 02:01:57 AM Zheng, Lv wrote: > Hi, > > > > > > +#define ACPI_NATIVE_INTERFACE_HEADER > > > > This is not good. > > > > We don't do things like this in the kernel, because they are confusing and > > hard > > to debug if necessary, so please find a different way

RE: [PATCH 1/4] ACPICA: Add to remove mis-ordered inclusion of from .

2014-04-21 Thread Zheng, Lv
Hi, > > +#define ACPI_NATIVE_INTERFACE_HEADER > > This is not good. > > We don't do things like this in the kernel, because they are confusing and > hard > to debug if necessary, so please find a different way to make this work. I use this extra header file to collect: 1. static

Re: [PATCH 1/4] ACPICA: Add to remove mis-ordered inclusion of from .

2014-04-21 Thread Rafael J. Wysocki
On Tuesday, April 08, 2014 03:56:44 PM Lv Zheng wrote: > From ACPICA's perspective, should be included after > inclusion of . But currently in Linux, > included by has > included to find ACPICA types for inline functions. > > This causes the following problem: > 1. Redundant code in and : >