RE: [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information leaks

2019-08-22 Thread Dragan Cvetic
Hi Dan, > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Wednesday 21 August 2019 08:06 > To: Derek Kiernan ; Dragan Cvetic > Cc: Arnd Bergmann ; Greg Kroah-Hartman > ; Michal Simek ; > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org

Re: [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information leaks

2019-08-22 Thread Michal Simek
On 22. 08. 19 10:28, Dan Carpenter wrote: > On Thu, Aug 22, 2019 at 10:14:12AM +0200, Michal Simek wrote: >> Hi Dan, >> >> On 21. 08. 19 9:06, Dan Carpenter wrote: >>> These structs have holes in them so we end up disclosing a few bytes of >>> uninitialized stack data. >>> >>> drivers/misc/xilinx_s

Re: [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information leaks

2019-08-22 Thread Dan Carpenter
On Thu, Aug 22, 2019 at 10:14:12AM +0200, Michal Simek wrote: > Hi Dan, > > On 21. 08. 19 9:06, Dan Carpenter wrote: > > These structs have holes in them so we end up disclosing a few bytes of > > uninitialized stack data. > > > > drivers/misc/xilinx_sdfec.c:305 xsdfec_get_status() warn: check th

Re: [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information leaks

2019-08-22 Thread Michal Simek
Hi Dan, On 21. 08. 19 9:06, Dan Carpenter wrote: > These structs have holes in them so we end up disclosing a few bytes of > uninitialized stack data. > > drivers/misc/xilinx_sdfec.c:305 xsdfec_get_status() warn: check that 'status' > doesn't leak information (struct has a hole after 'activity')