Re: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-04 Thread Boaz Harrosh
On 11/04/2014 06:41 PM, Ross Zwisler wrote: <> > > The UEFI organization is in the process of defining a generic specification > for platform non-volatile memory resources. Essentially the thought was to > wait until that was publicly available before adding any new device discovery >

Re: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-04 Thread Ross Zwisler
oss > > Zwisler; Jens Axboe; Nick Piggin; Kani, Toshimitsu; Knippers, Linda; > > linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > > nvd...@lists.01.org; Matthew Wilcox > > Subject: Re: [PATCH 1/4] pmem: Initial version of persistent memory > > driver

RE: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-04 Thread Elliott, Robert (Server Storage)
.kernel.org; linux-kernel@vger.kernel.org; linux- > nvd...@lists.01.org; Matthew Wilcox > Subject: Re: [PATCH 1/4] pmem: Initial version of persistent memory > driver > > On 11/03/2014 06:19 PM, Wilcox, Matthew R wrote: ... > > I wish you guys would actually review the corre

Re: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-04 Thread Boaz Harrosh
On 11/03/2014 06:19 PM, Wilcox, Matthew R wrote: <> >>> +config BLK_DEV_PMEM_COUNT >>> + int "Default number of PMEM disks" >>> + default "4" >> >> For real use I think a default of 1 would be better. > > For real use, you need at least two to run xfstests. This whole > configuration

Re: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-04 Thread Boaz Harrosh
On 11/03/2014 06:19 PM, Wilcox, Matthew R wrote: +config BLK_DEV_PMEM_COUNT + int Default number of PMEM disks + default 4 For real use I think a default of 1 would be better. For real use, you need at least two to run xfstests. This whole configuration mechanism is going away soon

RE: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-04 Thread Elliott, Robert (Server Storage)
@vger.kernel.org; linux- nvd...@lists.01.org; Matthew Wilcox Subject: Re: [PATCH 1/4] pmem: Initial version of persistent memory driver On 11/03/2014 06:19 PM, Wilcox, Matthew R wrote: ... I wish you guys would actually review the correct code. In the actual good driver that has any shape

Re: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-04 Thread Ross Zwisler
; Kani, Toshimitsu; Knippers, Linda; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- nvd...@lists.01.org; Matthew Wilcox Subject: Re: [PATCH 1/4] pmem: Initial version of persistent memory driver On 11/03/2014 06:19 PM, Wilcox, Matthew R wrote: ... I wish you

Re: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-04 Thread Boaz Harrosh
On 11/04/2014 06:41 PM, Ross Zwisler wrote: The UEFI organization is in the process of defining a generic specification for platform non-volatile memory resources. Essentially the thought was to wait until that was publicly available before adding any new device discovery capabilities to

RE: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-03 Thread Wilcox, Matthew R
I really wish people wouldn't use my Exchange email address for patches. It's completely impossible to have a meaningful conversation this way. I've resorted to inserting extra quotation marks by hand so people can stand at least some chance of understanding what the hell's going on. > >

Re: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-03 Thread Jeff Moyer
"Elliott, Robert (Server Storage)" writes: >> +config BLK_DEV_PMEM_COUNT >> +int "Default number of PMEM disks" >> +default "4" > > For real use I think a default of 1 would be better. For "real" use, it will be the number of actual DIMMs, not a config option, I would think. I don't

Re: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-03 Thread Jeff Moyer
Elliott, Robert (Server Storage) elli...@hp.com writes: +config BLK_DEV_PMEM_COUNT +int Default number of PMEM disks +default 4 For real use I think a default of 1 would be better. For real use, it will be the number of actual DIMMs, not a config option, I would think. I don't take

RE: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-03 Thread Wilcox, Matthew R
I really wish people wouldn't use my Exchange email address for patches. It's completely impossible to have a meaningful conversation this way. I've resorted to inserting extra quotation marks by hand so people can stand at least some chance of understanding what the hell's going on.

RE: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-01 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Ross Zwisler > Sent: Wednesday, 27 August, 2014 4:12 PM > To: Jens Axboe; Matthew Wilcox; Boaz Harrosh; Nick Piggin; linux- > fsde...@vger.kernel.org;

RE: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-01 Thread Elliott, Robert (Server Storage)
-Original Message- From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- ow...@vger.kernel.org] On Behalf Of Ross Zwisler Sent: Wednesday, 27 August, 2014 4:12 PM To: Jens Axboe; Matthew Wilcox; Boaz Harrosh; Nick Piggin; linux- fsde...@vger.kernel.org;