Re: [PATCH 13/19 v2] staging: comedi: amplc_pci230: remove unnecessary braces

2014-07-30 Thread Greg Kroah-Hartman
On Wed, Jul 30, 2014 at 04:15:23PM +, Hartley Sweeten wrote: > On Wednesday, July 30, 2014 7:28 AM, Ian Abbott wrote: > > On 2014-07-30 15:09, Dan Carpenter wrote: > >> On Wed, Jul 30, 2014 at 03:04:03PM +0100, Ian Abbott wrote: > >>> On 2014-07-30 14:41, Dan Carpenter wrote: > On Wed, Jul

RE: [PATCH 13/19 v2] staging: comedi: amplc_pci230: remove unnecessary braces

2014-07-30 Thread Hartley Sweeten
On Wednesday, July 30, 2014 7:28 AM, Ian Abbott wrote: > On 2014-07-30 15:09, Dan Carpenter wrote: >> On Wed, Jul 30, 2014 at 03:04:03PM +0100, Ian Abbott wrote: >>> On 2014-07-30 14:41, Dan Carpenter wrote: On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote: > Signed-off-by: Ian A

Re: [PATCH 13/19 v2] staging: comedi: amplc_pci230: remove unnecessary braces

2014-07-30 Thread Ian Abbott
On 2014-07-30 15:09, Dan Carpenter wrote: On Wed, Jul 30, 2014 at 03:04:03PM +0100, Ian Abbott wrote: On 2014-07-30 14:41, Dan Carpenter wrote: On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote: Signed-off-by: Ian Abbott --- v2: Be less aggressive in brace removal. Keep them for out

Re: [PATCH 13/19 v2] staging: comedi: amplc_pci230: remove unnecessary braces

2014-07-30 Thread Dan Carpenter
On Wed, Jul 30, 2014 at 03:04:03PM +0100, Ian Abbott wrote: > On 2014-07-30 14:41, Dan Carpenter wrote: > >On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote: > >>Signed-off-by: Ian Abbott > >>--- > >>v2: Be less aggressive in brace removal. Keep them for outer nested > >>'if's. Keep the

Re: [PATCH 13/19 v2] staging: comedi: amplc_pci230: remove unnecessary braces

2014-07-30 Thread Ian Abbott
On 2014-07-30 14:41, Dan Carpenter wrote: On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote: Signed-off-by: Ian Abbott --- v2: Be less aggressive in brace removal. Keep them for outer nested 'if's. Keep them in outer control statements where the inner control statement uses braces.

Re: [PATCH 13/19 v2] staging: comedi: amplc_pci230: remove unnecessary braces

2014-07-30 Thread Dan Carpenter
On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote: > Signed-off-by: Ian Abbott > --- > v2: Be less aggressive in brace removal. Keep them for outer nested > 'if's. Keep them in outer control statements where the inner control > statement uses braces. Really every multi-line indent shou