Re: [PATCH 2/3] net: fec: convert to using gpiod framework

Hi, > From: Lothar Waßmann Sent: Monday, November 30, > 2015 7:33 PM > > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer; > > Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe > > Reynes; Richard Cochran; Russell King; Sascha Hauer; Stefan Agner; linux- >

Re: [PATCH 2/3] net: fec: convert to using gpiod framework

Hi, > From: Lothar Waßmann Sent: Monday, November 30, > 2015 7:33 PM > > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer; > > Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe > > Reynes; Richard Cochran; Russell King; Sascha

RE: [PATCH 2/3] net: fec: convert to using gpiod framework

From: Lothar Waßmann Sent: Monday, November 30, 2015 7:33 PM > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer; > Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe > Reynes; Richard Cochran; Russell King; Sascha Hauer; Stefan Agner; linux- >

Re: [PATCH 2/3] net: fec: convert to using gpiod framework

On Mon, Nov 30, 2015 at 9:32 AM, Lothar Waßmann wrote: > - gpio_set_value_cansleep(phy_reset, 1); > + gpiod_set_value_cansleep(phy_reset, 1); This will break some existing DTBs. Currently the fec driver does not care whether 'phy-reset-gpios' is active low or active high. (Yes, it

RE: [PATCH 2/3] net: fec: convert to using gpiod framework

From: Lothar Waßmann Sent: Monday, November 30, 2015 7:33 PM > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer; > Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe > Reynes; Richard Cochran; Russell King; Sascha Hauer; Stefan

Re: [PATCH 2/3] net: fec: convert to using gpiod framework

On Mon, Nov 30, 2015 at 9:32 AM, Lothar Waßmann wrote: > - gpio_set_value_cansleep(phy_reset, 1); > + gpiod_set_value_cansleep(phy_reset, 1); This will break some existing DTBs. Currently the fec driver does not care whether 'phy-reset-gpios' is active